-
Notifications
You must be signed in to change notification settings - Fork 2.1k
ci-operator/step-registry/gather/aws-console: Allow missing kubeconfig #14401
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci-operator/step-registry/gather/aws-console: Allow missing kubeconfig #14401
Conversation
Abhinav pointed out that there may be some IDs in the SHARED_DIR file, and when there are, we can gather those even if we lack a kubeconfig to extract additional IDs from within the cluster [1]. [1]: openshift#13398 (comment)
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: wking The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
/assign @cgwalters |
|
registration-operator e2e looks fine. e2e-aws-csi suggests we may also want to make cluster-API calls non-fatal, so we still gather |
|
@wking: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
Issues go stale after 90d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle stale |
|
Stale issues rot after 30d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle rotten |
|
Rotten issues close after 30d of inactivity. Reopen the issue by commenting /close |
|
@openshift-bot: Closed this PR. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@abhinavdahiya pointed out that there may be some IDs in the
SHARED_DIRfile, and when there are, we can gather those even if we lack akubeconfigto extract additional IDs from within the cluster.