Skip to content

Conversation

@wking
Copy link
Member

@wking wking commented Dec 16, 2020

@abhinavdahiya pointed out that there may be some IDs in the SHARED_DIR file, and when there are, we can gather those even if we lack a kubeconfig to extract additional IDs from within the cluster.

Abhinav pointed out that there may be some IDs in the SHARED_DIR file,
and when there are, we can gather those even if we lack a kubeconfig
to extract additional IDs from within the cluster [1].

[1]: openshift#13398 (comment)
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 16, 2020
@wking
Copy link
Member Author

wking commented Dec 16, 2020

/assign @cgwalters

@wking
Copy link
Member Author

wking commented Dec 16, 2020

registration-operator e2e looks fine. e2e-aws-csi suggests we may also want to make cluster-API calls non-fatal, so we still gather SHARED_DIR-provided IDs even when we have a kubeconfig but cannot reach the cluster. However, I also want to hear about it (by failing the step) if these fail because we somehow flub the command itself. I'm not sure how to distinguish between "failed because the cluster was dead/unreachable" and "failed because we need to tweak the step command". If folks feel like I should add || echo 'failed to get IDs from nodes and similar catchers and not worry about the "we need to tweak the step but don't notice because we're ignoring those errors" case, let me know.

@openshift-merge-robot
Copy link
Contributor

@wking: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/rehearse/openshift/aws-ebs-csi-driver/release-4.5/e2e-aws-csi ad42349 link /test pj-rehearse
ci/rehearse/open-cluster-management/registration-operator/master/e2e ad42349 link /test pj-rehearse
ci/rehearse/openshift/aws-ebs-csi-driver/master/e2e-aws-csi ad42349 link /test pj-rehearse
ci/rehearse/kubevirt/hyperconverged-cluster-operator/release-1.2/hco-e2e-image-index-aws ad42349 link /test pj-rehearse
ci/rehearse/openshift/oc/release-4.2/e2e-cmd ad42349 link /test pj-rehearse
ci/rehearse/openshift-knative/serverless-operator/master/4.6-upstream-e2e-aws-ocp-46 ad42349 link /test pj-rehearse
ci/rehearse/openshift/installer/master/e2e-aws-proxy ad42349 link /test pj-rehearse
ci/rehearse/openshift/origin/master/e2e-aws-proxy ad42349 link /test pj-rehearse
ci/rehearse/openshift/installer/master/e2e-aws-shared-vpc ad42349 link /test pj-rehearse
ci/rehearse/openshift/cluster-logging-operator/master/e2e-operator ad42349 link /test pj-rehearse
ci/rehearse/openshift/cluster-etcd-operator/master/e2e-agnostic ad42349 link /test pj-rehearse
ci/prow/pj-rehearse ad42349 link /test pj-rehearse
ci/rehearse/openshift/kubernetes/master/e2e-aws-selfupgrade ad42349 link /test pj-rehearse

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-bot
Copy link
Contributor

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci-robot openshift-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Mar 17, 2021
@openshift-bot
Copy link
Contributor

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

@openshift-ci-robot openshift-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Apr 16, 2021
@openshift-bot
Copy link
Contributor

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

@openshift-ci openshift-ci bot closed this May 16, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 16, 2021

@openshift-bot: Closed this PR.

Details

In response to this:

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants