Skip to content

Openshift-ansible AWS RHEL: update config name and mount openshift-ansible config#1440

Merged
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
vrutkovs:oa-aws-update-secret
Sep 11, 2018
Merged

Openshift-ansible AWS RHEL: update config name and mount openshift-ansible config#1440
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
vrutkovs:oa-aws-update-secret

Conversation

@vrutkovs
Copy link
Contributor

Fixes https://openshift-gce-devel.appspot.com/build/origin-ci-test/pr-logs/pull/openshift_openshift-ansible/9990/pull-ci-openshift-openshift-ansible-e2e-aws/2: a wrong config map is being mounted there, it should use openshift-ansible specific vars instead of new installer ones

PTAL @bbguimaraes

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 11, 2018
@sdodson
Copy link
Member

sdodson commented Sep 11, 2018

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 11, 2018
@bbguimaraes
Copy link
Contributor

/lgtm

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bbguimaraes, sdodson, vrutkovs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 11, 2018
@openshift-merge-robot openshift-merge-robot merged commit ccb0d83 into openshift:master Sep 11, 2018
@openshift-ci-robot
Copy link
Contributor

@vrutkovs: Updated the following 2 configmaps:

  • job-config configmap using the following files:
    • key openshift-openshift-ansible-presubmits.yaml using file ci-operator/jobs/openshift/openshift-ansible/openshift-openshift-ansible-presubmits.yaml
  • plugins configmap using the following files:
    • key plugins.yaml using file cluster/ci/config/prow/plugins.yaml
Details

In response to this:

Fixes https://openshift-gce-devel.appspot.com/build/origin-ci-test/pr-logs/pull/openshift_openshift-ansible/9990/pull-ci-openshift-openshift-ansible-e2e-aws/2: a wrong config map is being mounted there, it should use openshift-ansible specific vars instead of new installer ones

PTAL @bbguimaraes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@bbguimaraes
Copy link
Contributor

@vrutkovs: configmap created.

@vrutkovs vrutkovs deleted the oa-aws-update-secret branch May 16, 2019 11:06
derekhiggins pushed a commit to derekhiggins/release that referenced this pull request Oct 24, 2023
The payload image is called machine-image-customization-controller.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants