Skip to content

Conversation

@wking
Copy link
Member

@wking wking commented Sep 11, 2018

Since openshift/installer#221, the installer defaults to a recent RHCOS AMI. Drop the override here, so we can track RHCOS with only installer-repo bumps. I've left the variable in the template so that, if this repo needs to have its own, separate, opinion again, it can set the override again. However, to support the no-local-opinion case, the new local-opinion syntax will be:

export EC2_AMI_OVERRIDE='ec2AMIOverride: ami-07307c397daf4d02e'

CC @crawford, @eparis.

Since openshift/installer@66ef3beb (*: remove support for container
linux, 2018-09-06, openshift/installer#221), the installer defaults to
a recent RHCOS AMI.  Drop the override here, so we can track RHCOS
with only installer-repo bumps.  I've left the variable in the
template so that, if this repo needs to have its own, separate,
opinion again, it can set the override again.  However, to support the
no-local-opinion case, the new local-opinion syntax will be:

  export EC2_AMI_OVERRIDE='ec2AMIOverride: ami-07307c397daf4d02e'
@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 11, 2018
@crawford
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 11, 2018
@smarterclayton
Copy link
Contributor

smarterclayton commented Sep 11, 2018 via email

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: crawford, smarterclayton, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 11, 2018
@openshift-merge-robot openshift-merge-robot merged commit eb0d7b6 into openshift:master Sep 11, 2018
@openshift-ci-robot
Copy link
Contributor

@wking: Updated the following 2 configmaps:

  • prow-job-cluster-launch-installer-e2e configmap using the following files:
    • key cluster-launch-installer-e2e.yaml using file ci-operator/templates/cluster-launch-installer-e2e.yaml
  • cluster-profile-aws configmap using the following files:
    • key openshift.yaml using file cluster/test-deploy/aws/openshift.yaml
Details

In response to this:

Since openshift/installer#221, the installer defaults to a recent RHCOS AMI. Drop the override here, so we can track RHCOS with only installer-repo bumps. I've left the variable in the template so that, if this repo needs to have its own, separate, opinion again, it can set the override again. However, to support the no-local-opinion case, the new local-opinion syntax will be:

export EC2_AMI_OVERRIDE='ec2AMIOverride: ami-07307c397daf4d02e'

CC @crawford, @eparis.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@wking wking deleted the drop-installer-ami-override branch September 11, 2018 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants