-
Notifications
You must be signed in to change notification settings - Fork 2k
cluster-launch-installer-e2e*: Drop AMI override #1436
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cluster-launch-installer-e2e*: Drop AMI override #1436
Conversation
Since openshift/installer@66ef3beb (*: remove support for container linux, 2018-09-06, openshift/installer#221), the installer defaults to a recent RHCOS AMI. Drop the override here, so we can track RHCOS with only installer-repo bumps. I've left the variable in the template so that, if this repo needs to have its own, separate, opinion again, it can set the override again. However, to support the no-local-opinion case, the new local-opinion syntax will be: export EC2_AMI_OVERRIDE='ec2AMIOverride: ami-07307c397daf4d02e'
|
/lgtm |
|
/approve
…On Tue, Sep 11, 2018 at 1:25 PM OpenShift CI Robot ***@***.***> wrote:
[APPROVALNOTIFIER] This PR is *NOT APPROVED*
This pull-request has been approved by: *crawford
<#1436 (comment)>*, *wking
<#1436#>*
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: *smarterclayton*
If they are not already assigned, you can assign the PR to them by writing /assign
@smarterclayton in a comment when ready.
The full list of commands accepted by this bot can be found here
<https://go.k8s.io/bot-commands>.
The pull request process is described here
<https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process>
Needs approval from an approver in each of these files:
- *OWNERS <https://github.com/openshift/release/blob/master/OWNERS>*
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<#1436 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABG_p7Qd69MVlrAWbHPxJq_nDZOOB4V6ks5uZ_H4gaJpZM4WilpD>
.
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: crawford, smarterclayton, wking The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@wking: Updated the following 2 configmaps:
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Since openshift/installer#221, the installer defaults to a recent RHCOS AMI. Drop the override here, so we can track RHCOS with only installer-repo bumps. I've left the variable in the template so that, if this repo needs to have its own, separate, opinion again, it can set the override again. However, to support the no-local-opinion case, the new local-opinion syntax will be:
CC @crawford, @eparis.