Skip to content

Conversation

@wking
Copy link
Member

@wking wking commented Sep 10, 2018

Like #1354, but for the new smoke-test job from #1317.

Like 81a9e69 (openshift-installer-presubmits: Normalize job names,
2018-09-04, openshift#1354), but for the new smoke-test job from 199f2e0
(openshift/install e2e-aws add run smoke tests, 2018-08-28, openshift#1317).
@openshift-ci-robot openshift-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 10, 2018
@wking
Copy link
Member Author

wking commented Sep 11, 2018

@sallyom, can you /lgtm if this looks good to you? That should be sufficient to get this landed, since I'm an approver for this directory.

@stevekuznetsov
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 12, 2018
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: stevekuznetsov, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit d23621e into openshift:master Sep 12, 2018
@openshift-ci-robot
Copy link
Contributor

@wking: Updated the job-config configmap using the following files:

  • key openshift-installer-presubmits.yaml using file ci-operator/jobs/openshift/installer/openshift-installer-presubmits.yaml
Details

In response to this:

Like #1354, but for the new smoke-test job from #1317.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@wking wking deleted the normalize-smoke-name branch September 17, 2018 19:15
derekhiggins pushed a commit to derekhiggins/release that referenced this pull request Oct 24, 2023
Add a new variable - OC_MIRROR and support for using 'mirror-registry'
to create a local mirror registry and 'oc mirror' to do the actual
mirroring. This also requires MIRROR_IMAGES to be set. If OC_MIRROR
is not set then the mirroring will be done using 'oc adm release mirror'.

Note that OC_MIRROR is currently only support for the Agent
implementation.

The registry auth must also be added to the user's .docker/config.json
file.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants