Skip to content

openshift-metal3/dev-scripts: consistent job naming for metal-ipi #13769

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Nov 20, 2020
Merged

openshift-metal3/dev-scripts: consistent job naming for metal-ipi #13769

openshift-merge-robot merged 1 commit into from
Nov 20, 2020

Conversation

@stbenjam
Copy link
Member

@stbenjam stbenjam commented Nov 19, 2020 •
edited
Loading

We're working towards a consistent naming of the metal-ipi jobs,
specifically:

    - e2e-metal-ipi: IPv4, OpenShift SDN
    - e2e-metal-ipi-ovn-ipv6: IPv6, OVN
    - e2e-metal-ipi-ovn-dualstack: Dualstack, OVN

This should also apply to the upgrade job, meaning the IPv4/OpenShiftSDN
job should be simply "e2e-metal-ipi-upgrade."

I'm working my way through various repos to fix this. So far, I've done
the networking repos and 4.7 periodics. This updates the dev-scripts
configuration.

There's a lot of YAML here, but this is the end result of this PR on dev-scripts:

Job IP Stack SDN Always Run Required
e2e-metal-ipi IPv4 OpenShiftSDN X X
e2e-metal-ipi-upgrade IPv4 OpenShiftSDN
e2e-metal-ipi-ovn-ipv6 IPv6 OVN X X
e2e-metal-ipi-ovn-dualstack IPv4/IPv6 OVN
e2e-metal-ipi-virtualmedia IPv4 OpenShiftSDN

@stbenjam stbenjam mentioned this pull request Nov 19, 2020
Merged
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 19, 2020
@stbenjam
openshift-metal3/dev-scripts: consistent job naming for metal-ipi
0f313f6 
We're working towards a consistent naming of the metal-ipi jobs,
specifically:

        - e2e-metal-ipi: IPv4, OpenShift SDN
        - e2e-metal-ipi-ovn-ipv6: IPv6, OVN
        - e2e-metal-ipi-ovn-dualstack: Dualstack, OVN

This should also apply to the upgrade job, meaning the IPv4/OpenShiftSDN
job should be simply "e2e-metal-ipi-upgrade."

I'm working my way through various repos to fix this. So far, I've done
the networking repos and 4.7 periodics. This updates the dev-scripts
configuration now, which includes the new upgrade job.

It also only makes e2e-metal-ipi and e2e-metal-ipi-ovn-ipv6 mandatory on
dev-scripts.
@stbenjam
Copy link
Member Author

stbenjam commented Nov 19, 2020

/test app-ci-config-dry

andfasano
andfasano reviewed Nov 20, 2020
View reviewed changes
ci-operator/config/openshift-metal3/dev-scripts/openshift-metal3-dev-scripts-master.yaml
env:
DEVSCRIPTS_CONFIG: |
IP_STACK=v4
NETWORK_TYPE=OpenShiftSDN
Copy link
Contributor

@andfasano andfasano Nov 20, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about adding IP_STACK=v4 here?

Copy link
Member Author

@stbenjam stbenjam Nov 20, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is there, expand the diff - it's line 39.

Copy link
Contributor

@andfasano andfasano Nov 20, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 20, 2020
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Nov 20, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andfasano, stbenjam

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit d19c522 into openshift:master Nov 20, 2020
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Nov 20, 2020

@stbenjam: Updated the following 3 configmaps:

  • job-config-master configmap in namespace ci at cluster api.ci using the following files:
    • key openshift-metal3-dev-scripts-master-presubmits.yaml using file ci-operator/jobs/openshift-metal3/dev-scripts/openshift-metal3-dev-scripts-master-presubmits.yaml
  • job-config-master configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-metal3-dev-scripts-master-presubmits.yaml using file ci-operator/jobs/openshift-metal3/dev-scripts/openshift-metal3-dev-scripts-master-presubmits.yaml
  • ci-operator-master-configs configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-metal3-dev-scripts-master.yaml using file ci-operator/config/openshift-metal3/dev-scripts/openshift-metal3-dev-scripts-master.yaml
Details

In response to this:

We're working towards a consistent naming of the metal-ipi jobs,
specifically:

   - e2e-metal-ipi: IPv4, OpenShift SDN
   - e2e-metal-ipi-ovn-ipv6: IPv6, OVN
   - e2e-metal-ipi-ovn-dualstack: Dualstack, OVN

This should also apply to the upgrade job, meaning the IPv4/OpenShiftSDN
job should be simply "e2e-metal-ipi-upgrade."

I'm working my way through various repos to fix this. So far, I've done
the networking repos and 4.7 periodics. This updates the dev-scripts
configuration.

There's a lot of YAML here, but this is the end result of this PR on dev-scripts:

Job IP Stack SDN Always Run Required
e2e-metal-ipi IPv4 OpenShiftSDN X X
e2e-metal-ipi-upgrade IPv4 OpenShiftSDN
e2e-metal-ipi-ovn-ipv6 IPv6 OVN X X
e2e-metal-ipi-ovn-dualstack IPv4/IPv6 OVN
e2e-metal-ipi-virtualmedia IPv4 OpenShiftSDN

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@stbenjam stbenjam deleted the rename-upgrade-job branch November 23, 2020 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dhellmann dhellmann Awaiting requested review from dhellmann

@russellb russellb Awaiting requested review from russellb

1 more reviewer

@andfasano andfasano andfasano left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@andfasano andfasano

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@stbenjam @openshift-ci-robot @andfasano @openshift-merge-robot