Skip to content

Conversation

@bbguimaraes
Copy link
Contributor

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 6, 2018
@droslean
Copy link
Member

droslean commented Sep 6, 2018

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 6, 2018
@petr-muller
Copy link
Member

I agree this should eventually happen, but we need to make sure this won't lead to merges without reviews :)

@smarterclayton
Copy link
Contributor

/lgtm

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bbguimaraes, droslean, smarterclayton

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 6, 2018
@openshift-merge-robot openshift-merge-robot merged commit d36c0d1 into openshift:master Sep 6, 2018
@smarterclayton
Copy link
Contributor

Merge still requires you to hit lgtm

@bbguimaraes bbguimaraes deleted the dptp_owners branch September 7, 2018 08:58
derekhiggins pushed a commit to derekhiggins/release that referenced this pull request Oct 24, 2023
Avoid some errors that could cause trouble when cleaning the
environment.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants