Skip to content

Conversation

@jottofar
Copy link
Contributor

@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 10, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jottofar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 10, 2020
@jottofar
Copy link
Contributor Author

@wking can you do at least a quick check of my changes against referenced documentation to see if I'm on the right path.

@vrutkovs
Copy link
Contributor

Looks like a way to go, needs make ci-operator-config jobs to generate missing configs

Copy link
Member

@wking wking Nov 12, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

openshift/cincinnati-operator#76 is failing because we don't have a v3 kustomize in the test-step image. But you could be compatible with the operator SDK layout with:

operators:
  bundles:
  - dockerfile_path: bundle.Dockerfile
  substitutions:
  - pullspec: cincinnati:latest
    with: stable:operand
  - pullspec: controller:latest
    with: pipeline:cincinnati-operator

here.

@openshift-merge-robot
Copy link
Contributor

@jottofar: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/generated-config 8383eca link /test generated-config
ci/prow/ci-operator-config-metadata 8383eca link /test ci-operator-config-metadata

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@jottofar
Copy link
Contributor Author

jottofar commented Dec 4, 2020

Closing for now since we are not doing bundling as part of our CI right now.

/close

@openshift-ci-robot
Copy link
Contributor

@jottofar: Closed this PR.

Details

In response to this:

Closing for now since we are not doing bundling as part of our CI right now.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants