Skip to content

Conversation

@eparis
Copy link
Member

@eparis eparis commented Sep 1, 2018

"HVM":"ami-06d864b4154214132"
"SnapshotID":"snap-07b63a4c2f8869c15"
"S3Object":"s3://openshift-qe-images/rhcos/cloud/rhcos-4.0.5122-aws.vmdk"

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 1, 2018
@eparis
Copy link
Member Author

eparis commented Sep 1, 2018

I believe this really should get it's value from
http://aos-ostree.rhev-ci-vms.eng.rdu2.redhat.com/rhcos/images/aws-us-east-1-tested.json | jq -r '.HVM'
But (a) I don't think that json file is public and (b) I don't know where it should even be pushed, so we can use it...

@wking
Copy link
Member

wking commented Sep 4, 2018

Can this PR and/or the commit message give more information about what's behind ami-09d77e1a857d5d136? Is it just whichever RHCOS image had most recently passed testing on the 1st? The link you give currently has ami-06d864b4154214132 and "SnapshotID":"snap-07b63a4c2f8869c15". Maybe include the snapshot ID? And or something else that can be traced back to an openshift/os commit?

"HVM":"ami-06d864b4154214132"
"SnapshotID":"snap-07b63a4c2f8869c15"
"S3Object":"s3://openshift-qe-images/rhcos/cloud/rhcos-4.0.5122-aws.vmdk"
@eparis
Copy link
Member Author

eparis commented Sep 4, 2018

@wking yes, it's the latest the RHCOS team has created.

@ashcrow
Copy link
Member

ashcrow commented Sep 4, 2018

But (a) I don't think that json file is public and (b) I don't know where it should even be pushed, so we can use it...

This is correct. We've added a card so we don't lose the request to make it public.

@eparis
Copy link
Member Author

eparis commented Sep 4, 2018

@smarterclayton fixed based on trevor review.

@smarterclayton
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 4, 2018
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: eparis, smarterclayton

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 4, 2018
@openshift-merge-robot openshift-merge-robot merged commit 7d71572 into openshift:master Sep 4, 2018
@openshift-ci-robot
Copy link
Contributor

@eparis: Updated the prow-job-cluster-launch-installer-e2e configmap using the following files:

  • key cluster-launch-installer-e2e.yaml using file ci-operator/templates/cluster-launch-installer-e2e.yaml
Details

In response to this:

"HVM":"ami-06d864b4154214132"
"SnapshotID":"snap-07b63a4c2f8869c15"
"S3Object":"s3://openshift-qe-images/rhcos/cloud/rhcos-4.0.5122-aws.vmdk"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

bison pushed a commit to enxebre/installer that referenced this pull request Sep 7, 2018
We currently calculate CoreOS Container Linux AMIs in Terraform
(installer/modules/aws/ami), but with the coming shift to RHCOS and Go
asset generation, it would be nice to calculate them in Go.  This
commit adds a package to do so.  Currently it's enough of a stub to
support testing, with the value based on [1]:

  {
    "HVM":"ami-06d864b4154214132",
    "SnapshotID":"snap-07b63a4c2f8869c15",
    "S3Object":"s3://openshift-qe-images/rhcos/cloud/rhcos-4.0.5122-aws.vmdk"
  }

from [2].  Once we get a public version of [2] (plans in [3]), we can
replace the stub in this package with something that works for more
regions and channels.

[1]: openshift/release#1344 (comment)
[2]: http://aos-ostree.rhev-ci-vms.eng.rdu2.redhat.com/rhcos/images/aws-us-east-1-tested.json
[3]: openshift/release#1344 (comment)
@eparis eparis deleted the bump-ami branch January 27, 2020 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants