-
Notifications
You must be signed in to change notification settings - Fork 2k
ci-operator/templates/cluster-launch-installer-e2e.yaml: modern RHCOS #1344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I believe this really should get it's value from |
|
Can this PR and/or the commit message give more information about what's behind |
"HVM":"ami-06d864b4154214132" "SnapshotID":"snap-07b63a4c2f8869c15" "S3Object":"s3://openshift-qe-images/rhcos/cloud/rhcos-4.0.5122-aws.vmdk"
|
@wking yes, it's the latest the RHCOS team has created. |
This is correct. We've added a card so we don't lose the request to make it public. |
|
@smarterclayton fixed based on trevor review. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: eparis, smarterclayton The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@eparis: Updated the
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
We currently calculate CoreOS Container Linux AMIs in Terraform
(installer/modules/aws/ami), but with the coming shift to RHCOS and Go
asset generation, it would be nice to calculate them in Go. This
commit adds a package to do so. Currently it's enough of a stub to
support testing, with the value based on [1]:
{
"HVM":"ami-06d864b4154214132",
"SnapshotID":"snap-07b63a4c2f8869c15",
"S3Object":"s3://openshift-qe-images/rhcos/cloud/rhcos-4.0.5122-aws.vmdk"
}
from [2]. Once we get a public version of [2] (plans in [3]), we can
replace the stub in this package with something that works for more
regions and channels.
[1]: openshift/release#1344 (comment)
[2]: http://aos-ostree.rhev-ci-vms.eng.rdu2.redhat.com/rhcos/images/aws-us-east-1-tested.json
[3]: openshift/release#1344 (comment)
"HVM":"ami-06d864b4154214132"
"SnapshotID":"snap-07b63a4c2f8869c15"
"S3Object":"s3://openshift-qe-images/rhcos/cloud/rhcos-4.0.5122-aws.vmdk"