Revert "Add OWNERS for templates" #1329
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit a3e9a3f (openshift#1279). Using filters for approvers and reviewers is the long-term goal, but the approve plugin can't handle this yet [1,2]. [1]: kubernetes/test-infra#7690 [2]: https://github.com/kubernetes/community/blame/19dc4bed5b05c23a69e631f96573f8ed2e0774cb/contributors/guide/owners.md#L86-L87
openshift-ci-robot
added
the
size/S
Member
Author
|
/assign @stevekuznetsov |
Contributor
|
/shrug |
Contributor
|
/lgtm |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: stevekuznetsov, wking The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
wking
added a commit
to wking/openshift-release
that referenced
this pull request
Oct 1, 2018
To maintain OWNERS for project-specific templates. This brings us back closer to where we were before b49db8b (Revert "Add OWNERS for templates", 2018-08-30, openshift#1329), except now we're using an approach that's well-supported by the current Prow.
derekhiggins
pushed a commit
to derekhiggins/release
that referenced
this pull request
Oct 24, 2023
Doing this so we can run MetalLB E2E tests from a specific branch to match the deployment version.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit a3e9a3f (#1279).
Using filters for approvers and reviewers is the long-term goal, but the
approveplugin can't handle this yet (kubernetes/test-infra#7690, with new docs here).