Skip to content

WIP Adding e2e kubevirt #13165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
bardielle wants to merge 9 commits into from
Closed

WIP Adding e2e kubevirt #13165

bardielle wants to merge 9 commits into from

Conversation

@bardielle
Copy link
Contributor

@bardielle bardielle commented Oct 27, 2020

No description provided.

@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 27, 2020
@bardielle bardielle force-pushed the adding_e2e_kubevirt branch from 15b1b12 to aa7c502 Compare October 27, 2020 16:11
@bardielle bardielle force-pushed the adding_e2e_kubevirt branch 2 times, most recently from 8bc243b to 2724f8f Compare October 27, 2020 16:56
@openshift-ci-robot openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 27, 2020
@bardielle
Copy link
Contributor Author

bardielle commented Oct 27, 2020

/test ci/rehearse/openshift/cluster-api-provider-kubevirt/master/e2e-kubevirt

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Oct 27, 2020

@bardielle: The specified target(s) for /test were not found.
The following commands are available to trigger jobs:

  • /test app-ci-config-dry
  • /test boskos-config
  • /test build01-dry
  • /test build02-dry
  • /test ci-operator-config
  • /test ci-operator-config-metadata
  • /test ci-operator-registry
  • /test ci-testgrid-allow-list
  • /test config
  • /test core-dry
  • /test core-valid
  • /test correctly-sharded-config
  • /test generated-config
  • /test generated-dashboards
  • /test ordered-prow-config
  • /test owners
  • /test pj-rehearse
  • /test prow-config
  • /test prow-config-filenames
  • /test prow-config-semantics
  • /test release-config
  • /test release-controller-config
  • /test services-dry
  • /test services-valid
  • /test step-registry-metadata
  • /test step-registry-shellcheck
  • /test vsphere-dry
  • /test pylint
  • /test yamllint

Use /test all to run the following jobs:

  • pull-ci-openshift-release-master-app-ci-config-dry
  • pull-ci-openshift-release-master-boskos-config
  • pull-ci-openshift-release-master-build01-dry
  • pull-ci-openshift-release-master-build02-dry
  • pull-ci-openshift-release-master-ci-operator-config
  • pull-ci-openshift-release-master-ci-operator-config-metadata
  • pull-ci-openshift-release-master-ci-operator-registry
  • pull-ci-openshift-release-master-config
  • pull-ci-openshift-release-master-core-dry
  • pull-ci-openshift-release-master-core-valid
  • pull-ci-openshift-release-master-correctly-sharded-config
  • pull-ci-openshift-release-master-generated-config
  • pull-ci-openshift-release-master-generated-dashboards
  • pull-ci-openshift-release-master-ordered-prow-config
  • pull-ci-openshift-release-master-owners
  • pull-ci-openshift-release-master-pj-rehearse
  • pull-ci-openshift-release-master-prow-config
  • pull-ci-openshift-release-master-prow-config-filenames
  • pull-ci-openshift-release-master-prow-config-semantics
  • pull-ci-openshift-release-master-release-config
  • pull-ci-openshift-release-master-release-controller-config
  • pull-ci-openshift-release-master-services-dry
  • pull-ci-openshift-release-master-services-valid
  • pull-ci-openshift-release-master-step-registry-metadata
  • pull-ci-openshift-release-master-step-registry-shellcheck
  • pull-ci-openshift-release-master-vsphere-dry
  • pull-ci-openshift-release-yamllint
Details

In response to this:

/test ci/rehearse/openshift/cluster-api-provider-kubevirt/master/e2e-kubevirt

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@bardielle
Copy link
Contributor Author

bardielle commented Oct 27, 2020

/test pj-rehearse

@bardielle
Copy link
Contributor Author

bardielle commented Oct 27, 2020

/retest

@bardielle bardielle force-pushed the adding_e2e_kubevirt branch from 2724f8f to 73113c9 Compare October 28, 2020 06:22
@openshift-ci-robot openshift-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 28, 2020
@bardielle bardielle force-pushed the adding_e2e_kubevirt branch from 46b8bad to 5601e77 Compare October 28, 2020 08:08
@bardielle bardielle force-pushed the adding_e2e_kubevirt branch 5 times, most recently from 85e8db4 to cdb867d Compare October 28, 2020 11:20
chenyosef
chenyosef reviewed Oct 28, 2020
View reviewed changes
ci-operator/step-registry/ipi/conf/kubevirt/install/ipi-conf-kubevirt-install-commands.sh Outdated
Copy link

@chenyosef chenyosef Oct 28, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why does a file names ipi-conf-kubevirt-install-commands.sh should handle cases of other CLUSTER_TYPES ? I would expect to get the Unsupported cluster type for all types except for kubevirt.

Copy link
Contributor Author

@bardielle bardielle Oct 28, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a side branch for testing our usecase
It's only for testing our image - I must duplicate the commands.sh file but use env variable with our image

@bardielle
Copy link
Contributor Author

bardielle commented Oct 28, 2020

/retest ci/prow/pj-rehearse

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Oct 28, 2020

@bardielle: The /retest command does not accept any targets.
The following commands are available to trigger jobs:

  • /test app-ci-config-dry
  • /test boskos-config
  • /test build01-dry
  • /test build02-dry
  • /test ci-operator-config
  • /test ci-operator-config-metadata
  • /test ci-operator-registry
  • /test ci-testgrid-allow-list
  • /test config
  • /test core-dry
  • /test core-valid
  • /test correctly-sharded-config
  • /test generated-config
  • /test generated-dashboards
  • /test ordered-prow-config
  • /test owners
  • /test pj-rehearse
  • /test prow-config
  • /test prow-config-filenames
  • /test prow-config-semantics
  • /test release-config
  • /test release-controller-config
  • /test services-dry
  • /test services-valid
  • /test step-registry-metadata
  • /test step-registry-shellcheck
  • /test vsphere-dry
  • /test pylint
  • /test yamllint

Use /test all to run the following jobs:

  • pull-ci-openshift-release-master-app-ci-config-dry
  • pull-ci-openshift-release-master-boskos-config
  • pull-ci-openshift-release-master-build01-dry
  • pull-ci-openshift-release-master-build02-dry
  • pull-ci-openshift-release-master-ci-operator-config
  • pull-ci-openshift-release-master-ci-operator-config-metadata
  • pull-ci-openshift-release-master-ci-operator-registry
  • pull-ci-openshift-release-master-config
  • pull-ci-openshift-release-master-core-dry
  • pull-ci-openshift-release-master-core-valid
  • pull-ci-openshift-release-master-correctly-sharded-config
  • pull-ci-openshift-release-master-generated-config
  • pull-ci-openshift-release-master-generated-dashboards
  • pull-ci-openshift-release-master-ordered-prow-config
  • pull-ci-openshift-release-master-owners
  • pull-ci-openshift-release-master-pj-rehearse
  • pull-ci-openshift-release-master-prow-config
  • pull-ci-openshift-release-master-prow-config-filenames
  • pull-ci-openshift-release-master-prow-config-semantics
  • pull-ci-openshift-release-master-release-config
  • pull-ci-openshift-release-master-release-controller-config
  • pull-ci-openshift-release-master-services-dry
  • pull-ci-openshift-release-master-services-valid
  • pull-ci-openshift-release-master-step-registry-metadata
  • pull-ci-openshift-release-master-step-registry-shellcheck
  • pull-ci-openshift-release-master-vsphere-dry
  • pull-ci-openshift-release-yamllint
Details

In response to this:

/retest ci/prow/pj-rehearse

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@bardielle
Copy link
Contributor Author

bardielle commented Oct 28, 2020

/retest

@bardielle bardielle force-pushed the adding_e2e_kubevirt branch 3 times, most recently from 4702b7f to 04e3f41 Compare October 28, 2020 14:01
@bardielle bardielle force-pushed the adding_e2e_kubevirt branch from a1bf236 to 354a9ea Compare November 1, 2020 14:01
@bardielle bardielle force-pushed the adding_e2e_kubevirt branch 3 times, most recently from 24cbb2f to d051551 Compare November 1, 2020 15:06
@bardielle
Copy link
Contributor Author

bardielle commented Nov 1, 2020

/test pj-rehearse

@bardielle bardielle force-pushed the adding_e2e_kubevirt branch from d051551 to 816d375 Compare November 1, 2020 15:40
@bardielle
Copy link
Contributor Author

bardielle commented Nov 1, 2020

/test pj-rehearse

2 similar comments
@bardielle
Copy link
Contributor Author

bardielle commented Nov 1, 2020

/test pj-rehearse

@bardielle
Copy link
Contributor Author

bardielle commented Nov 1, 2020

/test pj-rehearse

@bardielle bardielle force-pushed the adding_e2e_kubevirt branch 3 times, most recently from fee6c6c to 78a33bb Compare November 2, 2020 09:22
@bardielle
Copy link
Contributor Author

bardielle commented Nov 2, 2020

/test pj-rehearse

@bardielle
Copy link
Contributor Author

bardielle commented Nov 2, 2020

/retest

1 similar comment
@bardielle
Copy link
Contributor Author

bardielle commented Nov 2, 2020

/retest

@bardielle bardielle force-pushed the adding_e2e_kubevirt branch from 78a33bb to 6d6efad Compare November 4, 2020 14:37
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Nov 4, 2020

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: bardielle
To complete the pull request process, please assign crawford after the PR has been reviewed.
You can assign the PR to them by writing /assign @crawford in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@bardielle bardielle force-pushed the adding_e2e_kubevirt branch 2 times, most recently from 14a4227 to 21815e6 Compare November 4, 2020 14:56
@bardielle
Copy link
Contributor Author

bardielle commented Nov 4, 2020

/retest

@bardielle bardielle force-pushed the adding_e2e_kubevirt branch 2 times, most recently from 50a1b70 to dcd2c53 Compare November 4, 2020 15:35
@bardielle bardielle force-pushed the adding_e2e_kubevirt branch from dcd2c53 to b0b4f1b Compare November 4, 2020 16:58
@bardielle
Copy link
Contributor Author

bardielle commented Nov 5, 2020

/retest

@openshift-merge-robot
Copy link
Contributor

openshift-merge-robot commented Nov 10, 2020

@bardielle: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/ci-operator-registry b0b4f1b link /test ci-operator-registry
ci/prow/ci-operator-config-metadata b0b4f1b link /test ci-operator-config-metadata
ci/rehearse/openshift/cluster-api-provider-kubevirt/master/e2e-kubevirt b0b4f1b link /test pj-rehearse
ci/prow/pj-rehearse b0b4f1b link /test pj-rehearse
ci/prow/deprecate-templates b0b4f1b link /test deprecate-templates

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@bardielle bardielle closed this Nov 15, 2020
@chenyosef chenyosef mentioned this pull request Nov 18, 2020
Merged
@bardielle bardielle deleted the adding_e2e_kubevirt branch December 28, 2020 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ravidbro ravidbro Awaiting requested review from ravidbro

1 more reviewer

@chenyosef chenyosef chenyosef left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@bardielle @openshift-ci-robot @openshift-merge-robot @chenyosef