Skip to content

Conversation

@wking
Copy link
Member

@wking wking commented Oct 23, 2020

The Cincinnati image is the operand, not the operator. Fixes a typo from efcafb6 (#12486).

/assign @jottofar

…incy

The Cincinnati image is the operand, not the operator.  Fixes a typo
from efcafb6 (ci-operator/config/openshift/cincinnati-operator:
Move e2e-operator to multi-step, 2020-10-06, openshift#12486).
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 23, 2020
@wking
Copy link
Member Author

wking commented Oct 23, 2020

4.7 rehearsal:

    cincinnati_creation_test.go:133: PodDisruptionBudget cincinnati-operator available
    cincinnati_creation_test.go:145: no kind is registered for the type v1.Route in scheme "k8s.io/client-go/kubernetes/scheme/register.go:67"

And we do actually have operator logs:

{"level":"info","ts":1603488894.505651,"logger":"cmd","msg":"Operator Version: 0.0.1"}
{"level":"info","ts":1603488894.505686,"logger":"cmd","msg":"Go Version: go1.13.8"}
...

Slowly inching closer to success :p.

@openshift-merge-robot
Copy link
Contributor

@wking: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/rehearse/openshift/cincinnati-operator/release-4.6/operator-e2e bc324c9 link /test pj-rehearse
ci/rehearse/openshift/cincinnati-operator/release-4.8/operator-e2e bc324c9 link /test pj-rehearse
ci/rehearse/openshift/cincinnati-operator/release-4.7/operator-e2e bc324c9 link /test pj-rehearse
ci/rehearse/openshift/cincinnati-operator/master/operator-e2e bc324c9 link /test pj-rehearse
ci/prow/pj-rehearse bc324c9 link /test pj-rehearse

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@jottofar
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 23, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jottofar, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit a007bb7 into openshift:master Oct 23, 2020
@openshift-ci-robot
Copy link
Contributor

@wking: Updated the following 4 configmaps:

  • ci-operator-master-configs configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-cincinnati-operator-master.yaml using file ci-operator/config/openshift/cincinnati-operator/openshift-cincinnati-operator-master.yaml
  • ci-operator-4.6-configs configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-cincinnati-operator-release-4.6.yaml using file ci-operator/config/openshift/cincinnati-operator/openshift-cincinnati-operator-release-4.6.yaml
  • ci-operator-4.7-configs configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-cincinnati-operator-release-4.7.yaml using file ci-operator/config/openshift/cincinnati-operator/openshift-cincinnati-operator-release-4.7.yaml
  • ci-operator-4.8-configs configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-cincinnati-operator-release-4.8.yaml using file ci-operator/config/openshift/cincinnati-operator/openshift-cincinnati-operator-release-4.8.yaml
Details

In response to this:

The Cincinnati image is the operand, not the operator. Fixes a typo from efcafb6 (#12486).

/assign @jottofar

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@wking wking deleted the cincy-operator-operand-typo branch October 23, 2020 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants