Skip to content

Conversation

@wking
Copy link
Member

@wking wking commented Oct 21, 2020

Some issues only turn up in minor-version bumps, and with this change machine-config developers will be able to comment on a pull request with:

/test e2e-upgrade-minor

to launch a job that installs the previous minor's OCP candidate release and updates to a release built from the in-flight pull request.

Generated by manually editing ci-operator/config following the docs, running:

$ make update

and editing the configurable always_run and optional properties.

WIP because I'm waiting on #12959. I'll rebase this on top after that lands.

…grade-minor

Some issues only turn up in minor-version bumps [1], and with this
change machine-config developers will be able to comment on a pull
request with:

  /test e2e-upgrade-minor

to launch a job that installs the previous minor's OCP candidate
release and updates to a release built from the in-flight pull
request.

Generated by manually editing ci-operator/config following [2], running:

  $ make update

and editing the configurable always_run and optional properties [3].

WIP because I'm waiting on openshift#12959.  I'll rebase this on top after that lands.

[1]: https://bugzilla.redhat.com/show_bug.cgi?id=1890250#c5
[2]: https://github.com/openshift/ci-docs/blame/047e38285a227888733b1f5a49fd844d047d50f8/content/en/docs/architecture/ci-operator.md#L278-L283
[3]: https://github.com/openshift/ci-tools/blob/d45a03ce3a38d79a1b7bf82f35919505dc3d1c9e/GENERATOR.md#hand-edited-prow-configuration
@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 21, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: wking
To complete the pull request process, please assign ericavonb after the PR has been reviewed.
You can assign the PR to them by writing /assign @ericavonb in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cgwalters
Copy link
Member

Superficial LGTM - I don't know the details of the jobs, but sounds good to me.
I do think this could apply to many if not most other operators - any reason not to make it apply to all release image components?

@openshift-ci-robot openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 9, 2020
@openshift-ci-robot
Copy link
Contributor

@wking: PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot
Copy link
Contributor

@wking: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/pj-rehearse 9c81e83 link /test pj-rehearse
ci/prow/boskos-config-generation 9c81e83 link /test boskos-config-generation
ci/prow/secret-generator-config-valid 9c81e83 link /test secret-generator-config-valid
ci/prow/deprecate-templates 9c81e83 link /test deprecate-templates

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 25, 2021

@wking: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/ci-secret-generator-config 9c81e83 link /test ci-secret-generator-config
ci/prow/ci-secret-bootstrap-config-validation 9c81e83 link /test ci-secret-bootstrap-config-validation

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-bot
Copy link
Contributor

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci openshift-ci bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 27, 2021
@openshift-bot
Copy link
Contributor

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

@openshift-ci openshift-ci bot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jun 26, 2021
@openshift-bot
Copy link
Contributor

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

@openshift-ci openshift-ci bot closed this Jul 26, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 26, 2021

@openshift-bot: Closed this PR.

Details

In response to this:

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants