Skip to content

Fix resources for generated jobs #1296

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Aug 28, 2018
Merged

Fix resources for generated jobs #1296

openshift-merge-robot merged 1 commit into from
Aug 28, 2018

Conversation

@petr-muller
Copy link
Member

@petr-muller petr-muller commented Aug 28, 2018 •
edited
Loading

These jobs had duplicate 'resources:' set.

/cc @stevekuznetsov @bbguimaraes @droslean

@petr-muller
Fix resources for generated jobs
a29ac76 
These jobs had duplicate 'resources:' set.
@openshift-ci-robot openshift-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Aug 28, 2018
@droslean
Copy link
Member

droslean commented Aug 28, 2018

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 28, 2018
@droslean
Copy link
Member

droslean commented Aug 28, 2018

/approve

@petr-muller petr-muller mentioned this pull request Aug 28, 2018
Merged
4 tasks
@stevekuznetsov
Copy link
Contributor

stevekuznetsov commented Aug 28, 2018

/approve

@stevekuznetsov
Copy link
Contributor

stevekuznetsov commented Aug 28, 2018

/lgtm
/approve

@stevekuznetsov
Copy link
Contributor

stevekuznetsov commented Aug 28, 2018

/woof

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Aug 28, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: droslean, petr-muller, stevekuznetsov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Aug 28, 2018

@stevekuznetsov: dog image

Details

In response to this:

/woof

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 28, 2018
@openshift-merge-robot openshift-merge-robot merged commit ddd6f1b into openshift:master Aug 28, 2018
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Aug 28, 2018

@petr-muller: Updated the job-config configmap using the following files:

  • key openshift-cluster-ingress-operator-postsubmits.yaml using file ci-operator/jobs/openshift/cluster-ingress-operator/openshift-cluster-ingress-operator-postsubmits.yaml
  • key openshift-cluster-ingress-operator-presubmits.yaml using file ci-operator/jobs/openshift/cluster-ingress-operator/openshift-cluster-ingress-operator-presubmits.yaml
  • key openshift-cluster-operator-postsubmits.yaml using file ci-operator/jobs/openshift/cluster-operator/openshift-cluster-operator-postsubmits.yaml
  • key openshift-cluster-operator-presubmits.yaml using file ci-operator/jobs/openshift/cluster-operator/openshift-cluster-operator-presubmits.yaml
  • key openshift-ci-operator-prowgen-postsubmits.yaml using file ci-operator/jobs/openshift/ci-operator-prowgen/openshift-ci-operator-prowgen-postsubmits.yaml
  • key openshift-ci-operator-prowgen-presubmits.yaml using file ci-operator/jobs/openshift/ci-operator-prowgen/openshift-ci-operator-prowgen-presubmits.yaml
  • key openshift-cluster-dns-operator-postsubmits.yaml using file ci-operator/jobs/openshift/cluster-dns-operator/openshift-cluster-dns-operator-postsubmits.yaml
  • key openshift-cluster-dns-operator-presubmits.yaml using file ci-operator/jobs/openshift/cluster-dns-operator/openshift-cluster-dns-operator-presubmits.yaml
Details

In response to this:

These jobs had duplicate 'resources:' set.

/cc @stevekuznetsov @bbguimaraes @droslean

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@petr-muller petr-muller deleted the fix-resources branch August 28, 2018 14:44
derekhiggins pushed a commit to derekhiggins/release that referenced this pull request Oct 24, 2023
@andfasano
Add config var to modify hosts definition order (master/workers) in t…
2a89226 
…he install-config.yaml (openshift#1296)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pravisankar pravisankar Awaiting requested review from pravisankar

@ramr ramr Awaiting requested review from ramr

Assignees

@stevekuznetsov stevekuznetsov

@droslean droslean

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@petr-muller @droslean @stevekuznetsov @openshift-ci-robot @openshift-merge-robot