Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -260,8 +260,8 @@ tests:
steps:
cluster_profile: aws
dependencies:
OPENSHIFT_INSTALL_RELEASE_IMAGE_OVERRIDE: release:latest
OPENSHIFT_UPGRADE_RELEASE_IMAGE_OVERRIDE: release:initial
OPENSHIFT_INSTALL_RELEASE_IMAGE: release:latest
OPENSHIFT_UPGRADE_RELEASE_IMAGE: release:initial
workflow: openshift-upgrade-aws
- as: e2e-aws-serial
steps:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -260,8 +260,8 @@ tests:
steps:
cluster_profile: aws
dependencies:
OPENSHIFT_INSTALL_RELEASE_IMAGE_OVERRIDE: release:latest
OPENSHIFT_UPGRADE_RELEASE_IMAGE_OVERRIDE: release:initial
OPENSHIFT_INSTALL_RELEASE_IMAGE: release:latest
OPENSHIFT_UPGRADE_RELEASE_IMAGE: release:initial
workflow: openshift-upgrade-aws
- as: e2e-aws-serial
steps:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -261,8 +261,8 @@ tests:
steps:
cluster_profile: aws
dependencies:
OPENSHIFT_INSTALL_RELEASE_IMAGE_OVERRIDE: release:latest
OPENSHIFT_UPGRADE_RELEASE_IMAGE_OVERRIDE: release:initial
OPENSHIFT_INSTALL_RELEASE_IMAGE: release:latest
OPENSHIFT_UPGRADE_RELEASE_IMAGE: release:initial
workflow: openshift-upgrade-aws
- as: e2e-aws-serial
steps:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -259,9 +259,6 @@ tests:
- as: e2e-aws-selfupgrade
steps:
cluster_profile: aws
dependencies:
OPENSHIFT_INSTALL_RELEASE_IMAGE_OVERRIDE: release:latest
OPENSHIFT_UPGRADE_RELEASE_IMAGE_OVERRIDE: release:initial
workflow: openshift-upgrade-aws
- as: e2e-aws-serial
steps:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -260,8 +260,8 @@ tests:
steps:
cluster_profile: aws
dependencies:
OPENSHIFT_INSTALL_RELEASE_IMAGE_OVERRIDE: release:latest
OPENSHIFT_UPGRADE_RELEASE_IMAGE_OVERRIDE: release:initial
OPENSHIFT_INSTALL_RELEASE_IMAGE: release:latest
OPENSHIFT_UPGRADE_RELEASE_IMAGE: release:initial
workflow: openshift-upgrade-aws
- as: e2e-aws-serial
steps:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -260,8 +260,8 @@ tests:
steps:
cluster_profile: aws
dependencies:
OPENSHIFT_INSTALL_RELEASE_IMAGE_OVERRIDE: release:latest
OPENSHIFT_UPGRADE_RELEASE_IMAGE_OVERRIDE: release:initial
OPENSHIFT_INSTALL_RELEASE_IMAGE: release:latest
OPENSHIFT_UPGRADE_RELEASE_IMAGE: release:initial
workflow: openshift-upgrade-aws
- as: e2e-aws-serial
steps:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -261,8 +261,8 @@ tests:
steps:
cluster_profile: aws
dependencies:
OPENSHIFT_INSTALL_RELEASE_IMAGE_OVERRIDE: release:latest
OPENSHIFT_UPGRADE_RELEASE_IMAGE_OVERRIDE: release:initial
OPENSHIFT_INSTALL_RELEASE_IMAGE: release:latest
OPENSHIFT_UPGRADE_RELEASE_IMAGE: release:initial
workflow: openshift-upgrade-aws
- as: e2e-aws-serial
steps:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -259,9 +259,6 @@ tests:
- as: e2e-aws-selfupgrade
steps:
cluster_profile: aws
dependencies:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

self upgrade tests need to have

      OPENSHIFT_INSTALL_RELEASE_IMAGE: release:latest
      OPENSHIFT_UPGRADE_RELEASE_IMAGE: release:initial

OPENSHIFT_INSTALL_RELEASE_IMAGE_OVERRIDE: release:latest
OPENSHIFT_UPGRADE_RELEASE_IMAGE_OVERRIDE: release:initial
workflow: openshift-upgrade-aws
- as: e2e-aws-serial
steps:
Expand Down
6 changes: 3 additions & 3 deletions ci-operator/step-registry/ipi/conf/ipi-conf-commands.sh
Original file line number Diff line number Diff line change
Expand Up @@ -8,12 +8,12 @@ cluster_name=${NAMESPACE}-${JOB_NAME_HASH}

out=${SHARED_DIR}/install-config.yaml

if [[ -z "$RELEASE_IMAGE_LATEST" ]]; then
echo "RELEASE_IMAGE_LATEST is an empty string, exiting"
if [[ -z "$OPENSHIFT_INSTALL_RELEASE_IMAGE" ]]; then
echo "OPENSHIFT_INSTALL_RELEASE_IMAGE is an empty string, exiting"
exit 1
fi

echo "Installing from release ${RELEASE_IMAGE_LATEST}"
echo "Installing from release ${OPENSHIFT_INSTALL_RELEASE_IMAGE}"

ssh_pub_key=$(<"${CLUSTER_PROFILE_DIR}/ssh-publickey")
pull_secret=$(<"${CLUSTER_PROFILE_DIR}/pull-secret")
Expand Down
3 changes: 3 additions & 0 deletions ci-operator/step-registry/ipi/conf/ipi-conf-ref.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,9 @@ ref:
name: centos
tag: '8'
commands: ipi-conf-commands.sh
dependencies:
- name: "release:latest"
env: OPENSHIFT_INSTALL_RELEASE_IMAGE
resources:
requests:
cpu: 10m
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -37,12 +37,13 @@ function prepare_next_steps() {
trap 'prepare_next_steps' EXIT
trap 'CHILDREN=$(jobs -p); if test -n "${CHILDREN}"; then kill ${CHILDREN} && wait; fi' TERM

if [[ -z "$OPENSHIFT_INSTALL_RELEASE_IMAGE_OVERRIDE" ]]; then
echo "OPENSHIFT_INSTALL_RELEASE_IMAGE_OVERRIDE is an empty string, exiting"
if [[ -z "$OPENSHIFT_INSTALL_RELEASE_IMAGE" ]]; then
echo "OPENSHIFT_INSTALL_RELEASE_IMAGE is an empty string, exiting"
exit 1
fi

echo "Installing from release ${OPENSHIFT_INSTALL_RELEASE_IMAGE_OVERRIDE}"
echo "Installing from release ${OPENSHIFT_INSTALL_RELEASE_IMAGE}"
export OPENSHIFT_INSTALL_RELEASE_IMAGE_OVERRIDE="${OPENSHIFT_INSTALL_RELEASE_IMAGE}"
export SSH_PRIV_KEY_PATH=${CLUSTER_PROFILE_DIR}/ssh-privatekey
export PULL_SECRET_PATH=${CLUSTER_PROFILE_DIR}/pull-secret
export OPENSHIFT_INSTALL_INVOKER=openshift-internal-ci/${JOB_NAME}/${BUILD_ID}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,14 +2,12 @@ ref:
as: ipi-install-install
from: installer
commands: ipi-install-install-commands.sh
dependencies:
- name: "release:latest"
env: OPENSHIFT_INSTALL_RELEASE_IMAGE
resources:
requests:
cpu: 1000m
memory: 2Gi
dependencies:
- name: "release:latest"
env: OPENSHIFT_INSTALL_RELEASE_IMAGE_OVERRIDE
- name: "release:latest"
env: RELEASE_IMAGE_LATEST
documentation: |-
The IPI install step runs the OpenShift Installer in order to bring up an OpenShift cluster, using the provided cluster profile to choose a target IaaS platform. Anything that needs to be configured using manifests should generate them before this step and put them in the SHARED_DIR with the filename manifest_(manifest_name).yml so that this step can pull in the manifest in.
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,6 @@ ref:
memory: 2Gi
dependencies:
- name: "release:latest"
env: OPENSHIFT_INSTALL_RELEASE_IMAGE_OVERRIDE
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vrutkovs , why was this not defaulting to stable:initial?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

stable imagestream doesn't have a release imagetag, but I'm fine with defaulting this to release:initial

- name: "release:latest"
env: RELEASE_IMAGE_LATEST
env: OPENSHIFT_INSTALL_RELEASE_IMAGE
documentation: |-
The IPI install step runs the OpenShift Installer from stable-initial imagestream in order to bring up an OpenShift cluster, using the provided cluster profile to choose a target IaaS platform. Anything that needs to be configured using manifests should generate them before this step and put them in the SHARED_DIR with the filename manifest_(manifest_name).yml so that this step can pull in the manifest in.
Original file line number Diff line number Diff line change
Expand Up @@ -6,12 +6,13 @@ set -o pipefail

trap 'CHILDREN=$(jobs -p); if test -n "${CHILDREN}"; then kill ${CHILDREN} && wait; fi' TERM

if [[ -z "$OPENSHIFT_INSTALL_RELEASE_IMAGE_OVERRIDE" ]]; then
echo "OPENSHIFT_INSTALL_RELEASE_IMAGE_OVERRIDE is an empty string, exiting"
if [[ -z "$OPENSHIFT_INSTALL_RELEASE_IMAGE" ]]; then
echo "OPENSHIFT_INSTALL_RELEASE_IMAGE is an empty string, exiting"
exit 1
fi

echo "Installing from release ${OPENSHIFT_INSTALL_RELEASE_IMAGE_OVERRIDE}"
echo "Installing from release ${OPENSHIFT_INSTALL_RELEASE_IMAGE}"
export OPENSHIFT_INSTALL_RELEASE_IMAGE_OVERRIDE="${OPENSHIFT_INSTALL_RELEASE_IMAGE}"
export SSH_PRIV_KEY_PATH=${CLUSTER_PROFILE_DIR}/ssh-privatekey
export PULL_SECRET_PATH=${CLUSTER_PROFILE_DIR}/pull-secret
export OPENSHIFT_INSTALL_INVOKER=openshift-internal-ci/${JOB_NAME}/${BUILD_ID}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,7 @@ ref:
memory: 2Gi
dependencies:
- name: "release:latest"
env: OPENSHIFT_INSTALL_RELEASE_IMAGE_OVERRIDE
- name: "release:latest"
env: RELEASE_IMAGE_LATEST
env: OPENSHIFT_INSTALL_RELEASE_IMAGE
credentials:
- mount_path: /tmp/secret-kube
name: cluster-secrets-kubevirt
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,4 @@ set -o nounset
set -o errexit
set -o pipefail

if [[ -z "$OPENSHIFT_INSTALL_RELEASE_IMAGE_OVERRIDE" ]]; then
echo "OPENSHIFT_INSTALL_RELEASE_IMAGE_OVERRIDE is an empty string, exiting"
exit 1
fi
echo "Installing from release ${OPENSHIFT_INSTALL_RELEASE_IMAGE_OVERRIDE}"

cp "${CLUSTER_PROFILE_DIR}/csi-test-manifest.yaml" "${SHARED_DIR}"
Original file line number Diff line number Diff line change
Expand Up @@ -5,11 +5,6 @@ ref:
namespace: ocp
tag: latest
commands: ipi-install-ovirt-prepare-env-commands.sh
dependencies:
- name: "release:latest"
env: OPENSHIFT_INSTALL_RELEASE_IMAGE_OVERRIDE
- name: "release:latest"
env: RELEASE_IMAGE_LATEST
resources:
requests:
cpu: 10m
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,7 @@ ref:
memory: 2Gi
dependencies:
- name: "release:latest"
env: OPENSHIFT_INSTALL_RELEASE_IMAGE_OVERRIDE
- name: "release:latest"
env: RELEASE_IMAGE_LATEST
env: OPENSHIFT_INSTALL_RELEASE_IMAGE
documentation: >-
The vSphere IPI install step runs the OpenShift Installer in order to bring
up an OpenShift cluster. Unlike the other IPI installs, the installer image
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -91,4 +91,4 @@ LD_PRELOAD=/usr/lib64/libnss_wrapper.so gcloud compute --project "${GOOGLE_PROJE
LD_PRELOAD=/usr/lib64/libnss_wrapper.so gcloud compute --project "${GOOGLE_PROJECT_ID}" ssh \
--zone "${GOOGLE_COMPUTE_ZONE}" \
packer@"${INSTANCE_PREFIX}" \
--command "export OPENSHIFT_INSTALL_RELEASE_IMAGE_OVERRIDE=${RELEASE_IMAGE_LATEST} && timeout 360m bash -ce \"/home/packer/run-tests.sh\""
--command "export OPENSHIFT_INSTALL_RELEASE_IMAGE_OVERRIDE=${OPENSHIFT_INSTALL_RELEASE_IMAGE} && timeout 360m bash -ce \"/home/packer/run-tests.sh\""
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,9 @@ ref:
as: openshift-e2e-gcp-crc-test
from: libvirt-installer
commands: openshift-e2e-gcp-crc-test-commands.sh
dependencies:
- name: "release:latest"
env: OPENSHIFT_INSTALL_RELEASE_IMAGE
resources:
requests:
cpu: 10m
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,7 @@ fi
function upgrade() {
set -x
openshift-tests run-upgrade all \
--to-image "${OPENSHIFT_UPGRADE_RELEASE_IMAGE_OVERRIDE}" \
--to-image "${OPENSHIFT_UPGRADE_RELEASE_IMAGE}" \
--options "${TEST_UPGRADE_OPTIONS-}" \
--provider "${TEST_PROVIDER}" \
-o "${ARTIFACT_DIR}/e2e.log" \
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ ref:
suite to verify the cluster is still functional. This is typically used for testing
disruption from one suite, then confirming that the disruption did not degrade the
product.
* 'upgrade' - Perform an upgrade to the image defined by OPENSHIFT_UPGRADE_RELEASE_IMAGE_OVERRIDE.
* 'upgrade' - Perform an upgrade to the image defined by OPENSHIFT_UPGRADE_RELEASE_IMAGE.
The TEST_UPGRADE_OPTIONS flag may be optionally set. All product components
must run the default upgrade test (verify an upgrade completes) on pull requests
prior to merge.
Expand Down Expand Up @@ -45,7 +45,7 @@ ref:
details. The file must be present in ${SHARED_DIR}.
dependencies:
- name: "release:latest"
env: OPENSHIFT_UPGRADE_RELEASE_IMAGE_OVERRIDE
env: OPENSHIFT_UPGRADE_RELEASE_IMAGE
resources:
requests:
cpu: "3"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,7 @@ fi
function upgrade() {
set -x
openshift-tests run-upgrade all \
--to-image "${OPENSHIFT_UPGRADE_RELEASE_IMAGE_OVERRIDE}" \
--to-image "${OPENSHIFT_UPGRADE_RELEASE_IMAGE}" \
--options "${TEST_UPGRADE_OPTIONS-}" \
--provider "${TEST_PROVIDER}" \
-o "${ARTIFACT_DIR}/e2e.log" \
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,9 @@ ref:
from: tests
commands: openshift-e2e-test-commands.sh
timeout: 10800s
dependencies:
- name: "release:latest"
env: OPENSHIFT_UPGRADE_RELEASE_IMAGE
env:
- name: TEST_TYPE
default: "suite"
Expand All @@ -16,7 +19,7 @@ ref:
suite to verify the cluster is still functional. This is typically used for testing
disruption from one suite, then confirming that the disruption did not degrade the
product.
* 'upgrade' - Perform an upgrade to the image defined by OPENSHIFT_UPGRADE_RELEASE_IMAGE_OVERRIDE.
* 'upgrade' - Perform an upgrade to the image defined by OPENSHIFT_UPGRADE_RELEASE_IMAGE.
The TEST_UPGRADE_OPTIONS flag may be optionally set. All product components
must run the default upgrade test (verify an upgrade completes) on pull requests
prior to merge.
Expand Down Expand Up @@ -49,9 +52,6 @@ ref:
Name of the CSI driver manifest file to use. Used by the `openshift-tests`
program as TEST_CSI_DRIVER_FILES env. var., see its documentation for
details. The file must be present in ${SHARED_DIR}.
dependencies:
- name: "release:latest"
env: OPENSHIFT_UPGRADE_RELEASE_IMAGE_OVERRIDE
resources:
requests:
cpu: "3"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,7 @@ workflow:
- ref: openshift-e2e-test-capabilities-check
- chain: ipi-aws-post
dependencies:
OPENSHIFT_INSTALL_RELEASE_IMAGE_OVERRIDE: "release:initial"
OPENSHIFT_UPGRADE_RELEASE_IMAGE_OVERRIDE: "release:latest"
OPENSHIFT_INSTALL_RELEASE_IMAGE: "release:initial"
env:
TEST_TYPE: upgrade
TEST_SUITE: ""
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,8 @@ workflow:
- chain: gather-core-dump
- chain: ipi-aws-post
dependencies:
OPENSHIFT_INSTALL_RELEASE_IMAGE_OVERRIDE: "release:initial"
OPENSHIFT_UPGRADE_RELEASE_IMAGE_OVERRIDE: "release:latest"
OPENSHIFT_INSTALL_RELEASE_IMAGE: "release:initial"
OPENSHIFT_UPGRADE_RELEASE_IMAGE: "release:latest"
env:
TEST_TYPE: upgrade
TEST_SUITE: ""
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,7 @@ workflow:
post:
- chain: ipi-azure-post
dependencies:
OPENSHIFT_INSTALL_RELEASE_IMAGE_OVERRIDE: "release:initial"
OPENSHIFT_UPGRADE_RELEASE_IMAGE_OVERRIDE: "release:latest"
OPENSHIFT_INSTALL_RELEASE_IMAGE: "release:initial"
env:
TEST_TYPE: upgrade
TEST_SUITE: ""
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,8 @@ workflow:
- chain: gather-core-dump
- chain: ipi-azure-post
dependencies:
OPENSHIFT_INSTALL_RELEASE_IMAGE_OVERRIDE: "release:initial"
OPENSHIFT_UPGRADE_RELEASE_IMAGE_OVERRIDE: "release:latest"
OPENSHIFT_INSTALL_RELEASE_IMAGE: "release:initial"
OPENSHIFT_UPGRADE_RELEASE_IMAGE: "release:latest"
env:
TEST_TYPE: upgrade
TEST_SUITE: ""
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,8 @@ workflow:
post:
- chain: ipi-gcp-post
dependencies:
OPENSHIFT_INSTALL_RELEASE_IMAGE_OVERRIDE: "release:initial"
OPENSHIFT_UPGRADE_RELEASE_IMAGE_OVERRIDE: "release:latest"
OPENSHIFT_INSTALL_RELEASE_IMAGE: "release:initial"
OPENSHIFT_UPGRADE_RELEASE_IMAGE: "release:latest"
env:
TEST_TYPE: upgrade
TEST_SUITE: ""
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,8 @@ workflow:
- chain: gather-network
- chain: ipi-gcp-post
dependencies:
OPENSHIFT_INSTALL_RELEASE_IMAGE_OVERRIDE: "release:initial"
OPENSHIFT_UPGRADE_RELEASE_IMAGE_OVERRIDE: "release:latest"
OPENSHIFT_INSTALL_RELEASE_IMAGE: "release:initial"
OPENSHIFT_UPGRADE_RELEASE_IMAGE: "release:latest"
env:
TEST_TYPE: upgrade
TEST_SUITE: ""
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,8 @@ workflow:
post:
- chain: ipi-openstack-post
dependencies:
OPENSHIFT_INSTALL_RELEASE_IMAGE_OVERRIDE: "release:initial"
OPENSHIFT_UPGRADE_RELEASE_IMAGE_OVERRIDE: "release:latest"
OPENSHIFT_INSTALL_RELEASE_IMAGE: "release:initial"
OPENSHIFT_UPGRADE_RELEASE_IMAGE: "release:latest"
env:
TEST_TYPE: upgrade
TEST_SUITE: ""
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,8 @@ workflow:
TEST_TYPE: upgrade
TEST_UPGRADE_OPTIONS: ""
dependencies:
OPENSHIFT_INSTALL_RELEASE_IMAGE_OVERRIDE: "release:initial"
OPENSHIFT_UPGRADE_RELEASE_IMAGE_OVERRIDE: "release:latest"
OPENSHIFT_INSTALL_RELEASE_IMAGE: "release:initial"
OPENSHIFT_UPGRADE_RELEASE_IMAGE: "release:latest"
documentation: |-
The Openshift E2E oVirt upgrade workflow installs OpenShift cluster on top of oVirt
and executes an upgrade to the next available version.
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,8 @@ workflow:
TEST_TYPE: upgrade
TEST_UPGRADE_OPTIONS: ""
dependencies:
OPENSHIFT_INSTALL_RELEASE_IMAGE_OVERRIDE: "release:initial"
OPENSHIFT_UPGRADE_RELEASE_IMAGE_OVERRIDE: "release:latest"
OPENSHIFT_INSTALL_RELEASE_IMAGE: "release:initial"
OPENSHIFT_UPGRADE_RELEASE_IMAGE: "release:latest"
documentation: |-
The Openshift E2E oVirt upgrade without csi workflow installs OpenShift cluster on top of oVirt
from releases that didn't contain the oVirt csi driver, therfor patch the image registry.
Expand Down
Loading