Skip to content

openshift-installer-presubmits: Add go-fmt #1283

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Aug 25, 2018
Merged

openshift-installer-presubmits: Add go-fmt #1283

openshift-merge-robot merged 1 commit into from
Aug 25, 2018

Conversation

@wking
Copy link
Member

@wking wking commented Aug 24, 2018 •
edited
Loading

We've had some gofmt issues sneak in recently. We want to catch that sort of thing in CI, instead of finding out about it later.

openshift/installer#173 needs to land before we merge this.

/hold

@openshift-ci-robot openshift-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 24, 2018
@wking
Copy link
Member Author

wking commented Aug 24, 2018

/hold

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 24, 2018
@wking
openshift-installer-presubmits: Add go-fmt
b3d7d65 
We've had some gofmt issues sneak in recently [1].  We want to catch
that sort of thing in CI, instead of finding out about it later.  This
commit uses the script from openshift/installer@94a2a8ca (hack/go-fmt:
Make it easy to auto-format Go, 2018-08-24, openshift/installer#173)
to automate that check.

[1]: openshift/installer@8f415b9#commitcomment-30284820
@wking wking force-pushed the installer-go-fmt branch from 5303aef to b3d7d65 Compare August 24, 2018 21:03
@wking
Copy link
Member Author

wking commented Aug 25, 2018

openshift/installer#173 landed.

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 25, 2018
@wking
Copy link
Member Author

wking commented Aug 25, 2018

All green. CC @yifan-gu, @eparis.

@eparis
Copy link
Member

eparis commented Aug 25, 2018

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 25, 2018
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Aug 25, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: eparis, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit bf508c3 into openshift:master Aug 25, 2018
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Aug 25, 2018

@wking: Updated the job-config configmap using the following files:

  • key openshift-installer-presubmits.yaml using file ci-operator/jobs/openshift/installer/openshift-installer-presubmits.yaml
Details

In response to this:

We've had some gofmt issues sneak in recently. We want to catch that sort of thing in CI, instead of finding out about it later.

openshift/installer#173 needs to land before we merge this.

/hold

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@eparis eparis mentioned this pull request Aug 25, 2018
Merged
@wking wking deleted the installer-go-fmt branch August 27, 2018 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@crawford crawford Awaiting requested review from crawford

@smarterclayton smarterclayton Awaiting requested review from smarterclayton

Assignees

@eparis eparis

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@wking @eparis @openshift-ci-robot @openshift-merge-robot