Skip to content

Change e2e test context name #1276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
openshift-merge-robot merged 1 commit into from
Aug 24, 2018
Merged

Change e2e test context name #1276

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...erator/jobs/openshift/machine-api-operator/openshift-machine-api-operator-presubmits.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,6 @@ presubmits:
agent: jenkins
labels:
master: ci.openshift.redhat.com
context: ci/openshift-jenkins
context: ci/jenkins/e2e
Copy link
Member

@ingvagabund ingvagabund Aug 24, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's do ci/jenkins/mao-e2e

Copy link
Contributor Author

@paulfantom paulfantom Aug 24, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that name will only show up in mao repo, so why add mao?

Copy link
Member

@ingvagabund ingvagabund Aug 24, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Later one we can have more e2e tests. Let's make clear it's for the mao.

Copy link
Contributor Author

@paulfantom paulfantom Aug 24, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't get it. Later we might have more e2e tests in mao repository which won't include mao? Strange.

Copy link
Member

@ingvagabund ingvagabund Aug 24, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's do it later then

rerun_command: "/test e2e"
trigger: "((?m)^/test( all| e2e),?(\\s+|$))"