Skip to content

cluster-api-provider-azure: add workflow-based e2e-upgrade test #12204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 5 commits into from
Oct 12, 2020
Merged

cluster-api-provider-azure: add workflow-based e2e-upgrade test #12204

openshift-merge-robot merged 5 commits into from
Oct 12, 2020

Conversation

@vrutkovs
Copy link
Contributor

@vrutkovs vrutkovs commented Sep 24, 2020 •
edited
Loading

Create necessary steps to install cluster from stable-initial:installer on Azure and upgrade it using workflow approach.

@vrutkovs vrutkovs force-pushed the workflow-azure-upgrade branch from f9fa013 to 26d82b3 Compare September 24, 2020 09:50
@vrutkovs
Copy link
Contributor Author

vrutkovs commented Sep 24, 2020

SDN crashlooping on upgrade
/retest

@vrutkovs
Copy link
Contributor Author

vrutkovs commented Sep 29, 2020

/retest

michaelgugino
michaelgugino approved these changes Sep 30, 2020
View reviewed changes
Copy link
Contributor

@michaelgugino michaelgugino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 30, 2020
@vrutkovs vrutkovs force-pushed the workflow-azure-upgrade branch from 26d82b3 to e22bea0 Compare October 5, 2020 08:34
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Oct 5, 2020
@vrutkovs
Copy link
Contributor Author

vrutkovs commented Oct 5, 2020

Workers didn't come up on initial setup

/retest

1 similar comment
@vrutkovs
Copy link
Contributor Author

vrutkovs commented Oct 5, 2020

Workers didn't come up on initial setup

/retest

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Oct 5, 2020

@vrutkovs: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/rehearse/openshift/cluster-api-provider-azure/master/e2e-upgrade e22bea0e0fdcf7ba1d969b4b5a7e5d44d3f6c3f5 link /test pj-rehearse
ci/prow/pj-rehearse e22bea0e0fdcf7ba1d969b4b5a7e5d44d3f6c3f5 link /test pj-rehearse

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@vrutkovs vrutkovs mentioned this pull request Oct 9, 2020
Merged
tnozicka
tnozicka reviewed Oct 12, 2020
View reviewed changes
...erator/step-registry/openshift/upgrade/azure/loki/openshift-upgrade-azure-loki-workflow.yaml Outdated
Copy link
Contributor

@tnozicka tnozicka Oct 12, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as latest is older then this PR should it be from latest to initial?

Copy link
Contributor Author

@vrutkovs vrutkovs Oct 12, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Names are a bit confusing, but OPENSHIFT_INSTALL_RELEASE_IMAGE_OVERRIDE is used in ipi-install-install (so its initial) and OPENSHIFT_UPGRADE_RELEASE_IMAGE_OVERRIDE used in openshift-e2e-test doing openshift-tests run-upgrade --to-image=${OPENSHIFT_UPGRADE_RELEASE_IMAGE_OVERRIDE}

@vrutkovs vrutkovs force-pushed the workflow-azure-upgrade branch from e22bea0 to d049e18 Compare October 12, 2020 11:15
@ingvagabund
Copy link
Member

ingvagabund commented Oct 12, 2020

/approve

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 12, 2020
@ingvagabund
Copy link
Member

ingvagabund commented Oct 12, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 12, 2020
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Oct 12, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ingvagabund, michaelgugino, vrutkovs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 7d8ce91 into openshift:master Oct 12, 2020
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Oct 12, 2020

@vrutkovs: Updated the following 5 configmaps:

  • job-config-master configmap in namespace ci at cluster api.ci using the following files:
    • key openshift-cluster-api-provider-azure-master-presubmits.yaml using file ci-operator/jobs/openshift/cluster-api-provider-azure/openshift-cluster-api-provider-azure-master-presubmits.yaml
  • job-config-master configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-cluster-api-provider-azure-master-presubmits.yaml using file ci-operator/jobs/openshift/cluster-api-provider-azure/openshift-cluster-api-provider-azure-master-presubmits.yaml
  • step-registry configmap in namespace ci at cluster api.ci using the following files:
    • key OWNERS using file ci-operator/step-registry/ipi/azure/pre/stableinitial/OWNERS
    • key ipi-azure-pre-stableinitial-chain.metadata.json using file ci-operator/step-registry/ipi/azure/pre/stableinitial/ipi-azure-pre-stableinitial-chain.metadata.json
    • key ipi-azure-pre-stableinitial-chain.yaml using file ci-operator/step-registry/ipi/azure/pre/stableinitial/ipi-azure-pre-stableinitial-chain.yaml
    • key OWNERS using file ci-operator/step-registry/openshift/upgrade/azure/OWNERS
    • key OWNERS using file ci-operator/step-registry/openshift/upgrade/azure/loki/OWNERS
    • key openshift-upgrade-azure-loki-workflow.metadata.json using file ci-operator/step-registry/openshift/upgrade/azure/loki/openshift-upgrade-azure-loki-workflow.metadata.json
    • key openshift-upgrade-azure-loki-workflow.yaml using file ci-operator/step-registry/openshift/upgrade/azure/loki/openshift-upgrade-azure-loki-workflow.yaml
    • key openshift-upgrade-azure-workflow.metadata.json using file ci-operator/step-registry/openshift/upgrade/azure/openshift-upgrade-azure-workflow.metadata.json
    • key openshift-upgrade-azure-workflow.yaml using file ci-operator/step-registry/openshift/upgrade/azure/openshift-upgrade-azure-workflow.yaml
  • step-registry configmap in namespace ci at cluster app.ci using the following files:
    • key OWNERS using file ci-operator/step-registry/ipi/azure/pre/stableinitial/OWNERS
    • key ipi-azure-pre-stableinitial-chain.metadata.json using file ci-operator/step-registry/ipi/azure/pre/stableinitial/ipi-azure-pre-stableinitial-chain.metadata.json
    • key ipi-azure-pre-stableinitial-chain.yaml using file ci-operator/step-registry/ipi/azure/pre/stableinitial/ipi-azure-pre-stableinitial-chain.yaml
    • key OWNERS using file ci-operator/step-registry/openshift/upgrade/azure/OWNERS
    • key OWNERS using file ci-operator/step-registry/openshift/upgrade/azure/loki/OWNERS
    • key openshift-upgrade-azure-loki-workflow.metadata.json using file ci-operator/step-registry/openshift/upgrade/azure/loki/openshift-upgrade-azure-loki-workflow.metadata.json
    • key openshift-upgrade-azure-loki-workflow.yaml using file ci-operator/step-registry/openshift/upgrade/azure/loki/openshift-upgrade-azure-loki-workflow.yaml
    • key openshift-upgrade-azure-workflow.metadata.json using file ci-operator/step-registry/openshift/upgrade/azure/openshift-upgrade-azure-workflow.metadata.json
    • key openshift-upgrade-azure-workflow.yaml using file ci-operator/step-registry/openshift/upgrade/azure/openshift-upgrade-azure-workflow.yaml
  • ci-operator-master-configs configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-cluster-api-provider-azure-master.yaml using file ci-operator/config/openshift/cluster-api-provider-azure/openshift-cluster-api-provider-azure-master.yaml
Details

In response to this:

Create necessary steps to install cluster from stable-initial:installer on Azure and upgrade it using workflow approach.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@paulfantom paulfantom Awaiting requested review from paulfantom

2 more reviewers

@tnozicka tnozicka tnozicka left review comments

@michaelgugino michaelgugino michaelgugino approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@michaelgugino michaelgugino

@ingvagabund ingvagabund

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@vrutkovs @openshift-ci-robot @ingvagabund @michaelgugino @tnozicka @openshift-merge-robot