Skip to content

Conversation

@wking
Copy link
Member

@wking wking commented Aug 17, 2018

@openshift-ci-robot openshift-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 17, 2018
@wking wking force-pushed the installer-ssh-key branch from 73d24e8 to 0b24ab0 Compare August 17, 2018 17:05
@smarterclayton
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 17, 2018
@wking wking changed the title wip: cluster/test-deploy/aws/openshift: Move sshKey to the admin block cluster/test-deploy/aws/openshift: Move sshKey to the admin block Aug 17, 2018
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 17, 2018
@openshift-merge-robot openshift-merge-robot merged commit 2e703b9 into openshift:master Aug 17, 2018
@openshift-ci-robot
Copy link
Contributor

@wking: Updated the prow-job-cluster-launch-installer-e2e configmap using the following files:

  • key cluster-launch-installer-e2e.yaml using file ci-operator/templates/cluster-launch-installer-e2e.yaml
Details

In response to this:

Catching up with openshift/installer@37f623c5 (openshift/installer#127).

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@wking
Copy link
Member Author

wking commented Aug 17, 2018

Maybe this broke the YAML format? From here:

Invoking installer ...
time="2018-08-17T17:45:47Z" level=fatal msg="failed to get configuration from file \"inputs.yaml\": inputs.yaml is not a valid config file: yaml: line 75: found unexpected ':'" 

but there is no uploaded inputs.yaml to look at.

@wking wking deleted the installer-ssh-key branch August 17, 2018 17:53
@wking
Copy link
Member Author

wking commented Aug 17, 2018

The template around that line looks fine:

$ grep -n ^ cluster/test-deploy/aws/openshift.yaml | grep -4 '^75:'
71:    # Example: `["subnet-111111", "subnet-222222", "subnet-333333"]`
72:    # workerSubnetIDs:
73:
74:  # (optional) Extra AWS tags to be applied to created resources.
75:  #
76:  # Example: `{ "key" = "value", "foo" = "bar" }`
77:  extraTags: {"expirationDate" = "${EXPIRATION_DATE}"}
78:
79:  # (optional) Name of IAM role to use to access AWS in order to deploy the Tectonic Cluster.

@wking
Copy link
Member Author

wking commented Aug 17, 2018

Ah, maybe this is an issue with #1103, but we're only seeing it now because we only just pushed the recent template into production? I'd uncommented extraTags there.

@wking
Copy link
Member Author

wking commented Aug 17, 2018

Ah, maybe this is an issue with #1103...

Yup. I've filed #1209 with a fix.

derekhiggins pushed a commit to derekhiggins/release that referenced this pull request Oct 24, 2023
In theory it should be possible to load the public key from secrets, but
I don't have an environment to figure it out yet.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants