Skip to content

Conversation

@marun
Copy link
Contributor

@marun marun commented Sep 16, 2020

Ready to merge now that openshift/kubernetes#348 has merged.

They are no longer necessary now that the repo has been updated to reference the correct images directly.

@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 16, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: marun
To complete the pull request process, please assign knobunc
You can assign the PR to them by writing /assign @knobunc in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@marun marun changed the title WIP Remove golang 1.15 overrides for openshift/kubernetes Remove golang 1.15 overrides for openshift/kubernetes Sep 18, 2020
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 18, 2020
They are no longer necessary now that the repo has been updated to
reference the correct images directly.
@marun marun requested review from mfojtik, sttts and tnozicka and removed request for sjenning and timlnx September 18, 2020 17:30
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Sep 18, 2020

@marun: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/pj-rehearse 1435e3411d0a3278113a2c93a77fd21fe2253874 link /test pj-rehearse
ci/rehearse/openshift/kubernetes/master/verify-commits 4949bf8 link /test pj-rehearse
ci/rehearse/openshift/kubernetes/master/k8s-e2e-gcp-serial 4949bf8 link /test pj-rehearse
ci/rehearse/openshift/kubernetes/master/e2e-vsphere 4949bf8 link /test pj-rehearse

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@marun
Copy link
Contributor Author

marun commented Sep 18, 2020

I think this needs to wait until rehearsals are working reliably for openshift/kubernetes.

@marun marun closed this Sep 18, 2020
@marun marun deleted the remove-ok-master-overrides branch September 18, 2020 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants