Skip to content

Don't run the E2E tests on installer documentation #1191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
openshift-merge-robot merged 1 commit into from
Aug 15, 2018
Merged

Don't run the E2E tests on installer documentation #1191

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion ci-operator/jobs/openshift/installer/openshift-installer-presubmits.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,9 @@ presubmits:
- master
- dockerless-build-temporary
rerun_command: "/test e2e-aws"
always_run: true
# The abomination below is equivilent to `^((?!Documentation).)*$`. Since
# Go doesn't support negative lookaheads, we are stuck with the following.
run_if_changed: "^([^D]|D(D|oD|ocD|ocuD|ocum(D|e(D|n(D|t(D|aD|atD|atiD|atioD)))))*([^Do]|o[^Dc]|oc[^Du]|ocu[^Dm]|ocum([^De]|e([^Dn]|n([^Dt]|t([^Da]|a[^Dt]|at[^Di]|ati[^Do]|atio[^Dn]))))))*(D(D|oD|ocD|ocuD|ocum(D|e(D|n(D|t(D|aD|atD|atiD|atioD)))))*(o|oc|ocu|ocum(e(n(t(a|at|ati|atio)?)?)?)?)?)?$"
Copy link
Contributor

@stevekuznetsov stevekuznetsov Aug 20, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How often does your repository change top-level directories? Seems like you could have called those out in a much more simple manner.

Copy link
Member

@wking wking Aug 20, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How often does your repository change top-level directories?

We have a top-level change in flight now with openshift/installer#120 ;). But we'll need CI changes in other places to adapt to that anyway, so I wouldn't mind switching to a whitelist approach here too. I'm also fine with the blacklist approach.

trigger: "((?m)^/test( all| e2e-aws),?(\\s+|$))"
decorate: true
skip_cloning: true
Expand Down