Skip to content

Separating out proxy deprovision from gather to ensure tear down can occur #11556

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Sep 2, 2020
Merged

Separating out proxy deprovision from gather to ensure tear down can occur #11556

openshift-merge-robot merged 1 commit into from
Sep 2, 2020

Conversation

@ewolinetz
Copy link
Contributor

@ewolinetz ewolinetz commented Sep 2, 2020

Addresses current issue where proxy instances are being leaked due to failing to gather logs due to the proxy service not responding to ssh.

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 2, 2020
wking
wking reviewed Sep 2, 2020
View reviewed changes
@ewolinetz ewolinetz force-pushed the logging_cleanup_trap branch from 4a4800f to a5b83aa Compare September 2, 2020 20:15
wking
wking reviewed Sep 2, 2020
View reviewed changes
ci-operator/step-registry/ipi/deprovision/proxy/ipi-deprovision-proxy-ref.yaml Outdated
Copy link
Member

@wking wking Sep 2, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, we must be pinning this because of the aws client? Looks like yes: openshift/installer#3292. Can we call that out in the commit message? And maybe drop the 4.5-pinning for gather-proxy-ref.yaml now that it no longer uses aws?

@ewolinetz ewolinetz force-pushed the logging_cleanup_trap branch from a5b83aa to 971b967 Compare September 2, 2020 20:22
@openshift-ci-robot openshift-ci-robot removed the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 2, 2020
@ewolinetz
Separating out proxy deprovision from gather to ensure tear down can …
f5a6259 
…occur

We are pinning the deprovision image due to openshift/installer#3292
Since we no longer deprovision as part of gather-proxy, we can remove the pinning of that image.
@ewolinetz ewolinetz force-pushed the logging_cleanup_trap branch from 971b967 to f5a6259 Compare September 2, 2020 20:25
@wking
Copy link
Member

wking commented Sep 2, 2020

/lgtm

Needs someone from DPTP to sign off because adding a new step and touching OWNERS now touches the metadata JSON file.

/assign @alvaroaleman

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 2, 2020
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Sep 2, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alvaroaleman, ewolinetz, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 2, 2020
@openshift-merge-robot openshift-merge-robot merged commit 7807e0f into openshift:master Sep 2, 2020
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Sep 2, 2020

@ewolinetz: Updated the following 2 configmaps:

  • step-registry configmap in namespace ci at cluster api.ci using the following files:
    • key gather-proxy-commands.sh using file ci-operator/step-registry/gather/proxy/gather-proxy-commands.sh
    • key gather-proxy-ref.yaml using file ci-operator/step-registry/gather/proxy/gather-proxy-ref.yaml
    • key ipi-aws-post-proxy-chain.yaml using file ci-operator/step-registry/ipi/aws/post/proxy/ipi-aws-post-proxy-chain.yaml
    • key OWNERS using file ci-operator/step-registry/ipi/deprovision/proxy/OWNERS
    • key ipi-deprovision-proxy-commands.sh using file ci-operator/step-registry/ipi/deprovision/proxy/ipi-deprovision-proxy-commands.sh
    • key ipi-deprovision-proxy-ref.yaml using file ci-operator/step-registry/ipi/deprovision/proxy/ipi-deprovision-proxy-ref.yaml
    • key metadata.json using file ci-operator/step-registry/metadata.json
  • step-registry configmap in namespace ci at cluster app.ci using the following files:
    • key gather-proxy-commands.sh using file ci-operator/step-registry/gather/proxy/gather-proxy-commands.sh
    • key gather-proxy-ref.yaml using file ci-operator/step-registry/gather/proxy/gather-proxy-ref.yaml
    • key ipi-aws-post-proxy-chain.yaml using file ci-operator/step-registry/ipi/aws/post/proxy/ipi-aws-post-proxy-chain.yaml
    • key OWNERS using file ci-operator/step-registry/ipi/deprovision/proxy/OWNERS
    • key ipi-deprovision-proxy-commands.sh using file ci-operator/step-registry/ipi/deprovision/proxy/ipi-deprovision-proxy-commands.sh
    • key ipi-deprovision-proxy-ref.yaml using file ci-operator/step-registry/ipi/deprovision/proxy/ipi-deprovision-proxy-ref.yaml
    • key metadata.json using file ci-operator/step-registry/metadata.json
Details

In response to this:

Addresses current issue where proxy instances are being leaked due to failing to gather logs due to the proxy service not responding to ssh.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stevekuznetsov stevekuznetsov Awaiting requested review from stevekuznetsov

2 more reviewers

@wking wking wking left review comments

@alvaroaleman alvaroaleman alvaroaleman approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@wking wking

@alvaroaleman alvaroaleman

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@ewolinetz @wking @openshift-ci-robot @alvaroaleman @openshift-merge-robot