Skip to content

Conversation

@rabugopsl
Copy link
Contributor

Added go-vet prow job description. Use comment /test go-vet to run the go-vet task.
Additional folders may by added as command arguments after ./installer/....

This change relies on PR Go Vet Shell Script

@openshift-ci-robot openshift-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Aug 6, 2018
@openshift-ci-robot
Copy link
Contributor

Hi @rabugopsl. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Aug 6, 2018
@rabugopsl rabugopsl force-pushed the CORS-747_Move_go_vet_to_Prow branch from 4ca6fb0 to 4178bf0 Compare August 8, 2018 13:36
@openshift-bot openshift-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 8, 2018
@openshift-ci-robot openshift-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 8, 2018
@openshift-bot openshift-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 8, 2018
@openshift-ci-robot openshift-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 8, 2018
@rabugopsl rabugopsl force-pushed the CORS-747_Move_go_vet_to_Prow branch from d0a1ac7 to b10e21c Compare August 8, 2018 13:42
@openshift-bot openshift-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 8, 2018
@openshift-ci-robot openshift-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 8, 2018
@openshift-bot openshift-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 8, 2018
@openshift-ci-robot openshift-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 8, 2018
@rabugopsl rabugopsl force-pushed the CORS-747_Move_go_vet_to_Prow branch from d7d1b67 to af4f6ed Compare August 8, 2018 14:28
@openshift-ci-robot openshift-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 8, 2018
@openshift-bot openshift-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 8, 2018
@openshift-ci-robot openshift-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 8, 2018
@openshift-bot openshift-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 8, 2018
# This is the 1st commit message:

# This is a combination of 7 commits.
# This is the 1st commit message:

# This is a combination of 7 commits.
# This is the 1st commit message:

Added go-vet prow job description

# This is the commit message #2:

deprecate 3.9 prow

# This is the commit message #3:

remove 3.9 acs-engine builds

# This is the commit message openshift#4:

Remove stale build

# This is the commit message #5:

Remove redundant azure-misc plugin config

# This is the commit message openshift#6:

Gate openshift-azure on an extra needs-signoff label

# This is the commit message openshift#7:

Automate adding/removing needs-signoff label

# This is the commit message #2:

deprecate 3.9 prow

# This is the commit message #3:

remove 3.9 acs-engine builds

# This is the commit message openshift#4:

Remove stale build

# This is the commit message #5:

Remove redundant azure-misc plugin config

# This is the commit message openshift#6:

Gate openshift-azure on an extra needs-signoff label

# This is the commit message openshift#7:

Automate adding/removing needs-signoff label

# This is the commit message #2:

deprecate 3.9 prow

# This is the commit message #3:

remove 3.9 acs-engine builds

# This is the commit message openshift#4:

Remove stale build

# This is the commit message #5:

Remove redundant azure-misc plugin config

# This is the commit message openshift#6:

Gate openshift-azure on an extra needs-signoff label

# This is the commit message openshift#7:

Automate adding/removing needs-signoff label
@rabugopsl rabugopsl force-pushed the CORS-747_Move_go_vet_to_Prow branch from ceca43a to 3689506 Compare August 8, 2018 14:44
@openshift-ci-robot openshift-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 8, 2018
@openshift-bot
Copy link
Contributor

@rabugopsl: PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-bot openshift-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 8, 2018
@rabugopsl rabugopsl closed this Aug 8, 2018
@rabugopsl rabugopsl deleted the CORS-747_Move_go_vet_to_Prow branch August 8, 2018 14:45
derekhiggins pushed a commit to derekhiggins/release that referenced this pull request Oct 24, 2023
For some reason the virsh --remove-all-storage isn't actually removing
the storage, this may be because we moved to a non-default pool?

This can quickly use up space as each leaked directory is about 2.2G
so lets clean it up until we can find a more robust way to handle
this in the installer.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants