Skip to content

Conversation

@marun
Copy link
Contributor

@marun marun commented Aug 31, 2020

No description provided.

@marun
Copy link
Contributor Author

marun commented Aug 31, 2020

Required by 1.19 bump: openshift/apiserver-library-go#34

@marun
Copy link
Contributor Author

marun commented Sep 1, 2020

Ignore rehearsal failure, openshift/apiserver-library-go#34 has to merge before it would pass, but it can't merge until this PR does.

@sttts sttts changed the title Update apiserver-library-go master to use golang 1.13 Update apiserver-library-go master to use golang 1.14 Sep 1, 2020
@sttts
Copy link
Contributor

sttts commented Sep 1, 2020

Why not 4.6 and 4.7 ?

@soltysh
Copy link

soltysh commented Sep 1, 2020

Why not 4.6 and 4.7 ?

IIRC, these are synced from master, since master is effectively 4.6.

Copy link

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 1, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: marun, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 1, 2020
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 01b26d8 into openshift:master Sep 1, 2020
@openshift-ci-robot
Copy link
Contributor

@marun: Updated the ci-operator-master-configs configmap in namespace ci at cluster app.ci using the following files:

  • key openshift-apiserver-library-go-master.yaml using file ci-operator/config/openshift/apiserver-library-go/openshift-apiserver-library-go-master.yaml
Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@marun marun deleted the alg-golang-1.13 branch February 1, 2021 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants