Revert "use hours in sinker config" #1121
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 33cf8d5. Signed-off-by: Steve Kuznetsov <[email protected]>
Contributor
Author
|
@smarterclayton should drop our footprint |
openshift-ci-robot
added
the
size/XS
Contributor
|
@stevekuznetsov: Updated the
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
derekhiggins
pushed a commit
to derekhiggins/release
that referenced
this pull request
Oct 24, 2023
* Line-buffer log output Because there is a pipe (from awk to tee) in our log output pipeline, output is now buffered, which is bad for watching in real time. awk doesn't provide an option to line-buffer the output even though it is not going to a terminal, so explicitly call fflush() after each line. Fixes openshift#1121 * Only add timestamps in logfile, not on console The make realclean script includes calls to podman that prompt on the console. Since the prompts don't end with a newline, they are not printed immediately as stderr is redirected along with stdout. Move the awk invocation that adds timestamps to the log file path only (after the tee), so that prompts are displayed on the console immediately.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 33cf8d5.
Signed-off-by: Steve Kuznetsov [email protected]