-
Notifications
You must be signed in to change notification settings - Fork 2.1k
fips_check: Don't hardcode number of nodes #10653
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fips_check: Don't hardcode number of nodes #10653
Conversation
This is to unblock the fips job for now. We have to follow up with checks that make sure that the expected number of nodes are up before running checks and tests. Signed-off-by: Mrunal Patel <[email protected]>
2560f90 to
9d32eee
Compare
|
/retest |
9d32eee to
d6fe111
Compare
|
@mrunalp: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mrunalp, smarterclayton The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@mrunalp: Updated the following 4 configmaps:
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This is to unblock the fips job for now.
We have to follow up with checks that make
sure that the expected number of nodes
are up before running checks and tests.
Signed-off-by: Mrunal Patel [email protected]