e2e-metal: Switch to live-initramfs and live-kernel if set in rhcos.json #10121
Conversation
openshift-ci-robot
added
the
approved
|
/hold |
openshift-ci-robot
added
the
do-not-merge/hold
There was a problem hiding this comment.
I believe rhcos.json is to be deprecated. Should use arch specific file such as rhcos-amd64.json
There was a problem hiding this comment.
Ultimately it will be replaced with openshift/enhancements#201
Using rhcos-amd64.json makes sense to me, though it seems orthogonal to this PR and could be done as a followup.
There was a problem hiding this comment.
Since this change (https://issues.redhat.com/browse/GRPA-1634) has already landed in the latest release, we might need to add another parameter here.
for e.g.
PXE_ROOTFS_URL="$(jq -r '.baseURI + .images["rootfs"].path' /var/lib/openshift-install/rhcos.json)"
sdodson
force-pushed
the
liveimage-step-2
branch
2 times, most recently
from
ebe139d to
be931ea
Compare
|
The changes look sane to me. |
|
@sohankunkerkar: changing LGTM is restricted to collaborators DetailsIn response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/test pj-rehearse |
1 similar comment
|
/test pj-rehearse |
|
/retest |
|
latest status on this was that it installed fcos-okd rather than rhcos for some reason, discussing on slack |
Should be fixed in 46.82.202008080040-0. |
|
/retest |
|
CI is still using an older image |
|
I've added a test commit, to use the build that Ben mentioned. Once we confirm that someone should open a PR to bump the boot image in the installer repo, rhcos folks should be familiar with that procedure. |
Sure, let me create a PR to bump the boot image |
sdodson
force-pushed
the
liveimage-step-2
branch
from
8c1d820 to
ccb426b
Compare
sdodson
force-pushed
the
liveimage-step-2
branch
from
ccb426b to
8e1294b
Compare
sdodson
force-pushed
the
liveimage-step-2
branch
from
8e1294b to
5c0883a
Compare
|
The rehearsal made it past bootstrapping. I think this is ready to go now. We'll know quickly if we break older releases via the release controller. |
|
It ultimately failed but it's a known issue with all UPI installations related to CSR approval. |
|
/lgtm |
|
@sohankunkerkar: changing LGTM is restricted to collaborators DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sdodson, sohankunkerkar The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
/hold cancel |
openshift-ci-robot
removed
the
do-not-merge/hold
|
@sdodson: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
@sdodson: Updated the following 4 configmaps:
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
7 participants
Requires #9960 then openshift/installer#3865