ci-operator/step-registry/ipi/conf/*/sharednetwork: Quote CONFIG #10105
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To make ShellCheck happy, addressing:
$ sudo podman run --rm --volume "${PWD}:/workdir:ro,z" --workdir /workdir registry.svc.ci.openshift.org/ci/shellcheck sh -c 'find ci-operator/step-registry/ipi -name "*.sh" -print0 | xargs -0 -n1 shellcheck'
In ci-operator/step-registry/ipi/conf/aws/sharednetwork/ipi-conf-aws-sharednetwork-commands.sh line 13:
aws_region=$(/tmp/yq r ${CONFIG} 'platform.aws.region')
^-------^ SC2086: Double quote to prevent globbing and word splitting.
Did you mean:
aws_region=$(/tmp/yq r "${CONFIG}" 'platform.aws.region')
For more information:
https://www.shellcheck.net/wiki/SC2086 -- Double quote to prevent globbing ...
In ci-operator/step-registry/ipi/conf/azure/sharednetwork/ipi-conf-azure-sharednetwork-commands.sh line 13:
azure_region=$(/tmp/yq r ${CONFIG} 'platform.azure.region')
^-------^ SC2086: Double quote to prevent globbing and word splitting.
Did you mean:
azure_region=$(/tmp/yq r "${CONFIG}" 'platform.azure.region')
For more information:
https://www.shellcheck.net/wiki/SC2086 -- Double quote to prevent globbing ...
openshift-ci-robot
added
the
approved
| PATCH="${SHARED_DIR}/install-config-sharednetwork.yaml.patch" | ||
|
|
||
| aws_region=$(/tmp/yq r ${CONFIG} 'platform.aws.region') | ||
| aws_region=$(/tmp/yq r "${CONFIG}" 'platform.aws.region') |
Contributor
There was a problem hiding this comment.
https://github.com/openshift/release/pull/10105/files#diff-27605b7c8f643fa9b7d430f76604ebe6R10 is already quotes CONFIG, why do we need to quote again ??
this shellcheck warnings is just too noisy imo
Member
Author
There was a problem hiding this comment.
The earlier quotes affect word splitting on that line. These quotes affect splitting on this line. For example:
$ A='b c'
$ B="${A}"
$ python -c 'import sys; print(sys.argv)' ${B}
['-c', 'b', 'c']
$ python -c 'import sys; print(sys.argv)' "${B}"
['-c', 'b c']
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abhinavdahiya, wking The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Contributor
|
@wking: Updated the following 2 configmaps:
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To make ShellCheck happy, addressing:
More groundwork for #9772.