Revert "Revert "ci-operator/step-registry/manifests: Factor day-2 manifests into own step"" #10053
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: wking The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
They do: Not exactly sure what is the problem though :) |
|
It was my mistake to approve your previous PR. I blindly trusted the /hold |
openshift-ci-robot
added
the
do-not-merge/hold
|
Ah, possibly a workflow that includes the step twice (e.g. via two chains or something). ....And that's what you say in the previous comment 🤦 Will fix... |
wking
force-pushed
the
revert-10039-revert-8953-separate-manifests-step
branch
2 times, most recently
from
4f2aa7e to
5705936
Compare
…ifests into own step"" Dropping explicit manifests ref from openshift-e2e-aws-loki and openshift-e2e-gcp-loki, because ipi-aws-pre and ipi-gcp-pre already contain the manifests ref.
wking
force-pushed
the
revert-10039-revert-8953-separate-manifests-step
branch
from
5705936 to
6b60b8a
Compare
|
Ok, |
|
@wking: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
@wking: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
@wking: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
Issues go stale after 90d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle stale |
openshift-ci-robot
added
the
lifecycle/stale
|
@wking: PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci
bot
added
the
needs-rebase
|
Stale issues rot after 30d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle rotten |
openshift-ci
bot
added
lifecycle/rotten
|
Rotten issues close after 30d of inactivity. Reopen the issue by commenting /close |
|
@openshift-bot: Closed this PR. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
6 participants
Reverts #10039
Hopefully the rehearsals will still show whatever the issue was that motivated #10039...