Skip to content

Conversation

@smarterclayton
Copy link
Contributor

Increase the GCP limit to closer to our limits.

Increase the GCP limit to closer to our limits.
@smarterclayton smarterclayton added the lgtm Indicates that a PR is ready to be merged. label Jul 2, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: smarterclayton

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 2, 2020
@openshift-merge-robot openshift-merge-robot merged commit 3fb4c72 into openshift:master Jul 2, 2020
@openshift-ci-robot
Copy link
Contributor

@smarterclayton: Updated the following 2 configmaps:

  • resources configmap in namespace ci at cluster api.ci using the following files:
    • key boskos.yaml using file core-services/prow/02_config/_boskos.yaml
  • resources configmap in namespace ci at cluster app.ci using the following files:
    • key boskos.yaml using file core-services/prow/02_config/_boskos.yaml
Details

In response to this:

Increase the GCP limit to closer to our limits.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

wking added a commit to wking/openshift-release that referenced this pull request Dec 2, 2020
We'd raised them from 80 to 120 in 1fb9779 (GCP account is
provisioned for 150 networks, bump to 120 clusters, 2020-07-02, openshift#10050),
after (unspecified?) limit bumps.  But recently we've been hitting
[1]:

  level=error msg="Error: Request \"Create IAM Members roles/compute.viewer serviceAccount:ci-ln-4bw2v62-f76d1-685n4-w@openshift-gce-devel-ci.iam.gserviceaccount.com for \\\"project \\\\\\\"openshift-gce-devel-ci\\\\\\\"\\\"\" returned error: Batch request and retried single request \"Create IAM Members roles/compute.viewer serviceAccount:ci-ln-4bw2v62-f76d1-685n4-w@openshift-gce-devel-ci.iam.gserviceaccount.com for \\\"project \\\\\\\"openshift-gce-devel-ci\\\\\\\"\\\"\" both failed. Final error: Error applying IAM policy for project \"openshift-gce-devel-ci\": Error setting IAM policy for project \"openshift-gce-devel-ci\": googleapi: Error 400: The number of members in the policy (1,501) is larger than the maximum allowed size 1,500., badRequest"

Patrick counts six installer-created bindings and 12 additional
cloud-cred-operator-created bindings per cluster, which gives space
for 83 clusters.  Dropping the Boskos cap to 80 leaves 60 bindings
free for long-lived IAM users (e.g. the user we use to create clusters
and users associated with human admins).  If, in the future, we
transition more of our CI to passthrough-mode credentials (instead of
the current mint-mode credentials), we would have space for more CI
clusters under our current policy-member quota.

Generated by editing generate-boskos.py and then running:

  $ hack/validate-boskos.sh

[1]: https://prow.ci.openshift.org/view/gs/origin-ci-test/logs/release-openshift-origin-installer-launch-gcp/1333696073952137216
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants