This repository was archived by the owner on Jan 28, 2020. It is now read-only.
preset: Enable pivot.service #19
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This gives RHCOS the capability to pivot right on first boot. We aren't using this right now (though we were close to) since the MCD just directly starts the service as needed. But I think it'd be nice for RHCOS to support this OOTB.
openshift-ci-robot
added
the
size/XS
ashcrow
approved these changes
Jan 31, 2019
Member
|
@jlebon this should wait until said service is available though, correct? |
Member
|
/hold |
openshift-ci-robot
added
the
do-not-merge/hold
Member
Author
|
This can go in before the service exists. It's harmless to have a preset for non-existent services. |
Member
|
/hold cancel |
openshift-ci-robot
removed
the
do-not-merge/hold
Member
|
/lgtm |
Member
|
/shrug |
Member
Author
|
Weird, not sure why it's not merging. The tide UI does show that the PR meets the label requirements. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This gives RHCOS the capability to pivot right on first boot. We aren't
using this right now (though we were close to) since the MCD just
directly starts the service as needed. But I think it'd be nice for
RHCOS to support this OOTB.