OCPBUGS-56568: chore: compute highestTimestamp at queryManager level #262
Conversation
openshift-ci
bot
added
the
approved
|
/retitle OCPBUGS-56568: chore: compute highestTimestamp at queryManager level |
openshift-ci
bot
changed the title
openshift-ci-robot
added
jira/severity-moderate
|
@machine424: This pull request references Jira Issue OCPBUGS-56568, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/jira refresh |
openshift-ci-robot
added
jira/valid-bug
|
@machine424: This pull request references Jira Issue OCPBUGS-56568, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
Requesting review from QA contact: DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
parial cherry-pick of prometheus#17065 to make it easier to backport to older versions. the new metric is "prometheus_remote_storage_queue_highest_timestamp_seconds"
machine424
force-pushed
the
highest-ts-mqin
branch
from
edacf7a to
d7c54d6
Compare
|
@machine424: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: machine424, simonpasquier The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…_in_seconds in PrometheusRemoteWriteBehind This metric was introduced in openshift/prometheus#262 and related PRs. Dashboard expressions are not changed, since updating them may be more complex. Fixing the alert is more important and we can always revisit that if it causes confusion. On main, dashboards will be adjusted later once the jsonnet dependencies are updated.
…_in_seconds in PrometheusRemoteWriteBehind This metric was introduced in openshift/prometheus#262 and related PRs. Dashboard expressions are not changed, since updating them may be more complex. Fixing the alert is more important and we can always revisit that if it causes confusion. On main, dashboards will be adjusted later once the jsonnet dependencies are updated.
|
openshift/cluster-monitoring-operator#2660 the CMO PR to adjust the alert (only). |
|
given that we're aiming for 4.21 now |
|
/label acknowledge-critical-fixes-only |
openshift-ci
bot
added
the
acknowledge-critical-fixes-only
|
/verified by ci/prow/common-test |
openshift-ci-robot
added
the
verified
|
@machine424: This PR has been marked as verified by DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/hold |
openshift-ci
bot
added
the
do-not-merge/hold
|
/hold cancel |
openshift-ci
bot
removed
the
do-not-merge/hold
|
@machine424: Jira Issue OCPBUGS-56568: Some pull requests linked via external trackers have merged: The following pull request, linked via external tracker, has not merged: All associated pull requests must be merged or unlinked from the Jira bug in order for it to move to the next state. Once unlinked, request a bug refresh with Jira Issue OCPBUGS-56568 has not been moved to the MODIFIED state. This PR is marked as verified. If the remaining PRs listed above are marked as verified before merging, the issue will automatically be moved to VERIFIED after all of the changes from the PRs are available in an accepted nightly payload. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/jira backport release-4.20 |
|
@machine424: The following backport issues have been created:
Queuing cherrypicks to the requested branches to be created after this PR merges: DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@openshift-ci-robot: new pull request created: #264 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
…_in_seconds in PrometheusRemoteWriteBehind This metric was introduced in openshift/prometheus#262 and related PRs. Dashboard expressions are not changed, since updating them may be more complex. Fixing the alert is more important and we can always revisit that if it causes confusion. On main, dashboards will be adjusted later once the jsonnet dependencies are updated.
…_in_seconds in PrometheusRemoteWriteBehind This metric was introduced in openshift/prometheus#262 and related PRs. Dashboard expressions are not changed, since updating them may be more complex. Fixing the alert is more important and we can always revisit that if it causes confusion. On main, dashboards will be adjusted later once the jsonnet dependencies are updated.
…_in_seconds in PrometheusRemoteWriteBehind This metric was introduced in openshift/prometheus#262 and related PRs. Dashboard expressions are not changed, since updating them may be more complex. Fixing the alert is more important and we can always revisit that if it causes confusion. On main, dashboards will be adjusted later once the jsonnet dependencies are updated.
…_in_seconds in PrometheusRemoteWriteBehind This metric was introduced in openshift/prometheus#262 and related PRs. Dashboard expressions are not changed, since updating them may be more complex. Fixing the alert is more important and we can always revisit that if it causes confusion. On main, dashboards will be adjusted later once the jsonnet dependencies are updated.
…_in_seconds in PrometheusRemoteWriteBehind This metric was introduced in openshift/prometheus#262 and related PRs. Dashboard expressions are not changed, since updating them may be more complex. Fixing the alert is more important and we can always revisit that if it causes confusion. On main, dashboards will be adjusted later once the jsonnet dependencies are updated.
4 participants
parial cherry-pick of prometheus#17065 to make it easier to backport to older versions.
the new metric is "prometheus_remote_storage_queue_highest_timestamp_seconds"