Skip to content

Merge rukpak updates into main + Required Fixes #88

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 2 commits into from
Jul 11, 2023
Merged

Merge rukpak updates into main + Required Fixes #88

openshift-merge-robot merged 2 commits into from
Jul 11, 2023

Conversation

@dtfranz
Copy link
Contributor

@dtfranz dtfranz commented Jul 7, 2023

Reverts #87 and adds required fixes for downstream functionality.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 7, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 7, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@dtfranz dtfranz force-pushed the revert-87-revert-86-olmv1-devel branch from 0d25276 to 719b41a Compare July 10, 2023 22:45
@joelanford
Copy link
Member

joelanford commented Jul 11, 2023

Shall we go ahead and add a commit that reverts 29f9cd5 in this PR?

@dtfranz dtfranz changed the title WIP: Merge rukpak updates into main + Required Fixes Merge rukpak updates into main + Required Fixes Jul 11, 2023
@dtfranz
Copy link
Contributor Author

dtfranz commented Jul 11, 2023

/hold

@dtfranz dtfranz marked this pull request as ready for review July 11, 2023 20:34
@openshift-ci openshift-ci bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Jul 11, 2023
@openshift-ci openshift-ci bot requested review from awgreene and tmshort July 11, 2023 20:36
@dtfranz
Copy link
Contributor Author

dtfranz commented Jul 11, 2023

/uncc awgreene tmshort
/cc @ncdc @joelanford @grokspawn

@openshift-ci openshift-ci bot requested review from grokspawn, joelanford and ncdc and removed request for awgreene and tmshort July 11, 2023 20:38
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 11, 2023

@dtfranz: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ncdc
Copy link
Contributor

ncdc commented Jul 11, 2023

/lgtm
/approve

@dtfranz
Copy link
Contributor Author

dtfranz commented Jul 11, 2023

/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 11, 2023
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 11, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 11, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dtfranz, ncdc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 11, 2023
@openshift-merge-robot openshift-merge-robot merged commit 351aa1e into openshift:main Jul 11, 2023
wking added a commit to wking/platform-operators that referenced this pull request Oct 26, 2023
@wking
config/default/kustomization: Drop WEBHOOK section
575db96 
Catching up with 57e32c7 (config,Makefile: Remove the kustomize
configuration for the in-tree PlatformOperator API, 2022-08-31, openshift#26),
which removedthe referenced file:

  $ git log --stat=300 | grep 'commit \|crd/kustomization.yaml' | grep -B1 crd/kustomization.yaml | head -n2
  commit 57e32c7
   config/crd/kustomization.yaml                                 |  21 ---------------------

or possibly it was 719b41a (Revert "Revert "Merge rukpak updates
into main"", 2023-07-07, openshift#88):

  $ git log --stat=300 | grep 'commit \|webhook' | grep -B1 webhook | head -n2
  commit 719b41a
   config/rukpak/apis/webhooks/kustomization.yml                                             |   27 -

but in any case, I don't see a config/webhook directory or a
manager_webhook_patch.yaml patch that this component could be calling
in.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@grokspawn grokspawn Awaiting requested review from grokspawn

@joelanford joelanford Awaiting requested review from joelanford

@ncdc ncdc Awaiting requested review from ncdc

Assignees

@ncdc ncdc

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@dtfranz @joelanford @ncdc @openshift-merge-robot