Skip to content

Add the single node cluster profile #59

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 2 commits into from
Sep 13, 2022
Merged

Add the single node cluster profile #59

openshift-merge-robot merged 2 commits into from
Sep 13, 2022

Conversation

@oceanc80
Copy link
Contributor

@oceanc80 oceanc80 commented Sep 13, 2022

Add the single node cluster profile and update the associated Makefile hack until openshift/api#1282 is merged.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 13, 2022
tylerslaton
tylerslaton approved these changes Sep 13, 2022
View reviewed changes
Copy link
Contributor

@tylerslaton tylerslaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

manifests/0000_50_cluster-platform-operator-manager_00-rukpak-bundles.crd.yaml
properties:
apiVersion:
description: 'APIVersion defines the versioned schema of this representation of an object. Servers should convert recognized schemas to the latest internal value, and may reject unrecognized values. More info: https://git.k8s.io/community/contributors/devel/sig-architecture/api-conventions.md#resources'
description: 'APIVersion defines the versioned schema of this representation
Copy link
Contributor

@tylerslaton tylerslaton Sep 13, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just curious, did make manifests do this? It is weird it hasn't done it before.

Copy link
Contributor Author

@oceanc80 oceanc80 Sep 13, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume so? I didn't open any of those files myself and that file only changed after I ran make manifests 🤷‍♀️

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 13, 2022
@tylerslaton
Copy link
Contributor

tylerslaton commented Sep 13, 2022

It looks like the Makefile hack update that you mentioned didn't come through unless I'm missing something.

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Sep 13, 2022
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 13, 2022
@timflannagan
Copy link
Contributor

timflannagan commented Sep 13, 2022

/retitle Add the single node cluster profile

This is a prerequisite to payload introduction so adding the required labels

/label px-approved
/label qe-approved
/label docs-approved

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 13, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: oceanc80, timflannagan, tylerslaton

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. px-approved Signifies that Product Support has signed off on this PR labels Sep 13, 2022
@openshift-ci openshift-ci bot changed the title [WIP] Add the single node cluster profile Add the single node cluster profile Sep 13, 2022
@openshift-ci openshift-ci bot added qe-approved Signifies that QE has signed off on this PR docs-approved Signifies that Docs has signed off on this PR and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Sep 13, 2022
@openshift-merge-robot openshift-merge-robot merged commit fdeca85 into openshift:main Sep 13, 2022
@oceanc80 oceanc80 deleted the add-sno branch September 13, 2022 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@timflannagan timflannagan timflannagan approved these changes

@tylerslaton tylerslaton tylerslaton approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@timflannagan timflannagan

@tylerslaton tylerslaton

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. docs-approved Signifies that Docs has signed off on this PR lgtm Indicates that a PR is ready to be merged. px-approved Signifies that Product Support has signed off on this PR qe-approved Signifies that QE has signed off on this PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@oceanc80 @tylerslaton @timflannagan @openshift-merge-robot