config,manifests: Update the annotations used in the CVO manifests #54
Conversation
Signed-off-by: timflannagan <timflannagan@gmail.com>
openshift-ci
bot
added
the
approved
|
This is a no-op. Adding the required labels /label px-approved |
openshift-ci
bot
added
px-approved
tylerslaton
left a comment
tylerslaton
left a comment
There was a problem hiding this comment.
Small comment, but otherwise looks good to me
| annotations: | ||
| exclude.release.openshift.io/internal-openshift-hosted: "true" | ||
| include.release.openshift.io/self-managed-high-availability: "true" | ||
| release.openshift.io/feature-set: TechPreviewNoUpgrade |
There was a problem hiding this comment.
Should these have quotes around them now that you added it to the common annotations?
There was a problem hiding this comment.
Oh that's weird that it didn't propagate to the generated manifests. I think we're fine here though given it's a no-op and we've seen successfully CI runs in #23.
|
/hold |
openshift-ci
bot
added
the
do-not-merge/hold
|
/hold cancel |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: timflannagan, tylerslaton The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
removed
the
do-not-merge/hold
|
@timflannagan: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
3 participants
Update the CVO manifests, and update the annotations that are used. Removes the ibm cloud cluster profile for the aggregate CO object, excludes the openshift hosted cluster profile from the annotations, and adds a quote around the "TechPreviewNoUpgrade" feature set.
Moving this out of the #23 PR.
Signed-off-by: timflannagan timflannagan@gmail.com