update to release.openshift.io/feature-set to match OCP 4.12

[deads2k]

This was added in
openshift/cluster-version-operator#821 to allow
more featuresets and allow for a future migration to include actual gates

/cc @wking

Looking at this repo, it was not present in 4.11, so there is no migration concern.

[exdx]

/lgtm

[exdx]

Hi @deads2k, the verify check is failing because the new annotation is not being applied to the PO CRD. We would need to update it here

platform-operators/Makefile

Line 82 in b205d77

${YQ} w -d'*' --inplace --style=double manifests/0000_50_cluster-platform-operator-manager_00-platformoperator.crd.yaml 'metadata.annotations['include.release.openshift.io/self-managed-high-availability']' true

or apply a patch to the configs directory.

[deads2k]

Hi @deads2k, the verify check is failing because the new annotation is not being applied to the PO CRD. We would need to update it here

Looks like the CRD manifest is copied from the vendor folder (this is fine). Not sure what the additional annotation is about, but I have fixed openshift/api and revendored to see if that fixes it

[tylerslaton]

/retest

[openshift-ci]

@deads2k: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e	a36736c	link	false	/test e2e
ci/prow/e2e-techpreview	e4a9959	link	false	/test e2e-techpreview

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[wking]

ClusterOperator are cluster-scoped resources, so this line is not necessary.

[wking]

e2e-techpreview:

  Error: Unexpected non-nil/non-zero argument at index 1:
  	<*errors.StatusError>: &errors.StatusError{ErrStatus:v1.Status{TypeMeta:v1.TypeMeta{Kind:"", APIVersion:""}, ListMeta:v1.ListMeta{SelfLink:"", ResourceVersion:"", Continue:"", RemainingItemCount:(*int64)(nil)}, Status:"Failure", Message:"clusteroperators.config.openshift.io \"platform-operators-aggregated\" not found", Reason:"NotFound", Details:(*v1.StatusDetails)(0xc00099a6c0), Code:404}}
  In [It] at: /go/src/github.com/openshift/platform-operators/test/e2e/aggregated_clusteroperator_test.go:38

Looking at CVO logs, I'm unclear about why. The CVO knows it's TechPreviewNoUpgrade, but has nothing to say about platform-operators-aggregated:

$ curl -s https://gcsweb-ci.apps.ci.l2s4.p1.openshiftapps.com/gcs/origin-ci-test/pr-logs/pull/openshift_platform-operators/45/pull-ci-openshift-platform-operators-main-e2e-techpreview/1567966053030432768/artifacts/e2e-techpreview/gather-extra/artifacts/pods/openshift-cluster-version_cluster-version-operator-5cb8b76556-jv6mw_cluster-version-operator.log | grep 'featurechangestopper\|platform-operators-aggregated'
I0908 20:32:24.570421       1 featurechangestopper.go:100] Starting stop-on-featureset-change controller with "TechPreviewNoUpgrade".

Or, I guess, anything in openshift-platform-operators either. Perhaps the io.openshift.release.operator label isn't set yet, and this presubmit is currently a dud?

[timflannagan]

@wking Yeah, the io.openshift.release.operator Dockerfile label still needs to be toggled on to true in this repository. That's being done in #23 but in the meantime, there won't be any e2e feedback. We were seeing e2e runs in that 23 PR fail because the aggregate platform operators CO resource didn't exist, but looking at a recent run it looks like we're back in business.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, exdx, timflannagan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [timflannagan]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[timflannagan]

These changes are already present in the #23 which has passed the e2e suite in recent runs. We're still in the process of bootstrapping this repository while we wait for payload introduction, so I'm going to add the requisite no-ff labels until then.

/label px-approved
/label docs-approved
/label qe-approved