Skip to content

root: Fix defer call to be after error check #52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jlebon merged 1 commit into from
May 14, 2019
Merged

root: Fix defer call to be after error check #52

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions cmd/root.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,14 +102,13 @@ func parseTuningFile(tuningFilePath, cmdLinePath string) ([]types.TuneArgument,
}
// Read and parse the file
file, err := os.Open(tuningFilePath)
// Clean up
defer file.Close()

if err != nil {
// If we have an issue reading return an error
glog.Infof("Unable to open %s for reading: %v", tuningFilePath, err)
return addArguments, deleteArguments, err
}
// Clean up
defer file.Close()

// Parse the tuning lines
scanner := bufio.NewScanner(file)
Expand Down