cmd/root: Restructure to be more idempotent #29
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a new wrapper that just ignores command errors. Then use it for `podman kill` and `podman rm`. The advantage of this is that we now log the invocations as well as any errors from them.
Factor out the code that actually pulls and rebases so that we have the same out path in both changed and unchanged cases in `Execute()`. This will become useful for an upcoming patch where we'll introduce a systemd service conditioned on a file, though one minor thing this fixes right now is that we always try to delete the image, even if we didn't just pull it.
With the previous patch, we now always try to delete the image (unless `--keep` was passed), instead of only if we pulled it in this session. As a result, we no longer want to fail if we can't delete the image because it doesn't exist already. I opened an RFE on podman for this, though really, even if it failed because of another error, we don't really want want to fail the whole operation for this.
openshift-ci-robot
added
the
size/M
Member
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Factor out the code that actually pulls and rebases so that we have the
same out path in both changed and unchanged cases in
Execute(). Thiswill become useful for an upcoming patch where we'll introduce a systemd
service conditioned on a file, though one minor thing this fixes right
now is that we always try to delete the image, even if we didn't just
pull it.