Skip to content

[release-4.9] Bug 2054139: Don't return err when annotation cannot be unmarshalled#954

Merged
openshift-merge-robot merged 1 commit intoopenshift:release-4.9from
tssurya:bug-2054139
Feb 22, 2022
Merged

[release-4.9] Bug 2054139: Don't return err when annotation cannot be unmarshalled#954
openshift-merge-robot merged 1 commit intoopenshift:release-4.9from
tssurya:bug-2054139

Conversation

@tssurya
Copy link
Contributor

@tssurya tssurya commented Feb 14, 2022

Signed-off-by: Surya Seetharaman suryaseetharaman.9@gmail.com
(cherry picked from commit 4c47ef9)

- What this PR does and why is it needed

- Special notes for reviewers

- How to verify it

- Description for the changelog

@tssurya
Don't return err when annotation cannot be unmarshalled
8cfe718 
Signed-off-by: Surya Seetharaman <suryaseetharaman.9@gmail.com>
(cherry picked from commit 4c47ef9)
@openshift-ci openshift-ci bot added bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Feb 14, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 14, 2022

@tssurya: This pull request references Bugzilla bug 2054139, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.9.z) matches configured target release for branch (4.9.z)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 2011971 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE))
  • dependent Bugzilla bug 2011971 targets the "4.10.0" release, which is one of the valid target releases: 4.10.0
  • bug has dependents

Requesting review from QA contact:
/cc @anuragthehatter

Details

In response to this:

Bug 2054139: Don't return err when annotation cannot be unmarshalled

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tssurya
Copy link
Contributor Author

tssurya commented Feb 14, 2022

/retest

@tssurya
Copy link
Contributor Author

tssurya commented Feb 15, 2022

/test e2e-metal-ipi-ovn-dualstack

@tssurya
Copy link
Contributor Author

tssurya commented Feb 15, 2022

/cc @trozet : It's a clean backport.

@tssurya tssurya changed the title Bug 2054139: Don't return err when annotation cannot be unmarshalled [release-4.9] Bug 2054139: Don't return err when annotation cannot be unmarshalled Feb 15, 2022
trozet
trozet approved these changes Feb 15, 2022
View reviewed changes
Copy link
Contributor

@trozet trozet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/label backport-risk-assessed
/lgtm

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Feb 15, 2022
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 15, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 15, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: trozet, tssurya

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 15, 2022
@tssurya
Copy link
Contributor Author

tssurya commented Feb 15, 2022

/assign @anuragthehatter

@anuragthehatter
Copy link

anuragthehatter commented Feb 21, 2022

/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Feb 21, 2022
@anuragthehatter
Copy link

anuragthehatter commented Feb 21, 2022

/label cherry-pick-approved

@openshift-ci openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Feb 21, 2022
@openshift-bot
Copy link
Contributor

openshift-bot commented Feb 21, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

4 similar comments
@openshift-bot
Copy link
Contributor

openshift-bot commented Feb 22, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Feb 22, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Feb 22, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Feb 22, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@tssurya
Copy link
Contributor Author

tssurya commented Feb 22, 2022

/test e2e-metal-ipi-ovn-dualstack

@tssurya
Copy link
Contributor Author

tssurya commented Feb 22, 2022

failure seems unrelated to PR:

Running must-gather... error: default cluster has no server defined {"component":"entrypoint","error":"wrapped process failed: exit status 1","file":"prow/entrypoint/run.go:80","func":"k8s.io/test-infra/prow/entrypoint.Options.Run","level":"error","msg":"Error executing test process","severity":"error","time":"2022-02-22T09:32:06Z"} error: failed to execute wrapped command: exit status 1

also it seems to be perma failing: https://prow.ci.openshift.org/job-history/gs/origin-ci-test/pr-logs/directory/pull-ci-openshift-ovn-kubernetes-release-4.9-e2e-metal-ipi-ovn-dualstack?buildId=

@openshift-bot
Copy link
Contributor

openshift-bot commented Feb 22, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@squeed
Copy link
Contributor

squeed commented Feb 22, 2022

/override ci/prow/e2e-metal-ipi-ovn-dualstack

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 22, 2022

@squeed: Overrode contexts on behalf of squeed: ci/prow/e2e-metal-ipi-ovn-dualstack

Details

In response to this:

/override ci/prow/e2e-metal-ipi-ovn-dualstack

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot openshift-merge-robot merged commit fbf5bc3 into openshift:release-4.9 Feb 22, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 22, 2022

@tssurya: All pull requests linked via external trackers have merged:

Bugzilla bug 2054139 has been moved to the MODIFIED state.

Details

In response to this:

[release-4.9] Bug 2054139: Don't return err when annotation cannot be unmarshalled

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tssurya
Copy link
Contributor Author

tssurya commented Feb 22, 2022

/cherry-pick release-4.8

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 22, 2022

@tssurya: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Feb 22, 2022

@tssurya: new pull request created: #963

Details

In response to this:

/cherry-pick release-4.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Feb 22, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@anuragthehatter anuragthehatter Awaiting requested review from anuragthehatter

@JacobTanenbaum JacobTanenbaum Awaiting requested review from JacobTanenbaum

@squeed squeed Awaiting requested review from squeed

1 more reviewer

@trozet trozet trozet approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@trozet trozet

@anuragthehatter anuragthehatter

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm Indicates that a PR is ready to be merged. qe-approved Signifies that QE has signed off on this PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@tssurya @anuragthehatter @openshift-bot @squeed @openshift-cherrypick-robot @trozet @openshift-merge-robot

Comments