Skip to content

WIP [release-4.9] Bug 2047416: restart pod on non-retriable failures when deleting stale objects #936

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
flavio-fernandes wants to merge 1 commit into from
Closed

WIP [release-4.9] Bug 2047416: restart pod on non-retriable failures when deleting stale objects #936

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions go-controller/pkg/ovn/namespace.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,12 +42,12 @@ func (oc *Controller) syncNamespaces(namespaces []interface{}) {
err := oc.addressSetFactory.ProcessEachAddressSet(func(addrSetName, namespaceName, nameSuffix string) {
if nameSuffix == "" && !expectedNs[namespaceName] {
if err := oc.addressSetFactory.DestroyAddressSetInBackingStore(addrSetName); err != nil {
klog.Errorf(err.Error())
klog.Fatalf(err.Error())
}
}
})
if err != nil {
klog.Errorf("Error in syncing namespaces: %v", err)
klog.Fatalf("Error in syncing namespaces: %v", err)
}
}

Expand Down
6 changes: 3 additions & 3 deletions go-controller/pkg/ovn/pods.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ func (oc *Controller) syncPods(pods []interface{}) {
// get the list of logical ports from OVN
nodes, err := oc.watchFactory.GetNodes()
if err != nil {
klog.Errorf("Failed to get nodes")
klog.Fatalf("Failed to get nodes")
return
}
for _, n := range nodes {
Expand All @@ -75,12 +75,12 @@ func (oc *Controller) syncPods(pods []interface{}) {
klog.Infof("Stale logical port found: %s. This logical port will be deleted.", existingPort)
cmd, err := oc.ovnNBClient.LSPDel(existingPort)
if err != nil {
klog.Errorf("Error in getting the cmd to delete pod's logical port %s %v", existingPort, err)
klog.Fatalf("Error in getting the cmd to delete pod's logical port %s %v", existingPort, err)
continue
}
err = oc.ovnNBClient.Execute(cmd)
if err != nil {
klog.Errorf("Error deleting pod's logical port %s %v", existingPort, err)
klog.Fatalf("Error deleting pod's logical port %s %v", existingPort, err)
continue
}
}
Expand Down
2 changes: 1 addition & 1 deletion go-controller/pkg/ovn/policy.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,7 @@ func (oc *Controller) syncNetworkPolicies(networkPolicies []interface{}) {
hashedLocalPortGroup := hashedPortGroup(portGroupName)
err := deletePortGroup(oc.ovnNBClient, hashedLocalPortGroup)
if err != nil {
klog.Errorf("%v", err)
klog.Fatalf("%v", err)
}

// delete the address sets for this old policy from OVN
Expand Down