Bug 2039698: Hacky way of doing ITP:preferLocal for openshift-dns:default #896

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

openshift-merge-robot merged 1 commit into openshift:master from tssurya:hack-4-openshift-dns

Jan 17, 2022

Contributor

tssurya commented Jan 10, 2022 •

edited

Loading

- What this PR does and why is it needed
This PR does the equivalent of openshift/sdn#261
for OVN-K. We can remove this hack when we support
ITP:preferLocal in the future.

Signed-off-by: Surya Seetharaman [email protected]

openshift-ci bot added the do-not-merge/work-in-progress label

tssurya force-pushed the hack-4-openshift-dns branch from 599b182 to 4a7c407 Compare

January 10, 2022 20:33

openshift-ci bot requested review from aojea and trozet

January 10, 2022 20:35

Contributor Author

tssurya commented Jan 11, 2022

/retest

tssurya force-pushed the hack-4-openshift-dns branch from 410db93 to 4593cef Compare

January 11, 2022 20:24

tssurya changed the title ~~[WIP]: Hacky way of doing ITP:preferLocal for openshift-dns:default~~ Bug 2026887: Hacky way of doing ITP:preferLocal for openshift-dns:default

openshift-ci bot removed the do-not-merge/work-in-progress label

tssurya force-pushed the hack-4-openshift-dns branch 2 times, most recently from 0900e37 to 447b286 Compare

January 11, 2022 20:29

Contributor Author

tssurya commented Jan 11, 2022

/bugzilla-refresh

Contributor Author

tssurya commented Jan 11, 2022

/bugzilla refresh

Contributor

openshift-ci bot commented Jan 11, 2022

@tssurya: Bugzilla bug 2026887 is in a bug group that is not in the allowed groups for this repo.
Allowed groups for this repo are:

qe_staff
redhat

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Contributor Author

tssurya commented Jan 11, 2022

/test e2e-aws-ovn-windows
/test e2e-aws-ovn-upgrade

tssurya changed the title ~~Bug 2026887: Hacky way of doing ITP:preferLocal for openshift-dns:default~~ Bug 2039698: Hacky way of doing ITP:preferLocal for openshift-dns:default

Contributor

openshift-ci bot commented Jan 12, 2022

@tssurya: This pull request references Bugzilla bug 2039698, which is invalid:

expected the bug to target the "4.10.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Bug 2039698: Hacky way of doing ITP:preferLocal for openshift-dns:default

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci bot added bugzilla/severity-medium bugzilla/invalid-bug labels

Contributor Author

tssurya commented Jan 12, 2022

/bugzilla refresh

openshift-ci bot added bugzilla/valid-bug and removed bugzilla/invalid-bug labels

Contributor

openshift-ci bot commented Jan 12, 2022

@tssurya: This pull request references Bugzilla bug 2039698, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.10.0) matches configured target release for branch (4.10.0)
bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @anuragthehatter

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci bot requested a review from anuragthehatter

January 12, 2022 09:26

Contributor Author

tssurya commented Jan 12, 2022

/retest

tssurya commented

View reviewed changes

go-controller/pkg/ovn/controller/services/load_balancer.go Outdated

    
              					switchV4targetips = util.FilterIPsSlice(switchV4targetips, node.nodeSubnets(), true)

              					switchV6targetips = util.FilterIPsSlice(switchV6targetips, node.nodeSubnets(), true)

              				}

Contributor Author

tssurya Jan 12, 2022

ugh, go away


          Bug 2026887: Hack ITP:preferLocal for DNS service

bfe85db

This PR does the equivalent of openshift/sdn#261
for OVN-K. We can remove this hack when we support
ITP:preferLocal in the future.

Signed-off-by: Surya Seetharaman <[email protected]>

tssurya force-pushed the hack-4-openshift-dns branch from 447b286 to bfe85db Compare

January 12, 2022 11:30

Contributor Author

tssurya commented Jan 12, 2022

/retest

Contributor Author

tssurya commented Jan 12, 2022

/retest-required

Contributor Author

tssurya commented Jan 13, 2022

/retest

Contributor

openshift-bot commented Jan 17, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

21 similar comments

Contributor

openshift-bot commented Jan 17, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Jan 17, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Jan 17, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Jan 17, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Jan 17, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Jan 17, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Jan 17, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Jan 17, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Jan 17, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Jan 17, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Jan 17, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Jan 17, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Jan 17, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Jan 17, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Jan 17, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Jan 17, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Jan 17, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Jan 17, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Jan 17, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Jan 17, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Jan 17, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-ci bot commented Jan 17, 2022 •

edited

Loading

@tssurya: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/4.10-upgrade-from-stable-4.9-e2e-aws-ovn-upgrade	`bfe85db`	link	false	`/test 4.10-upgrade-from-stable-4.9-e2e-aws-ovn-upgrade`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Contributor

abhat commented Jan 17, 2022

/override ci/prow/e2e-metal-ipi-ovn-dualstack
job is perma-failing.

Contributor

openshift-ci bot commented Jan 17, 2022

@abhat: Overrode contexts on behalf of abhat: ci/prow/e2e-metal-ipi-ovn-dualstack

Details

In response to this:

/override ci/prow/e2e-metal-ipi-ovn-dualstack
job is perma-failing.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-merge-robot merged commit 1cff28f into openshift:master

Contributor

openshift-ci bot commented Jan 17, 2022

@tssurya: All pull requests linked via external trackers have merged:

openshift/ovn-kubernetes#896

Bugzilla bug 2039698 has been moved to the MODIFIED state.

Details

In response to this:

Bug 2039698: Hacky way of doing ITP:preferLocal for openshift-dns:default

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Contributor Author

tssurya commented Feb 21, 2022

/cherry-pick release-4.9

openshift-cherrypick-robot commented Feb 21, 2022

@tssurya: #896 failed to apply on top of branch "release-4.9":

Applying: Bug 2026887: Hack ITP:preferLocal for DNS service
Using index info to reconstruct a base tree...
M	go-controller/pkg/ovn/controller/services/load_balancer.go
M	go-controller/pkg/ovn/controller/services/load_balancer_test.go
Falling back to patching base and 3-way merge...
Auto-merging go-controller/pkg/ovn/controller/services/load_balancer_test.go
Auto-merging go-controller/pkg/ovn/controller/services/load_balancer.go
CONFLICT (content): Merge conflict in go-controller/pkg/ovn/controller/services/load_balancer.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Bug 2026887: Hack ITP:preferLocal for DNS service
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

Details

In response to this:

/cherry-pick release-4.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Miciah mentioned this pull request

Bug 2095941: topology aware hints to prefer to keep dns traffic within a zone openshift/cluster-dns-operator#322

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

aojea Awaiting requested review from aojea

anuragthehatter Awaiting requested review from anuragthehatter

dcbw Awaiting requested review from dcbw

squeed Awaiting requested review from squeed

1 more reviewer

trozet trozet left review comments

Labels

approved bugzilla/severity-medium bugzilla/valid-bug lgtm