Bug 1796531: CARRY: fix race updating exclude IPs on node switch#83
Conversation
openshift-ci-robot
added
size/S
openshift-ci-robot
added
size/M
|
Failures are supposedly due to openshift/installer#3007 (per abhinav) /test e2e-aws-ovn |
|
/test e2e-aws-ovn |
|
Now that openshift/origin#24477 is in... /test e2e-aws-ovn |
dcbw
changed the title
|
@dcbw: This pull request references Bugzilla bug 1796531, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
the
bugzilla/valid-bug
|
Cloud Credential Operator issue: /test e2e-aws-ovn |
When nodes are added to the cluster, it may be that our pod add handler is waiting for the node switch to show up. It might win the race and create the pod between our node switch being created in master.go and the exclude IPs being updated immediately after. Fix this by reverting to setting the exclude IPs during logical switch creation. This is essentially a revert of part of 80d6dff Fixes: 80d6dff
|
KubeAPILatencyHigh alert for AWS, unrelated flakes for GCP. /retest |
|
Flake https://bugzilla.redhat.com/show_bug.cgi?id=1796739 /retest |
|
/retest |
|
@dcbw: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dcbw, rcarrillocruz The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@dcbw: All pull requests linked via external trackers have merged. Bugzilla bug 1796531 has been moved to the MODIFIED state. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
5 participants
When nodes are added to the cluster, it may be that our pod add
handler is waiting for the node switch to show up. It might win
the race and create the pod between our node switch being
created in master.go and the exclude IPs being updated immediately
after. Fix this by reverting to setting the exclude IPs during
logical switch creation.
This is essentially a revert of part of 806dff11
Fixes: 80d6dff