[release-4.19] OCPBUGS-81478: node: fix serviceUpdateNotNeeded nil pointer comparison by pliurh · Pull Request #3100 · openshift/ovn-kubernetes

pliurh · 2026-03-31T08:45:43Z

serviceUpdateNotNeeded() used explicit nil guards before dereferencing InternalTrafficPolicy and AllocateLoadBalancerNodePorts. When both old and new are nil (all non-LoadBalancer services), (nil != nil && ...) evaluates to false, incorrectly indicating an update is needed.

Use reflect.DeepEqual on the pointer directly, which handles nil == nil.

(cherry picked from commit 40caf4c) (cherry picked from commit 581bfde) (cherry picked from commit 2a5bf31)

📑 Description

Fixes #

Additional Information for reviewers

✅ Checks

My code requires changes to the documentation
if so, I have updated the documentation as required
My code requires tests
if so, I have added and/or updated the tests as required
All the tests have passed in the CI

How to verify it

serviceUpdateNotNeeded() used explicit nil guards before dereferencing InternalTrafficPolicy and AllocateLoadBalancerNodePorts. When both old and new are nil (all non-LoadBalancer services), (nil != nil && ...) evaluates to false, incorrectly indicating an update is needed. Use reflect.DeepEqual on the pointer directly, which handles nil == nil. Signed-off-by: Peng Liu <pliu@redhat.com> (cherry picked from commit 40caf4c) (cherry picked from commit 581bfde) (cherry picked from commit 2a5bf31)

openshift-ci-robot · 2026-03-31T08:45:50Z

@pliurh: This pull request references Jira Issue OCPBUGS-81478, which is invalid:

expected the bug to target either version "4.19." or "openshift-4.19.", but it targets "4.20.z" instead
release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
expected Jira Issue OCPBUGS-81478 to depend on a bug targeting a version in 4.20.0, 4.20.z and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

serviceUpdateNotNeeded() used explicit nil guards before dereferencing InternalTrafficPolicy and AllocateLoadBalancerNodePorts. When both old and new are nil (all non-LoadBalancer services), (nil != nil && ...) evaluates to false, incorrectly indicating an update is needed.

Use reflect.DeepEqual on the pointer directly, which handles nil == nil.

(cherry picked from commit 40caf4c) (cherry picked from commit 581bfde) (cherry picked from commit 2a5bf31)

📑 Description

Fixes #

Additional Information for reviewers

✅ Checks

My code requires changes to the documentation

if so, I have updated the documentation as required

My code requires tests

if so, I have added and/or updated the tests as required

All the tests have passed in the CI

How to verify it

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

coderabbitai · 2026-03-31T08:51:38Z

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yml

Review profile: CHILL

Plan: Pro

Run ID: 1a8c21b5-847f-4d97-af9d-92b2408bf4af

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

Note

`.coderabbit.yml` has unrecognized properties

CodeRabbit is using all valid settings from your configuration. Unrecognized properties (listed below) have been ignored and may indicate typos or deprecated fields that can be removed.

⚠️ Parsing warnings (1)

Validation error: Unrecognized key(s) in object: 'paths_ignore'

⚙️ Configuration instructions

Please see the configuration documentation for more information.
You can also validate your configuration using the online YAML validator.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

pliurh · 2026-04-02T11:21:07Z

/retest-required

Signed-off-by: Ying Wang <yingwang@rehat.com>

yingwang-0320 · 2026-04-07T17:28:45Z

/verified by pre-merge testing

openshift-ci-robot · 2026-04-07T17:28:58Z

@yingwang-0320: This PR has been marked as verified by pre-merge testing.

Details

In response to this:

/verified by pre-merge testing

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

tssurya

/lgtm

tssurya · 2026-04-10T14:15:22Z

/lgtm
/approve
/label backport-risk-assessed

openshift-ci · 2026-04-10T14:16:25Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pliurh, tssurya

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [tssurya]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci · 2026-04-10T19:11:17Z

@pliurh: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/security	`ab20d0a`	link	false	`/test security`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

SachinNinganure · 2026-04-13T17:37:33Z

Scale test details
basic test:
API server restarts that cause service rule re-evaluation
Multiple service/pod configurations that would amplify the bug
verified no TCP RST packet floods
3 different tests were run with 100/160/480 pods and 20/35/105 services

Verified the scale and additional scenarios on the cluster with fix ; - The reflect.DeepEqual() fix in OVN-Kubernetes successfully prevents TCP RST storms

No RST packets generated during OVN pod restarts (trigger1)
No RST packets generated during API restarts (trigger2)

additionally conducted Service Resilience Validation Test which is API Restart Service Preservation Test
OVN watch loss and service resync events
Heavy traffic during serviceUpdateNotNeeded() timing windows
Customer-scale service configuration (16 external IPs, 4 TCP ports 10.157.2.10 through 10.157.2.25 and 80, 443, 15021, 30381 ports)
50+ external IPs and multiple TCP ports (as per cu setup)
Traffic Injection: Heavy concurrent connections during API restart window

1>All 16 external IPs maintained service preservation
2>0 service-specific RST packets seen
3>75-second downtime handled successfully(api outage)

SachinNinganure · 2026-04-13T17:44:21Z

/verified by @SachinNinganure

openshift-ci-robot · 2026-04-13T17:44:32Z

@SachinNinganure: This PR has been marked as verified by @SachinNinganure.

Details

In response to this:

/verified by @SachinNinganure

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

arkadeepsen · 2026-04-14T07:24:59Z

/retest-required

arkadeepsen · 2026-04-14T10:54:12Z

/retest-required

arkadeepsen · 2026-04-14T12:13:39Z

/payload 4.19 ci blocking
/payload 4.19 nightly blocking

openshift-ci · 2026-04-14T12:13:46Z

@arkadeepsen: trigger 5 job(s) of type blocking for the ci release of OCP 4.19

periodic-ci-openshift-release-main-ci-4.19-upgrade-from-stable-4.18-e2e-aws-ovn-upgrade
periodic-ci-openshift-release-main-ci-4.19-upgrade-from-stable-4.18-e2e-azure-ovn-upgrade
periodic-ci-openshift-release-main-ci-4.19-e2e-gcp-ovn-upgrade
periodic-ci-openshift-hypershift-release-4.19-periodics-e2e-aks
periodic-ci-openshift-hypershift-release-4.19-periodics-e2e-aws-ovn

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/5f80edc0-37fb-11f1-9993-c707d1a40497-0

trigger 9 job(s) of type blocking for the nightly release of OCP 4.19

periodic-ci-openshift-release-main-nightly-4.19-e2e-aws-ovn-serial
periodic-ci-openshift-release-main-ci-4.19-e2e-aws-upgrade-ovn-single-node
periodic-ci-openshift-release-main-nightly-4.19-e2e-aws-ovn-upgrade-fips
periodic-ci-openshift-release-main-ci-4.19-e2e-azure-ovn-upgrade
periodic-ci-openshift-release-main-ci-4.19-upgrade-from-stable-4.18-e2e-gcp-ovn-rt-upgrade
periodic-ci-openshift-hypershift-release-4.19-periodics-e2e-azure-aks-ovn-conformance
periodic-ci-openshift-hypershift-release-4.19-periodics-e2e-aws-ovn-conformance
periodic-ci-openshift-release-main-nightly-4.19-e2e-metal-ipi-ovn-bm
periodic-ci-openshift-release-main-nightly-4.19-e2e-metal-ipi-ovn-ipv6

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/5f80edc0-37fb-11f1-9993-c707d1a40497-1

arkadeepsen · 2026-04-14T12:34:59Z

/retest-required

arkadeepsen · 2026-04-14T14:31:02Z

/retest-required

arkadeepsen · 2026-04-14T15:10:48Z

/payload-job periodic-ci-openshift-hypershift-release-4.19-periodics-e2e-aks
/payload-job periodic-ci-openshift-hypershift-release-4.19-periodics-e2e-azure-aks-ovn-conformance
/payload-job periodic-ci-openshift-hypershift-release-4.19-periodics-e2e-aws-ovn-conformance

openshift-ci · 2026-04-14T15:11:21Z

@arkadeepsen: An error was encountered. No known errors were detected, please see the full error message for details.

Full error message.


could not create PullRequestPayloadQualificationRun: rpc error: code = Unavailable desc = keepalive ping failed to receive ACK within timeout

Please contact an administrator to resolve this issue.

arkadeepsen · 2026-04-14T15:18:06Z

/payload-job periodic-ci-openshift-hypershift-release-4.19-periodics-e2e-aks
/payload-job periodic-ci-openshift-hypershift-release-4.19-periodics-e2e-azure-aks-ovn-conformance
/payload-job periodic-ci-openshift-hypershift-release-4.19-periodics-e2e-aws-ovn-conformance

openshift-ci · 2026-04-14T15:18:10Z

@arkadeepsen: trigger 3 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

periodic-ci-openshift-hypershift-release-4.19-periodics-e2e-aks
periodic-ci-openshift-hypershift-release-4.19-periodics-e2e-azure-aks-ovn-conformance
periodic-ci-openshift-hypershift-release-4.19-periodics-e2e-aws-ovn-conformance

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/241b65c0-3815-11f1-81f0-e0b12b1226b3-0

jluhrsen · 2026-04-15T00:05:29Z

/payload-job periodic-ci-openshift-hypershift-release-4.19-periodics-e2e-aks
/payload-job periodic-ci-openshift-hypershift-release-4.19-periodics-e2e-azure-aks-ovn-conformance

openshift-ci · 2026-04-15T00:05:58Z

@jluhrsen: trigger 2 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

periodic-ci-openshift-hypershift-release-4.19-periodics-e2e-aks
periodic-ci-openshift-hypershift-release-4.19-periodics-e2e-azure-aks-ovn-conformance

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/d0d02820-385e-11f1-89c5-67f891a6cace-0

jluhrsen · 2026-04-15T00:06:29Z

/test e2e-aws-ovn-edge-zones

is this supposed to be good now? I do see that it passed a few times recently, but looks pretty bad.

arkadeepsen · 2026-04-15T06:29:12Z

/payload-job periodic-ci-openshift-release-main-ci-4.19-upgrade-from-stable-4.18-e2e-azure-ovn-upgrade
/payload-job periodic-ci-openshift-hypershift-release-4.19-periodics-e2e-aks
/payload-job periodic-ci-openshift-release-main-nightly-4.19-e2e-metal-ipi-ovn-ipv6

openshift-ci · 2026-04-15T06:29:16Z

@arkadeepsen: trigger 3 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

periodic-ci-openshift-release-main-ci-4.19-upgrade-from-stable-4.18-e2e-azure-ovn-upgrade
periodic-ci-openshift-hypershift-release-4.19-periodics-e2e-aks
periodic-ci-openshift-release-main-nightly-4.19-e2e-metal-ipi-ovn-ipv6

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/6ba88ec0-3894-11f1-9829-a6a8506b4fbf-0

arkadeepsen · 2026-04-15T09:01:31Z

/jira refresh

openshift-ci-robot · 2026-04-15T09:01:37Z

@arkadeepsen: This pull request references Jira Issue OCPBUGS-81478, which is invalid:

expected dependent Jira Issue OCPBUGS-81477 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is MODIFIED instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

arkadeepsen · 2026-04-15T09:32:00Z

/jira refresh

openshift-ci-robot · 2026-04-15T09:32:08Z

@arkadeepsen: This pull request references Jira Issue OCPBUGS-81478, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.19.z) matches configured target version for branch (4.19.z)
bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
release note text is set and does not match the template
dependent bug Jira Issue OCPBUGS-81477 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
dependent Jira Issue OCPBUGS-81477 targets the "4.20.z" version, which is one of the valid target versions: 4.20.0, 4.20.z
bug has dependents

Requesting review from QA contact:
/cc @SachinNinganure

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot · 2026-04-15T14:20:33Z

@pliurh: Jira Issue Verification Checks: Jira Issue OCPBUGS-81478
✔️ This pull request was pre-merge verified.
✔️ All associated pull requests have merged.
✔️ All associated, merged pull requests were pre-merge verified.

Jira Issue OCPBUGS-81478 has been moved to the MODIFIED state and will move to the VERIFIED state when the change is available in an accepted nightly payload. 🕓

Details

In response to this:

serviceUpdateNotNeeded() used explicit nil guards before dereferencing InternalTrafficPolicy and AllocateLoadBalancerNodePorts. When both old and new are nil (all non-LoadBalancer services), (nil != nil && ...) evaluates to false, incorrectly indicating an update is needed.

Use reflect.DeepEqual on the pointer directly, which handles nil == nil.

(cherry picked from commit 40caf4c) (cherry picked from commit 581bfde) (cherry picked from commit 2a5bf31)

📑 Description

Fixes #

Additional Information for reviewers

✅ Checks

My code requires changes to the documentation

if so, I have updated the documentation as required

My code requires tests

if so, I have added and/or updated the tests as required

All the tests have passed in the CI

How to verify it

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci Bot requested review from jcaamano and kyrtapz March 31, 2026 08:48

yingwang-0320 pushed a commit to yingwang-0320/release that referenced this pull request Apr 7, 2026

verify PR openshift/ovn-kubernetes#3100

3d2c278

Signed-off-by: Ying Wang <yingwang@rehat.com>

yingwang-0320 mentioned this pull request Apr 7, 2026

WIP: debug ci openshift/release#77456

Closed

openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Apr 7, 2026

tssurya approved these changes Apr 10, 2026

View reviewed changes

openshift-ci Bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Apr 10, 2026

openshift-ci Bot assigned anuragthehatter, asood-rh, barbora137, jechen0648, mffiedler, rbbratta, weliang1, yingwang-0320 and tssurya Apr 10, 2026

openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Apr 10, 2026

openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 10, 2026

openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Apr 15, 2026

openshift-ci Bot requested a review from SachinNinganure April 15, 2026 09:32

openshift-merge-bot Bot merged commit cf0c520 into openshift:release-4.19 Apr 15, 2026
28 of 29 checks passed

jluhrsen mentioned this pull request Apr 23, 2026

NO-JIRA: Branch Sync release-4.20 to release-4.19 [04-15-2026] #3138

Open

Conversation

pliurh commented Mar 31, 2026

📑 Description

Additional Information for reviewers

✅ Checks

How to verify it

Uh oh!

openshift-ci-robot commented Mar 31, 2026

📑 Description

Additional Information for reviewers

✅ Checks

How to verify it

Uh oh!

coderabbitai Bot commented Mar 31, 2026

Review skipped

.coderabbit.yml has unrecognized properties

Uh oh!

pliurh commented Apr 2, 2026

Uh oh!

yingwang-0320 commented Apr 7, 2026

Uh oh!

openshift-ci-robot commented Apr 7, 2026

Uh oh!

tssurya left a comment

Choose a reason for hiding this comment

Uh oh!

tssurya commented Apr 10, 2026

Uh oh!

openshift-ci Bot commented Apr 10, 2026

Uh oh!

openshift-ci Bot commented Apr 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

SachinNinganure commented Apr 13, 2026

Uh oh!

SachinNinganure commented Apr 13, 2026

Uh oh!

openshift-ci-robot commented Apr 13, 2026

Uh oh!

arkadeepsen commented Apr 14, 2026

Uh oh!

arkadeepsen commented Apr 14, 2026

Uh oh!

arkadeepsen commented Apr 14, 2026

Uh oh!

openshift-ci Bot commented Apr 14, 2026

Uh oh!

arkadeepsen commented Apr 14, 2026

Uh oh!

arkadeepsen commented Apr 14, 2026

Uh oh!

arkadeepsen commented Apr 14, 2026

Uh oh!

openshift-ci Bot commented Apr 14, 2026

Uh oh!

arkadeepsen commented Apr 14, 2026

Uh oh!

openshift-ci Bot commented Apr 14, 2026

Uh oh!

jluhrsen commented Apr 15, 2026

Uh oh!

openshift-ci Bot commented Apr 15, 2026

Uh oh!

jluhrsen commented Apr 15, 2026

Uh oh!

arkadeepsen commented Apr 15, 2026

Uh oh!

openshift-ci Bot commented Apr 15, 2026

Uh oh!

arkadeepsen commented Apr 15, 2026

Uh oh!

openshift-ci-robot commented Apr 15, 2026

Uh oh!

arkadeepsen commented Apr 15, 2026

Uh oh!

openshift-ci-robot commented Apr 15, 2026

Uh oh!

Uh oh!

openshift-ci-robot commented Apr 15, 2026

📑 Description

`.coderabbit.yml` has unrecognized properties

openshift-ci Bot commented Apr 10, 2026 •

edited

Loading