[release-4.20] OCPBUGS-81477: node: fix serviceUpdateNotNeeded nil pointer comparison by pliurh · Pull Request #3099 · openshift/ovn-kubernetes

pliurh · 2026-03-31T08:35:08Z

serviceUpdateNotNeeded() used explicit nil guards before dereferencing InternalTrafficPolicy and AllocateLoadBalancerNodePorts. When both old and new are nil (all non-LoadBalancer services), (nil != nil && ...) evaluates to false, incorrectly indicating an update is needed.

Use reflect.DeepEqual on the pointer directly, which handles nil == nil.

(cherry picked from commit 40caf4c) (cherry picked from commit 581bfde)

This is a clean manual cherry-pick.

📑 Description

Fixes #

Additional Information for reviewers

✅ Checks

My code requires changes to the documentation
if so, I have updated the documentation as required
My code requires tests
if so, I have added and/or updated the tests as required
All the tests have passed in the CI

How to verify it

serviceUpdateNotNeeded() used explicit nil guards before dereferencing InternalTrafficPolicy and AllocateLoadBalancerNodePorts. When both old and new are nil (all non-LoadBalancer services), (nil != nil && ...) evaluates to false, incorrectly indicating an update is needed. Use reflect.DeepEqual on the pointer directly, which handles nil == nil. Signed-off-by: Peng Liu <pliu@redhat.com> (cherry picked from commit 40caf4c) (cherry picked from commit 581bfde)

openshift-ci-robot · 2026-03-31T08:35:16Z

@pliurh: This pull request references Jira Issue OCPBUGS-81477, which is invalid:

release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
expected dependent Jira Issue OCPBUGS-81475 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is New instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

serviceUpdateNotNeeded() used explicit nil guards before dereferencing InternalTrafficPolicy and AllocateLoadBalancerNodePorts. When both old and new are nil (all non-LoadBalancer services), (nil != nil && ...) evaluates to false, incorrectly indicating an update is needed.

Use reflect.DeepEqual on the pointer directly, which handles nil == nil.

(cherry picked from commit 40caf4c) (cherry picked from commit 581bfde)

📑 Description

Fixes #

Additional Information for reviewers

✅ Checks

My code requires changes to the documentation

if so, I have updated the documentation as required

My code requires tests

if so, I have added and/or updated the tests as required

All the tests have passed in the CI

How to verify it

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

coderabbitai · 2026-03-31T08:35:17Z

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yml

Review profile: CHILL

Plan: Pro

Run ID: 07cfd23b-aeb9-4bf7-957b-324df8ad2d5e

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

Note

`.coderabbit.yml` has unrecognized properties

CodeRabbit is using all valid settings from your configuration. Unrecognized properties (listed below) have been ignored and may indicate typos or deprecated fields that can be removed.

⚠️ Parsing warnings (1)

Validation error: Unrecognized key(s) in object: 'paths_ignore'

⚙️ Configuration instructions

Please see the configuration documentation for more information.
You can also validate your configuration using the online YAML validator.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

pliurh · 2026-04-01T02:55:13Z

/retest-required

jcaamano · 2026-04-10T14:14:23Z

/lgtm
/approve
/label backport-risk-assessed

openshift-ci · 2026-04-10T14:15:10Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jcaamano, pliurh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [jcaamano]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

SachinNinganure · 2026-04-13T17:35:42Z

Scale test details
basic test:
API server restarts that cause service rule re-evaluation
Multiple service/pod configurations that would amplify the bug
verified no TCP RST packet floods
3 different tests were run with 100/160/480 pods and 20/35/105 services

Verified the scale and additional scenarios on the cluster with fix ; - The reflect.DeepEqual() fix in OVN-Kubernetes successfully prevents TCP RST storms

No RST packets generated during OVN pod restarts (trigger1)
No RST packets generated during API restarts (trigger2)

additionally conducted Service Resilience Validation Test which is API Restart Service Preservation Test
OVN watch loss and service resync events
Heavy traffic during serviceUpdateNotNeeded() timing windows
Customer-scale service configuration (16 external IPs, 4 TCP ports 10.157.2.10 through 10.157.2.25 and 80, 443, 15021, 30381 ports)
50+ external IPs and multiple TCP ports (as per cu setup)
Traffic Injection: Heavy concurrent connections during API restart window

1>All 16 external IPs maintained service preservation
2>0 service-specific RST packets seen
3>75-second downtime handled successfully(api outage)

SachinNinganure · 2026-04-13T17:35:58Z

/verified by @SachinNinganure

openshift-ci-robot · 2026-04-13T17:36:16Z

@SachinNinganure: This PR has been marked as verified by @SachinNinganure.

Details

In response to this:

/verified by @SachinNinganure

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

arkadeepsen · 2026-04-14T07:16:48Z

/jira refresh

openshift-ci-robot · 2026-04-14T07:16:53Z

@arkadeepsen: This pull request references Jira Issue OCPBUGS-81477, which is invalid:

release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

arkadeepsen · 2026-04-14T07:17:40Z

/jira refresh

arkadeepsen · 2026-04-14T09:23:49Z

/retest-required

arkadeepsen · 2026-04-14T09:50:31Z

/retest-required

deepsm007 · 2026-04-14T10:59:02Z

/test e2e-aws-ovn-serial

arkadeepsen · 2026-04-14T11:23:21Z

/retest-required

arkadeepsen · 2026-04-14T12:10:51Z

/payload 4.20 ci blocking
/payload 4.20 nightly blocking

openshift-ci · 2026-04-14T12:10:55Z

@arkadeepsen: trigger 5 job(s) of type blocking for the ci release of OCP 4.20

periodic-ci-openshift-release-main-ci-4.20-upgrade-from-stable-4.19-e2e-aws-ovn-upgrade
periodic-ci-openshift-release-main-ci-4.20-upgrade-from-stable-4.19-e2e-azure-ovn-upgrade
periodic-ci-openshift-release-main-ci-4.20-e2e-gcp-ovn-upgrade
periodic-ci-openshift-hypershift-release-4.20-periodics-e2e-aks
periodic-ci-openshift-hypershift-release-4.20-periodics-e2e-aws-ovn

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/fb2e4020-37fa-11f1-8b6f-25ef4e435303-0

trigger 9 job(s) of type blocking for the nightly release of OCP 4.20

periodic-ci-openshift-release-main-nightly-4.20-e2e-aws-ovn-serial-1of2
periodic-ci-openshift-release-main-nightly-4.20-e2e-aws-ovn-serial-2of2
periodic-ci-openshift-release-main-ci-4.20-e2e-aws-upgrade-ovn-single-node
periodic-ci-openshift-release-main-nightly-4.20-e2e-aws-ovn-upgrade-fips
periodic-ci-openshift-release-main-ci-4.20-e2e-azure-ovn-upgrade
periodic-ci-openshift-release-main-ci-4.20-upgrade-from-stable-4.19-e2e-gcp-ovn-rt-upgrade
periodic-ci-openshift-hypershift-release-4.20-periodics-e2e-aws-ovn-conformance
periodic-ci-openshift-release-main-nightly-4.20-e2e-metal-ipi-ovn-bm
periodic-ci-openshift-release-main-nightly-4.20-e2e-metal-ipi-ovn-ipv6

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/fb2e4020-37fa-11f1-8b6f-25ef4e435303-1

arkadeepsen · 2026-04-14T13:04:29Z

/retest-required

arkadeepsen · 2026-04-14T14:30:05Z

/payload-job periodic-ci-openshift-hypershift-release-4.20-periodics-e2e-aks
/payload-job periodic-ci-openshift-release-main-ci-4.20-e2e-aws-upgrade-ovn-single-node
/payload-job periodic-ci-openshift-hypershift-release-4.20-periodics-e2e-aws-ovn-conformance

openshift-ci · 2026-04-14T14:30:08Z

@arkadeepsen: trigger 3 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

periodic-ci-openshift-hypershift-release-4.20-periodics-e2e-aks
periodic-ci-openshift-release-main-ci-4.20-e2e-aws-upgrade-ovn-single-node
periodic-ci-openshift-hypershift-release-4.20-periodics-e2e-aws-ovn-conformance

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/6e677e90-380e-11f1-9f56-3b4ac4f47013-0

arkadeepsen · 2026-04-14T15:22:08Z

e2e-metal-ipi-ovn-dualstack-bgp failed on the step to release the lease after the e2e tests passed. Retrying the test one more time to get a green signal.

/test e2e-metal-ipi-ovn-dualstack-bgp

arkadeepsen · 2026-04-14T15:31:59Z

/test qe-perfscale-payload-control-plane-6nodes

arkadeepsen · 2026-04-14T15:38:16Z

/test e2e-aws-ovn-serial

arkadeepsen · 2026-04-14T15:47:12Z

/test qe-perfscale-payload-control-plane-6nodes

arkadeepsen · 2026-04-14T15:50:10Z

/payload-job periodic-ci-openshift-hypershift-release-4.20-periodics-e2e-aks
/payload-job periodic-ci-openshift-hypershift-release-4.20-periodics-e2e-aws-ovn-conformance

openshift-ci · 2026-04-14T15:50:15Z

@arkadeepsen: trigger 2 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

periodic-ci-openshift-hypershift-release-4.20-periodics-e2e-aks
periodic-ci-openshift-hypershift-release-4.20-periodics-e2e-aws-ovn-conformance

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/9f0af7b0-3819-11f1-8c9b-cdc0e73c43b9-0

jluhrsen · 2026-04-14T23:59:37Z

/retest-required

jluhrsen · 2026-04-15T00:00:00Z

/payload-job periodic-ci-openshift-hypershift-release-4.20-periodics-e2e-aks

openshift-ci · 2026-04-15T00:00:04Z

@jluhrsen: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

periodic-ci-openshift-hypershift-release-4.20-periodics-e2e-aks

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/0ca4bc40-385e-11f1-9eea-2ff3583c91f6-0

arkadeepsen · 2026-04-15T03:01:28Z

/retest-required

openshift-ci · 2026-04-15T03:49:37Z

@pliurh: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/security	`2a5bf31`	link	false	`/test security`
ci/prow/qe-perfscale-payload-control-plane-6nodes	`2a5bf31`	link	true	`/test qe-perfscale-payload-control-plane-6nodes`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

arkadeepsen · 2026-04-15T03:57:38Z

/payload-job periodic-ci-openshift-release-main-ci-4.20-e2e-aws-upgrade-ovn-single-node
/payload-job periodic-ci-openshift-release-main-ci-4.20-e2e-azure-ovn-upgrade
/payload-job periodic-ci-openshift-release-main-ci-4.20-upgrade-from-stable-4.19-e2e-azure-ovn-upgrade
/payload-job periodic-ci-openshift-release-main-ci-4.20-e2e-gcp-ovn-upgrade

openshift-ci · 2026-04-15T03:57:42Z

@arkadeepsen: trigger 4 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

periodic-ci-openshift-release-main-ci-4.20-e2e-aws-upgrade-ovn-single-node
periodic-ci-openshift-release-main-ci-4.20-e2e-azure-ovn-upgrade
periodic-ci-openshift-release-main-ci-4.20-upgrade-from-stable-4.19-e2e-azure-ovn-upgrade
periodic-ci-openshift-release-main-ci-4.20-e2e-gcp-ovn-upgrade

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/3f0c9fb0-387f-11f1-9605-ee11d7e1b93b-0

arkadeepsen · 2026-04-15T05:41:54Z

/payload-job periodic-ci-openshift-release-main-ci-4.20-e2e-azure-ovn-upgrade

openshift-ci · 2026-04-15T05:41:58Z

@arkadeepsen: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

periodic-ci-openshift-release-main-ci-4.20-e2e-azure-ovn-upgrade

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/d028b930-388d-11f1-99b0-4601a89ccd18-0

arkadeepsen · 2026-04-15T06:04:59Z

/test qe-perfscale-payload-control-plane-6nodes

arkadeepsen · 2026-04-15T06:39:27Z

qe-perfscale-payload-control-plane-6nodes is failing due to auth error as there is network lock-down on the account. Slack thread: https://redhat-internal.slack.com/archives/CH76YSYSC/p1776234777981109?thread_ts=1776229952.898689&cid=CH76YSYSC

jcaamano · 2026-04-15T08:48:10Z

/override ci/prow/qe-perfscale-payload-control-plane-6nodes

openshift-ci · 2026-04-15T08:48:32Z

@jcaamano: Overrode contexts on behalf of jcaamano: ci/prow/qe-perfscale-payload-control-plane-6nodes

Details

In response to this:

/override ci/prow/qe-perfscale-payload-control-plane-6nodes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-ci-robot · 2026-04-15T08:51:07Z

@pliurh: Jira Issue Verification Checks: Jira Issue OCPBUGS-81477
✔️ This pull request was pre-merge verified.
✔️ All associated pull requests have merged.
✔️ All associated, merged pull requests were pre-merge verified.

Jira Issue OCPBUGS-81477 has been moved to the MODIFIED state and will move to the VERIFIED state when the change is available in an accepted nightly payload. 🕓

Details

In response to this:

serviceUpdateNotNeeded() used explicit nil guards before dereferencing InternalTrafficPolicy and AllocateLoadBalancerNodePorts. When both old and new are nil (all non-LoadBalancer services), (nil != nil && ...) evaluates to false, incorrectly indicating an update is needed.

Use reflect.DeepEqual on the pointer directly, which handles nil == nil.

(cherry picked from commit 40caf4c) (cherry picked from commit 581bfde)

This is a clean manual cherry-pick.

📑 Description

Fixes #

Additional Information for reviewers

✅ Checks

My code requires changes to the documentation

if so, I have updated the documentation as required

My code requires tests

if so, I have added and/or updated the tests as required

All the tests have passed in the CI

How to verify it

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci Bot requested review from martinkennelly and tssurya March 31, 2026 08:38

openshift-ci Bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Apr 10, 2026

openshift-ci Bot assigned anuragthehatter, asood-rh, barbora137, jechen0648, mffiedler, rbbratta, weliang1 and jcaamano Apr 10, 2026

openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Apr 10, 2026

openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 10, 2026

openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Apr 13, 2026

openshift-ci-robot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Apr 14, 2026

openshift-merge-bot Bot merged commit b8b321e into openshift:release-4.20 Apr 15, 2026
29 of 30 checks passed

Conversation

pliurh commented Mar 31, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📑 Description

Additional Information for reviewers

✅ Checks

How to verify it

Uh oh!

openshift-ci-robot commented Mar 31, 2026

📑 Description

Additional Information for reviewers

✅ Checks

How to verify it

Uh oh!

coderabbitai Bot commented Mar 31, 2026

Review skipped

.coderabbit.yml has unrecognized properties

Uh oh!

pliurh commented Apr 1, 2026

Uh oh!

jcaamano commented Apr 10, 2026

Uh oh!

openshift-ci Bot commented Apr 10, 2026

Uh oh!

SachinNinganure commented Apr 13, 2026

Uh oh!

SachinNinganure commented Apr 13, 2026

Uh oh!

openshift-ci-robot commented Apr 13, 2026

Uh oh!

arkadeepsen commented Apr 14, 2026

Uh oh!

openshift-ci-robot commented Apr 14, 2026

Uh oh!

arkadeepsen commented Apr 14, 2026

Uh oh!

arkadeepsen commented Apr 14, 2026

Uh oh!

arkadeepsen commented Apr 14, 2026

Uh oh!

deepsm007 commented Apr 14, 2026

Uh oh!

arkadeepsen commented Apr 14, 2026

Uh oh!

arkadeepsen commented Apr 14, 2026

Uh oh!

openshift-ci Bot commented Apr 14, 2026

Uh oh!

arkadeepsen commented Apr 14, 2026

Uh oh!

arkadeepsen commented Apr 14, 2026

Uh oh!

openshift-ci Bot commented Apr 14, 2026

Uh oh!

arkadeepsen commented Apr 14, 2026

Uh oh!

arkadeepsen commented Apr 14, 2026

Uh oh!

arkadeepsen commented Apr 14, 2026

Uh oh!

arkadeepsen commented Apr 14, 2026

Uh oh!

arkadeepsen commented Apr 14, 2026

Uh oh!

openshift-ci Bot commented Apr 14, 2026

Uh oh!

jluhrsen commented Apr 14, 2026

Uh oh!

jluhrsen commented Apr 15, 2026

Uh oh!

openshift-ci Bot commented Apr 15, 2026

Uh oh!

arkadeepsen commented Apr 15, 2026

Uh oh!

openshift-ci Bot commented Apr 15, 2026

Uh oh!

arkadeepsen commented Apr 15, 2026

Uh oh!

openshift-ci Bot commented Apr 15, 2026

Uh oh!

pliurh commented Mar 31, 2026 •

edited

Loading

`.coderabbit.yml` has unrecognized properties