OCPBUGS-84636, CORENET-6055: [release-4.12] Dockerfile: Unpin OVN and consume the latest from FDP#3075
OCPBUGS-84636, CORENET-6055: [release-4.12] Dockerfile: Unpin OVN and consume the latest from FDP#3075igsilya wants to merge 1 commit intoopenshift:release-4.12from
Conversation
OVN-Kubernetes is always lagging behind on the version of OVN it pins. This is causing a lot of trouble with keeping up with bug fixes and especially CVE fixes on older branches, resulting in scanners flagging this image with poor security grades and much longer time for bug fixes to be delivered to customers as the PR backporting process can take weeks or even months. Removing the pin, so every time the new build is released in FDP, it automatically gets into versions of OpneShift that use it. There is a pre-release testing process in place between FDP and OCP QE that ensures the required test coverage before the new build is released through FDP. Signed-off-by: Ilya Maximets <i.maximets@ovn.org>
|
@igsilya: This pull request references CORENET-6055 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.12.z" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Important Review skippedAuto reviews are limited based on label configuration. 🚫 Review skipped — only excluded labels are configured. (1)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
/retest-required |
|
/test e2e-gcp-ovn |
|
@igsilya: This pull request references CORENET-6055 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.12.z" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
This PR doesn't change anything, since /test 4.12-upgrade-from-stable-4.11-e2e-aws-ovn-upgrade |
|
/test 4.12-upgrade-from-stable-4.11-e2e-aws-ovn-upgrade |
tssurya
left a comment
There was a problem hiding this comment.
/lgtm
/label backport-risk-assessed
there is always risk with consuming unpinned versions - but the team has done everything possible for pre-merge testing signal setup
PS: wow yum install!!
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: igsilya, tssurya The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest-required |
|
/retest-required |
|
/jira cherry-pick OCPBUGS-84635 |
|
@igsilya: Jira Issue OCPBUGS-84635 has been cloned as Jira Issue OCPBUGS-84636. Will retitle bug to link to clone. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@igsilya: This pull request references Jira Issue OCPBUGS-84636, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@igsilya: This pull request references Jira Issue OCPBUGS-84636, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. This pull request references CORENET-6055 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.12.z" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
The only verification required here is that the images are still building, since all the RPM versions stay the same, and CI verified that. The fmt/lint/unit tests are borked, but just in case |
|
@igsilya: This PR has been marked as verified by DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/jira refresh |
|
@igsilya: This pull request references Jira Issue OCPBUGS-84636, which is valid. The bug has been moved to the POST state. 7 validation(s) were run on this bug
This pull request references CORENET-6055 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.12.z" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@igsilya: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
OVN-Kubernetes is always lagging behind on the version of OVN it pins. This is causing a lot of trouble with keeping up with bug fixes and especially CVE fixes on older branches, resulting in scanners flagging this image with poor security grades and much longer time for bug fixes to be delivered to customers as the PR backporting process can take weeks or even months.
Removing the pin, so every time the new build is released in FDP, it automatically gets into versions of OpneShift that use it. There is a pre-release testing process in place between FDP and OCP QE that ensures the required test coverage before the new build is released through FDP.
This PR will allow picking up newer ones automatically as soon as they are released in the future. Major version upgrades still require a separate PR.
Note however, that this PR doesn't really change anything right now, as
23.06.4-26.el8fdpis the latest available version.Manual cherry pick of the change from 4.13: #3074