CORENET-6168: remove two broken tests from the blocking list by jluhrsen · Pull Request #3043 · openshift/ovn-kubernetes

jluhrsen · 2026-03-07T01:51:22Z

the k8s bump to 1.35 has changed the error format [0] these test cases are expecting so these cases will fail until the fix upstream [1] is merged and makes it downstream. after that we can revert this commit so they will be blocking again

[0] kubernetes/kubernetes@a674687
[1] ovn-kubernetes/ovn-kubernetes#6077

📑 Description

Fixes #

Additional Information for reviewers

✅ Checks

My code requires changes to the documentation
if so, I have updated the documentation as required
My code requires tests
if so, I have added and/or updated the tests as required
All the tests have passed in the CI

How to verify it

Summary by CodeRabbit

Tests
- Removed blocking test entries related to Layer2 UDN subnet configuration validation.

openshift-ci-robot · 2026-03-07T01:51:26Z

@jluhrsen: This pull request references CORENET-6168 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set.

Details

In response to this:

the k8s bump to 1.35 has changed the error format [0] these test cases are expecting so these cases will fail until the fix upstream [1] is merged and makes it downstream. after that we can revert this commit so they will be blocking again

[0] kubernetes/kubernetes@a674687
[1] ovn-kubernetes/ovn-kubernetes#6077

📑 Description

Fixes #

Additional Information for reviewers

✅ Checks

My code requires changes to the documentation

if so, I have updated the documentation as required

My code requires tests

if so, I have added and/or updated the tests as required

All the tests have passed in the CI

How to verify it

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

jluhrsen · 2026-03-07T18:54:47Z

/test e2e-aws-ovn-edge-zones
/test e2e-aws-ovn-fdp-qe
/test e2e-aws-ovn-serial
/test e2e-metal-ipi-ovn-dualstack
/test e2e-metal-ipi-ovn-dualstack-bgp
/test e2e-metal-ipi-ovn-dualstack-bgp-local-gw

jluhrsen · 2026-03-08T00:20:05Z

/retest-required

@jcaamano can you override any failed tests here. this PR is removing two test cases from the list of blocking cases and has nothing to do with any e2e job failures.

/hold
we don't want to merge this until the current d/s merge is in place, but if we can get all the other labels in place now I can remove my hold as soon as that happens

/verified by jamo

openshift-ci-robot · 2026-03-08T00:20:15Z

@jluhrsen: This PR has been marked as verified by jamo.

Details

In response to this:

/retest-required

@jcaamano can you override any failed tests here. this PR is removing two test cases from the list of blocking cases and has nothing to do with any e2e job failures.

/hold
we don't want to merge this until the current d/s merge is in place, but if we can get all the other labels in place now I can remove my hold as soon as that happens

/verified by jamo

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

pperiyasamy · 2026-03-09T10:11:25Z

/test e2e-metal-ipi-ovn-dualstack-bgp
/test e2e-aws-ovn-serial
/test e2e-metal-ipi-ovn-dualstack

jcaamano · 2026-03-09T17:00:16Z

/approve
/lgtm

openshift-ci · 2026-03-09T17:16:50Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jcaamano, jluhrsen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [jcaamano]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

jcaamano · 2026-03-09T19:05:58Z

/override ci/prow/qe-perfscale-payload-control-plane-6nodes
associated thread: https://redhat-internal.slack.com/archives/C020CKMP6CT/p1771508205301039?thread_ts=1771101156.062779&cid=C020CKMP6CT and https://redhat-internal.slack.com/archives/GQ0CU2623/p1771848596455029?thread_ts=1771338827.722999&cid=GQ0CU2623
plausible fix: kube-burner/kube-burner-ocp#399

openshift-ci · 2026-03-09T19:06:47Z

@jcaamano: Overrode contexts on behalf of jcaamano: ci/prow/qe-perfscale-payload-control-plane-6nodes

Details

In response to this:

/override ci/prow/qe-perfscale-payload-control-plane-6nodes
associated thread: https://redhat-internal.slack.com/archives/C020CKMP6CT/p1771508205301039?thread_ts=1771101156.062779&cid=C020CKMP6CT and https://redhat-internal.slack.com/archives/GQ0CU2623/p1771848596455029?thread_ts=1771338827.722999&cid=GQ0CU2623
plausible fix: kube-burner/kube-burner-ocp#399

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

jcaamano · 2026-03-10T09:11:26Z

/override ci/prow/e2e-metal-ipi-ovn-dualstack
/override ci/prow/e2e-metal-ipi-ovn-dualstack-bgp
/override ci/prow/e2e-metal-ipi-ovn-dualstack-bgp-local-gw

https://issues.redhat.com/browse/OCPBUGS-78085

openshift-ci · 2026-03-10T09:11:45Z

@jcaamano: Overrode contexts on behalf of jcaamano: ci/prow/e2e-metal-ipi-ovn-dualstack, ci/prow/e2e-metal-ipi-ovn-dualstack-bgp, ci/prow/e2e-metal-ipi-ovn-dualstack-bgp-local-gw

Details

In response to this:

/override ci/prow/e2e-metal-ipi-ovn-dualstack
/override ci/prow/e2e-metal-ipi-ovn-dualstack-bgp
/override ci/prow/e2e-metal-ipi-ovn-dualstack-bgp-local-gw

https://issues.redhat.com/browse/OCPBUGS-78085

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

pperiyasamy · 2026-03-23T08:35:18Z

/hold cancel

pperiyasamy · 2026-03-23T17:14:47Z

/hold

pperiyasamy · 2026-03-23T17:17:54Z

@jluhrsen it looks like we may also skip running IPv6 tests as well.

: [Feature:NetworkSegmentation][ovn-kubernetes-ote][sig-network] Network Segmentation: Preconfigured Layer2 UDN unmasked reserved / infrastructure subnets are not allowed Layer2 with unmasked IPv6 reserved subnets [Suite:openshift/conformance/parallel] 
: [Feature:NetworkSegmentation][ovn-kubernetes-ote][sig-network] Network Segmentation: Preconfigured Layer2 UDN unmasked reserved / infrastructure subnets are not allowed Layer2 with unmasked IPv6 infrastructure subnets [Suite:openshift/conformance/parallel]

https://prow.ci.openshift.org/view/gs/test-platform-results/logs/multi-pr-openshift-ovn-kubernetes-2975-openshift-origin-30560-e2e-metal-ipi-ovn-dualstack-bgp-local-gw-techpreview-frr-next/2036050187587162112

can you take a look ?

jluhrsen · 2026-03-23T21:28:36Z

@jluhrsen it looks like we may also skip running IPv6 tests as well.
: [Feature:NetworkSegmentation][ovn-kubernetes-ote][sig-network] Network Segmentation: Preconfigured Layer2 UDN unmasked reserved / infrastructure subnets are not allowed Layer2 with unmasked IPv6 reserved subnets [Suite:openshift/conformance/parallel] 
: [Feature:NetworkSegmentation][ovn-kubernetes-ote][sig-network] Network Segmentation: Preconfigured Layer2 UDN unmasked reserved / infrastructure subnets are not allowed Layer2 with unmasked IPv6 infrastructure subnets [Suite:openshift/conformance/parallel] 
https://prow.ci.openshift.org/view/gs/test-platform-results/logs/multi-pr-openshift-ovn-kubernetes-2975-openshift-origin-30560-e2e-metal-ipi-ovn-dualstack-bgp-local-gw-techpreview-frr-next/2036050187587162112

can you take a look ?

I think we need this upstream PR to solve this one. I didn't push on it hard enough yet I guess. will try to get it moved along.

the k8s bump to 1.35 has changed the error format [0] these test cases are expecting so these cases will fail until the fix upstream [1] is merged and makes it downstream. after that we can revert this commit so they will be blocking again [0] kubernetes/kubernetes@a674687 [1] ovn-kubernetes/ovn-kubernetes#6077 Signed-off-by: Jamo Luhrsen <jluhrsen@gmail.com>

openshift-ci · 2026-03-23T22:07:57Z

New changes are detected. LGTM label has been removed.

jluhrsen · 2026-03-23T22:09:03Z

@jluhrsen it looks like we may also skip running IPv6 tests as well.
: [Feature:NetworkSegmentation][ovn-kubernetes-ote][sig-network] Network Segmentation: Preconfigured Layer2 UDN unmasked reserved / infrastructure subnets are not allowed Layer2 with unmasked IPv6 reserved subnets [Suite:openshift/conformance/parallel] 
: [Feature:NetworkSegmentation][ovn-kubernetes-ote][sig-network] Network Segmentation: Preconfigured Layer2 UDN unmasked reserved / infrastructure subnets are not allowed Layer2 with unmasked IPv6 infrastructure subnets [Suite:openshift/conformance/parallel] 
https://prow.ci.openshift.org/view/gs/test-platform-results/logs/multi-pr-openshift-ovn-kubernetes-2975-openshift-origin-30560-e2e-metal-ipi-ovn-dualstack-bgp-local-gw-techpreview-frr-next/2036050187587162112
can you take a look ?
I think we need this upstream PR to solve this one. I didn't push on it hard enough yet I guess. will try to get it moved along.

oh, I see what you mean. yes, I just updated this PR to exclude those.

Let's get this thing merged asap please.

@jcaamano @tssurya could you please label this?

coderabbitai · 2026-03-23T22:10:35Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yml

Review profile: CHILL

Plan: Pro

Run ID: 21f2f8fd-c9bc-463e-9c60-f7b015297bf6

📥 Commits

Reviewing files that changed from the base of the PR and between 0516832 and 9adab4d.

📒 Files selected for processing (1)

openshift/test/blocking_tests.go

💤 Files with no reviewable changes (1)

openshift/test/blocking_tests.go

Walkthrough

Four BlockingTests entries related to unmasked Layer2 UDN subnet validation are removed from the test suite. The entries covered IPv4 and IPv6 infrastructure and reserved subnet scenarios, with no other code modifications.

Changes

Cohort / File(s)	Summary
Blocking Tests Cleanup `openshift/test/blocking_tests.go`	Removed 4 string entries from the `BlockingTests` slice pertaining to Layer2 UDN unmasked reserved and infrastructure subnet validation for both IPv4 and IPv6 address families.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 Four test blockers, now set free,
Subnet checks no longer be,
Layer2 rules fade away,
Cleaner tests greet the day! ✨

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Title check	⚠️ Warning	The PR title states 'remove two broken tests' but the summary shows four test entries were removed (IPv4 and IPv6 variants for infrastructure and reserved subnets).	Update the title to accurately reflect that four test cases were removed, or clarify that two distinct test scenarios (each with variants) were excluded from the blocking list.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

openshift-ci-robot · 2026-03-23T22:10:59Z

@jluhrsen: This pull request references CORENET-6168 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set.

Details

In response to this:

the k8s bump to 1.35 has changed the error format [0] these test cases are expecting so these cases will fail until the fix upstream [1] is merged and makes it downstream. after that we can revert this commit so they will be blocking again

[0] kubernetes/kubernetes@a674687
[1] ovn-kubernetes/ovn-kubernetes#6077

📑 Description

Fixes #

Additional Information for reviewers

✅ Checks

My code requires changes to the documentation

if so, I have updated the documentation as required

My code requires tests

if so, I have added and/or updated the tests as required

All the tests have passed in the CI

How to verify it

Summary by CodeRabbit

Tests

Removed blocking test entries related to Layer2 UDN subnet configuration validation.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

jluhrsen · 2026-03-23T22:22:49Z

/hold cancel

tssurya · 2026-03-23T23:58:31Z

/hold

I don't understand why we are doing a downstream specific PR
I thought we need to fix this upstream? and doesn't the kube rebase 1.35 then solve this?

meinali566 · 2026-03-24T02:45:31Z

/hold

I don't understand why we are doing a downstream specific PR I thought we need to fix this upstream? and doesn't the kube rebase 1.35 then solve this?

@jluhrsen right. upstream kube rebase 1.35 has merged and fixed this issue in rebase PR. I left comment in your u/s PR.

openshift-ci · 2026-03-24T05:39:04Z

@jluhrsen: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/security	`9adab4d`	link	false	`/test security`
ci/prow/e2e-metal-ipi-ovn-dualstack-bgp	`9adab4d`	link	true	`/test e2e-metal-ipi-ovn-dualstack-bgp`
ci/prow/e2e-metal-ipi-ovn-dualstack	`9adab4d`	link	true	`/test e2e-metal-ipi-ovn-dualstack`
ci/prow/e2e-aws-ovn-upgrade	`9adab4d`	link	true	`/test e2e-aws-ovn-upgrade`
ci/prow/e2e-aws-ovn-hypershift	`9adab4d`	link	true	`/test e2e-aws-ovn-hypershift`
ci/prow/e2e-metal-ipi-ovn-dualstack-bgp-local-gw	`9adab4d`	link	true	`/test e2e-metal-ipi-ovn-dualstack-bgp-local-gw`
ci/prow/qe-perfscale-payload-control-plane-6nodes	`9adab4d`	link	true	`/test qe-perfscale-payload-control-plane-6nodes`
ci/prow/e2e-aws-ovn-rhcos10-techpreview	`9adab4d`	link	false	`/test e2e-aws-ovn-rhcos10-techpreview`
ci/prow/e2e-aws-ovn-edge-zones	`9adab4d`	link	true	`/test e2e-aws-ovn-edge-zones`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

jluhrsen · 2026-03-24T16:36:55Z

/hold

I don't understand why we are doing a downstream specific PR I thought we need to fix this upstream? and doesn't the kube rebase 1.35 then solve this?

@tssurya , it was so that we can maybe finally hopefully turn OTE on so we can catch issues on d/s merge PRs if/when they come instead of finding them later and still not able to turn our OTE on. I have been in a waiting pattern for months to get the origin PR in because of one thing after another.

yes, upstream needs to fix it. I had my own PR I asked to get in 3 weeks ago and didn't find traction. but now I see the
upstream rebase finally landed which also has that fix, so will close mine.

So, I suppose now that the upstream rebase is in our next d/s merge will work? I guess we'll see.

jluhrsen · 2026-03-24T16:37:37Z

/close
this will make it in with the d/s merge that follows the current open d/s merge

openshift-ci · 2026-03-24T16:38:22Z

@jluhrsen: Closed this PR.

Details

In response to this:

/close
this will make it in with the d/s merge that follows the current open d/s merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Mar 7, 2026

jluhrsen mentioned this pull request Mar 7, 2026

CORENET-6168: Add ovn tests extension openshift/origin#30560

Merged

openshift-ci Bot requested review from jcaamano and tssurya March 7, 2026 01:52

openshift-ci Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 8, 2026

openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Mar 8, 2026

openshift-ci Bot assigned jcaamano Mar 9, 2026

openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Mar 9, 2026

openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 9, 2026

openshift-ci Bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 23, 2026

openshift-ci Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 23, 2026

jluhrsen force-pushed the remove-2-netseg-from-blocking branch from 2faea6f to 9adab4d Compare March 23, 2026 22:07

openshift-ci-robot removed the verified Signifies that the PR passed pre-merge verification criteria label Mar 23, 2026

openshift-ci Bot removed the lgtm Indicates that a PR is ready to be merged. label Mar 23, 2026

openshift-ci Bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 23, 2026

jluhrsen mentioned this pull request Mar 23, 2026

OCPBUGS-77510: DownStream Merge [03-23-2026] #3078

Closed

5 tasks

openshift-ci Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 23, 2026

openshift-ci Bot closed this Mar 24, 2026

Conversation

jluhrsen commented Mar 7, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📑 Description

Additional Information for reviewers

✅ Checks

How to verify it

Summary by CodeRabbit

Uh oh!

openshift-ci-robot commented Mar 7, 2026 • edited by openshift-ci Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📑 Description

Additional Information for reviewers

✅ Checks

How to verify it

Uh oh!

jluhrsen commented Mar 7, 2026

Uh oh!

jluhrsen commented Mar 8, 2026

Uh oh!

openshift-ci-robot commented Mar 8, 2026

Uh oh!

pperiyasamy commented Mar 9, 2026

Uh oh!

jcaamano commented Mar 9, 2026

Uh oh!

openshift-ci Bot commented Mar 9, 2026

Uh oh!

jcaamano commented Mar 9, 2026

Uh oh!

openshift-ci Bot commented Mar 9, 2026

Uh oh!

jcaamano commented Mar 10, 2026

Uh oh!

openshift-ci Bot commented Mar 10, 2026

Uh oh!

pperiyasamy commented Mar 23, 2026

Uh oh!

pperiyasamy commented Mar 23, 2026

Uh oh!

pperiyasamy commented Mar 23, 2026

Uh oh!

jluhrsen commented Mar 23, 2026

Uh oh!

openshift-ci Bot commented Mar 23, 2026

Uh oh!

jluhrsen commented Mar 23, 2026

Uh oh!

coderabbitai Bot commented Mar 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Poem

❌ Failed checks (1 warning)

Uh oh!

openshift-ci-robot commented Mar 23, 2026 • edited by openshift-ci Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📑 Description

Additional Information for reviewers

✅ Checks

How to verify it

Summary by CodeRabbit

Uh oh!

jluhrsen commented Mar 23, 2026

Uh oh!

tssurya commented Mar 23, 2026

Uh oh!

meinali566 commented Mar 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci Bot commented Mar 24, 2026

Uh oh!

jluhrsen commented Mar 24, 2026

Uh oh!

jluhrsen commented Mar 24, 2026

Uh oh!

openshift-ci Bot commented Mar 24, 2026

Uh oh!

Reviewers

jluhrsen commented Mar 7, 2026 •

edited by coderabbitai Bot

Loading

openshift-ci-robot commented Mar 7, 2026 •

edited by openshift-ci Bot

Loading

coderabbitai Bot commented Mar 23, 2026 •

edited

Loading

openshift-ci-robot commented Mar 23, 2026 •

edited by openshift-ci Bot

Loading

meinali566 commented Mar 24, 2026 •

edited

Loading