Skip to content

[release-4.16] OCPBUGS-77187: Fix conntrack reconciliation to use service port instead of endpoint port #2998

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
openshift-merge-bot merged 1 commit into from
Feb 27, 2026
Merged

[release-4.16] OCPBUGS-77187: Fix conntrack reconciliation to use service port instead of endpoint port #2998

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 21 additions & 4 deletions go-controller/pkg/node/default_node_network_controller.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1191,9 +1191,15 @@ func (nc *DefaultNodeNetworkController) reconcileConntrackUponEndpointSliceEvent
return fmt.Errorf("cannot reconcile conntrack: %v", err)
}
svc, err := nc.watchFactory.GetService(namespacedName.Namespace, namespacedName.Name)
if err != nil && !kerrors.IsNotFound(err) {
if err != nil {
if kerrors.IsNotFound(err) {
klog.V(5).Infof("Service %s/%s not found (might have been deleted) when reconciling conntrack for endpointslice %s",
namespacedName.Namespace, namespacedName.Name, oldEndpointSlice.Name)
// service is not found, likely deleted, flushing service conntrack entries will be handled at service reconciliation. No-op here.
return nil
}
return fmt.Errorf("error while retrieving service for endpointslice %s/%s when reconciling conntrack: %v",
newEndpointSlice.Namespace, newEndpointSlice.Name, err)
oldEndpointSlice.Namespace, oldEndpointSlice.Name, err)
}
for _, oldPort := range oldEndpointSlice.Ports {
if *oldPort.Protocol != kapi.ProtocolUDP { // flush conntrack only for UDP
Expand All @@ -1207,10 +1213,21 @@ func (nc *DefaultNodeNetworkController) reconcileConntrackUponEndpointSliceEvent
if newEndpointSlice != nil && util.DoesEndpointSliceContainEligibleEndpoint(newEndpointSlice, oldIPStr, *oldPort.Port, *oldPort.Protocol, svc) {
continue
}
portName := ""
if oldPort.Name != nil {
portName = *oldPort.Name
}
servicePort, err := util.FindServicePortForEndpointSlicePort(svc, portName, *oldPort.Protocol)
if err != nil {
klog.Errorf("Failed to get service port for endpoint %s: %v", oldIPStr, err)
continue
}
// upon update and delete events, flush conntrack only for UDP
if err := util.DeleteConntrackServicePort(oldIPStr, *oldPort.Port, *oldPort.Protocol,
klog.V(5).Infof("Deleting conntrack entry for endpoint %s, port %d, protocol %s", oldIPStr, servicePort.Port, *oldPort.Protocol)
if err := util.DeleteConntrackServicePort(oldIPStr, servicePort.Port, *oldPort.Protocol,
netlink.ConntrackReplyAnyIP, nil); err != nil {
klog.Errorf("Failed to delete conntrack entry for %s: %v", oldIPStr, err)
klog.Errorf("Failed to delete conntrack entry for %s port %d: %v", oldIPStr, servicePort.Port, err)
errors = append(errors, err)
}
}
}
Expand Down
Loading