Skip to content

OCPBUGS-70130: [release-4.21] Remove IC zone migration HACK code#2988

Closed
aswinsuryan wants to merge 1 commit intoopenshift:release-4.21from
aswinsuryan:backport-remove-ic-hack-4.21
Closed

OCPBUGS-70130: [release-4.21] Remove IC zone migration HACK code#2988
aswinsuryan wants to merge 1 commit intoopenshift:release-4.21from
aswinsuryan:backport-remove-ic-hack-4.21

Conversation

@aswinsuryan
Copy link
Copy Markdown
Contributor

@aswinsuryan aswinsuryan commented Feb 19, 2026 •
edited
Loading

Backport of upstream PR 5865 (commit 7d408c1). This PR addresses the missing commit from PR #2984.

Remove IC zone migration HACK code
05d024a 
Remove the temporary migration code that was added in 2023 to support
the transition to OVN Interconnect (IC) architecture. This HACK code
tracked whether remote zone nodes had completed migration using the
"k8s.ovn.org/remote-zone-migrated" annotation.

This code is no longer needed.

Changes:
- Remove OvnNodeMigratedZoneName constant and helper functions
  (SetNodeZoneMigrated, HasNodeMigratedZone, NodeMigratedZoneAnnotationChanged)
- Remove migrated field from nodeInfo struct in node_tracker.go
- Simplify isLocalZoneNode() in base_network_controller.go and egressip.go
- Remove HACK helper functions (checkOVNSBNodeLRSR, fetchLBNames, lbExists,
  portExists) and migration sync flow from default_node_network_controller.go
- Remove remote-zone-migrated annotation from webhook allowed annotations
- Update tests to remove references to the migration annotation

Assisted by Claude Opus 4.5 <noreply@anthropic.com>

Signed-off-by: Riccardo Ravaioli <rravaiol@redhat.com>
@openshift-ci-robot openshift-ci-robot added jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Feb 19, 2026
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Feb 19, 2026

@aswinsuryan: This pull request references Jira Issue OCPBUGS-70130, which is invalid:

  • expected the bug to target either version "4.21." or "openshift-4.21.", but it targets "4.22.0" instead
  • release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
  • expected Jira Issue OCPBUGS-70130 to depend on a bug targeting a version in 4.22.0 and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Backport of upstream PR 5865 (commit 7d408c1). This PR addresses the missing commit from PR #2984.

Made with Cursor

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Feb 19, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: aswinsuryan
Once this PR has been reviewed and has the lgtm label, please assign jcaamano for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Feb 19, 2026
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Feb 19, 2026

Hi @aswinsuryan. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@aswinsuryan
Copy link
Copy Markdown
Contributor Author

aswinsuryan commented Feb 19, 2026

Wrong PR

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Feb 19, 2026

@aswinsuryan: This pull request references Jira Issue OCPBUGS-70130. The bug has been updated to no longer refer to the pull request using the external bug tracker.

Details

In response to this:

Backport of upstream PR 5865 (commit 7d408c1). This PR addresses the missing commit from PR #2984.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kyrtapz kyrtapz Awaiting requested review from kyrtapz

@martinkennelly martinkennelly Awaiting requested review from martinkennelly

Assignees

No one assigned

Labels

jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@aswinsuryan @openshift-ci-robot