[release-4.20] OCPBUGS-61239: Skip node-encap-ips annotation in DPU host mode by tsorya · Pull Request #2763 · openshift/ovn-kubernetes

tsorya · 2025-09-23T21:42:45Z

[release-4.20] OCPBUGS-61239: Skip node-encap-ips annotation in DPU host mode
The node-encap-ips annotation should not be set when running in DPU host mode since the encap IP is not available on the DPU host. This prevents errors during node initialization when the encap IP cannot be determined.

Add conditional check for NodeModeDPUHost before setting encap IP annotation
Maintain existing behavior for non-DPU host modes
Fixes initialization errors in DPU host mode deployments

cherry pick from #2750
exact commit is d70e444

📑 Description

Fixes #

Additional Information for reviewers

✅ Checks

My code requires changes to the documentation
if so, I have updated the documentation as required
My code requires tests
if so, I have added and/or updated the tests as required
All the tests have passed in the CI

How to verify it

…ost mode The node-encap-ips annotation should not be set when running in DPU host mode since the encap IP is not available on the DPU host. This prevents errors during node initialization when the encap IP cannot be determined. - Add conditional check for NodeModeDPUHost before setting encap IP annotation - Maintain existing behavior for non-DPU host modes - Fixes initialization errors in DPU host mode deployments Signed-off-by: Alin Serdean <aserdean@nvidia.com>

openshift-ci-robot · 2025-09-23T21:42:51Z

@tsorya: This pull request references Jira Issue OCPBUGS-61239, which is invalid:

expected the bug to target the "4.20.0" version, but no target version was set
release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
expected Jira Issue OCPBUGS-61239 to depend on a bug targeting a version in 4.21.0 and in one of the following states: MODIFIED, ON_QA, VERIFIED, but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

[release-4.20] OCPBUGS-61239: Skip node-encap-ips annotation in DPU host mode
The node-encap-ips annotation should not be set when running in DPU host mode since the encap IP is not available on the DPU host. This prevents errors during node initialization when the encap IP cannot be determined.

Add conditional check for NodeModeDPUHost before setting encap IP annotation

Maintain existing behavior for non-DPU host modes

Fixes initialization errors in DPU host mode deployments

📑 Description

Fixes #

Additional Information for reviewers

✅ Checks

My code requires changes to the documentation

if so, I have updated the documentation as required

My code requires tests

if so, I have added and/or updated the tests as required

All the tests have passed in the CI

How to verify it

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

tsorya · 2025-09-23T21:50:28Z

/jira refresh

openshift-ci-robot · 2025-09-23T21:50:36Z

@tsorya: This pull request references Jira Issue OCPBUGS-61239, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.20.0) matches configured target version for branch (4.20.0)
bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
release note type set to "Release Note Not Required"
dependent bug Jira Issue OCPBUGS-62130 is in the state ON_QA, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
dependent Jira Issue OCPBUGS-62130 targets the "4.21.0" version, which is one of the valid target versions: 4.21.0
bug has dependents

Requesting review from QA contact:
/cc @anuragthehatter

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

tsorya · 2025-09-24T02:57:44Z

/retest-required

jcaamano · 2025-09-24T08:13:43Z

/retest

jcaamano · 2025-09-24T08:18:59Z

/payload 4.20 ci blocking
/payload 4.20 nightly blocking

openshift-ci · 2025-09-24T08:19:02Z

@jcaamano: trigger 5 job(s) of type blocking for the ci release of OCP 4.20

periodic-ci-openshift-release-master-ci-4.20-upgrade-from-stable-4.19-e2e-aws-ovn-upgrade
periodic-ci-openshift-release-master-ci-4.20-upgrade-from-stable-4.19-e2e-azure-ovn-upgrade
periodic-ci-openshift-release-master-ci-4.20-e2e-gcp-ovn-upgrade
periodic-ci-openshift-hypershift-release-4.20-periodics-e2e-aks
periodic-ci-openshift-hypershift-release-4.20-periodics-e2e-aws-ovn

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/1fa57b60-991f-11f0-8b6f-95d2ce881df9-0

trigger 10 job(s) of type blocking for the nightly release of OCP 4.20

periodic-ci-openshift-release-master-ci-4.20-e2e-aws-upgrade-ovn-single-node
periodic-ci-openshift-release-master-nightly-4.20-e2e-aws-ovn-upgrade-fips
periodic-ci-openshift-release-master-ci-4.20-e2e-azure-ovn-upgrade
periodic-ci-openshift-release-master-ci-4.20-upgrade-from-stable-4.19-e2e-gcp-ovn-rt-upgrade
periodic-ci-openshift-hypershift-release-4.20-periodics-e2e-aws-ovn-conformance
periodic-ci-openshift-release-master-nightly-4.20-e2e-aws-ovn-serial
periodic-ci-openshift-release-master-ci-4.20-e2e-aws-ovn-techpreview
periodic-ci-openshift-release-master-ci-4.20-e2e-aws-ovn-techpreview-serial
periodic-ci-openshift-release-master-nightly-4.20-e2e-metal-ipi-ovn-bm
periodic-ci-openshift-release-master-nightly-4.20-e2e-metal-ipi-ovn-ipv6

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/1fa57b60-991f-11f0-8b6f-95d2ce881df9-1

openshift-ci-robot · 2025-09-24T19:03:03Z

@tsorya: This pull request references Jira Issue OCPBUGS-61239, which is valid.

7 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.20.0) matches configured target version for branch (4.20.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
release note type set to "Release Note Not Required"
dependent bug Jira Issue OCPBUGS-62130 is in the state ON_QA, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
dependent Jira Issue OCPBUGS-62130 targets the "4.21.0" version, which is one of the valid target versions: 4.21.0
bug has dependents

Requesting review from QA contact:
/cc @anuragthehatter

Details

In response to this:

[release-4.20] OCPBUGS-61239: Skip node-encap-ips annotation in DPU host mode
The node-encap-ips annotation should not be set when running in DPU host mode since the encap IP is not available on the DPU host. This prevents errors during node initialization when the encap IP cannot be determined.

Add conditional check for NodeModeDPUHost before setting encap IP annotation

Maintain existing behavior for non-DPU host modes

Fixes initialization errors in DPU host mode deployments

cherry pick from #2750
exact commit is d70e444

📑 Description

Fixes #

Additional Information for reviewers

✅ Checks

My code requires changes to the documentation

if so, I have updated the documentation as required

My code requires tests

if so, I have added and/or updated the tests as required

All the tests have passed in the CI

How to verify it

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

tsorya · 2025-09-24T19:03:40Z

/retest-required

tsorya · 2025-09-24T23:58:57Z

/retest-required

tsorya · 2025-09-25T03:05:57Z

/retest-required

dave-tucker · 2025-09-26T13:00:52Z

/retest-required

jcaamano · 2025-09-26T14:56:20Z

/lgtm
/approve
/label backport-risk-assessed

openshift-ci · 2025-09-26T14:56:45Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jcaamano, tsorya

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [jcaamano]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

jcaamano · 2025-09-26T15:11:29Z

/override ci/prow/lint

openshift-ci · 2025-09-26T15:12:29Z

@jcaamano: Overrode contexts on behalf of jcaamano: ci/prow/lint

Details

In response to this:

/override ci/prow/lint

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

knobunc · 2025-09-26T15:16:51Z

/label staff-eng-approved

wabouhamad · 2025-09-26T16:19:47Z

/verified by @wabouhamad

openshift-ci-robot · 2025-09-26T16:19:59Z

@wabouhamad: This PR has been marked as verified by @wabouhamad.

Details

In response to this:

/verified by @wabouhamad

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci · 2025-09-26T20:17:43Z

@tsorya: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/qe-perfscale-aws-ovn-small-udn-density-l3	`0b16187`	link	false	`/test qe-perfscale-aws-ovn-small-udn-density-l3`
ci/prow/security	`0b16187`	link	false	`/test security`
ci/prow/e2e-aws-ovn-hypershift-kubevirt	`0b16187`	link	false	`/test e2e-aws-ovn-hypershift-kubevirt`
ci/prow/e2e-aws-ovn-single-node-techpreview	`0b16187`	link	false	`/test e2e-aws-ovn-single-node-techpreview`
ci/prow/e2e-aws-ovn-techpreview	`0b16187`	link	false	`/test e2e-aws-ovn-techpreview`
ci/prow/e2e-metal-ipi-ovn-dualstack-local-gateway-techpreview	`0b16187`	link	false	`/test e2e-metal-ipi-ovn-dualstack-local-gateway-techpreview`
ci/prow/e2e-openstack-ovn	`0b16187`	link	false	`/test e2e-openstack-ovn`
ci/prow/e2e-metal-ipi-ovn-techpreview	`0b16187`	link	false	`/test e2e-metal-ipi-ovn-techpreview`
ci/prow/e2e-aws-ovn-hypershift-conformance-techpreview	`0b16187`	link	false	`/test e2e-aws-ovn-hypershift-conformance-techpreview`
ci/prow/qe-perfscale-aws-ovn-small-udn-density-churn-l3	`0b16187`	link	false	`/test qe-perfscale-aws-ovn-small-udn-density-churn-l3`
ci/prow/e2e-azure-ovn-techpreview	`0b16187`	link	false	`/test e2e-azure-ovn-techpreview`
ci/prow/e2e-aws-ovn-serial-ipsec	`0b16187`	link	false	`/test e2e-aws-ovn-serial-ipsec`
ci/prow/e2e-aws-ovn-upgrade-ipsec	`0b16187`	link	false	`/test e2e-aws-ovn-upgrade-ipsec`
ci/prow/e2e-ovn-hybrid-step-registry	`0b16187`	link	false	`/test e2e-ovn-hybrid-step-registry`
ci/prow/e2e-metal-ipi-ovn-dualstack-techpreview	`0b16187`	link	false	`/test e2e-metal-ipi-ovn-dualstack-techpreview`
ci/prow/e2e-azure-ovn	`0b16187`	link	false	`/test e2e-azure-ovn`
ci/prow/lint	`0b16187`	link	true	`/test lint`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-ci-robot · 2025-09-26T20:21:00Z

@tsorya: Jira Issue Verification Checks: Jira Issue OCPBUGS-61239
✔️ This pull request was pre-merge verified.
✔️ All associated pull requests have merged.
✔️ All associated, merged pull requests were pre-merge verified.

Jira Issue OCPBUGS-61239 has been moved to the MODIFIED state and will move to the VERIFIED state when the change is available in an accepted nightly payload. 🕓

Details

In response to this:

[release-4.20] OCPBUGS-61239: Skip node-encap-ips annotation in DPU host mode
The node-encap-ips annotation should not be set when running in DPU host mode since the encap IP is not available on the DPU host. This prevents errors during node initialization when the encap IP cannot be determined.

Add conditional check for NodeModeDPUHost before setting encap IP annotation

Maintain existing behavior for non-DPU host modes

Fixes initialization errors in DPU host mode deployments

cherry pick from #2750
exact commit is d70e444

📑 Description

Fixes #

Additional Information for reviewers

✅ Checks

My code requires changes to the documentation

if so, I have updated the documentation as required

My code requires tests

if so, I have added and/or updated the tests as required

All the tests have passed in the CI

How to verify it

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-merge-robot · 2025-09-27T20:58:05Z

Fix included in accepted release 4.20.0-0.nightly-2025-09-27-153025

openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Sep 23, 2025

openshift-ci bot requested review from jcaamano and martinkennelly September 23, 2025 21:43

openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Sep 23, 2025

openshift-ci bot requested a review from anuragthehatter September 23, 2025 21:50

openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Sep 26, 2025

openshift-ci bot assigned anuragthehatter, asood-rh, barbora137, huiran0826, jechen0648, Meina-rh, mffiedler and qiowang721 Sep 26, 2025

openshift-ci bot assigned rbbratta and weliang1 Sep 26, 2025

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 26, 2025

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 26, 2025

openshift-ci bot added the staff-eng-approved Indicates a release branch PR has been approved by a staff engineer (formerly group/pillar lead). label Sep 26, 2025

openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Sep 26, 2025

openshift-merge-bot bot merged commit 74b1c90 into openshift:release-4.20 Sep 26, 2025
27 of 43 checks passed

Comments

Conversation

tsorya commented Sep 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📑 Description

Additional Information for reviewers

✅ Checks

How to verify it

Uh oh!

openshift-ci-robot commented Sep 23, 2025

📑 Description

Additional Information for reviewers

✅ Checks

How to verify it

Uh oh!

tsorya commented Sep 23, 2025

Uh oh!

openshift-ci-robot commented Sep 23, 2025

Uh oh!

tsorya commented Sep 24, 2025

Uh oh!

jcaamano commented Sep 24, 2025

Uh oh!

jcaamano commented Sep 24, 2025

Uh oh!

openshift-ci bot commented Sep 24, 2025

Uh oh!

openshift-ci-robot commented Sep 24, 2025

📑 Description

Additional Information for reviewers

✅ Checks

How to verify it

Uh oh!

tsorya commented Sep 24, 2025

Uh oh!

tsorya commented Sep 24, 2025

Uh oh!

tsorya commented Sep 25, 2025

Uh oh!

dave-tucker commented Sep 26, 2025

Uh oh!

jcaamano commented Sep 26, 2025

Uh oh!

openshift-ci bot commented Sep 26, 2025

Uh oh!

jcaamano commented Sep 26, 2025

Uh oh!

openshift-ci bot commented Sep 26, 2025

Uh oh!

knobunc commented Sep 26, 2025

Uh oh!

wabouhamad commented Sep 26, 2025

Uh oh!

openshift-ci-robot commented Sep 26, 2025

Uh oh!

openshift-ci bot commented Sep 26, 2025

Uh oh!

Uh oh!

openshift-ci-robot commented Sep 26, 2025

📑 Description

Additional Information for reviewers

✅ Checks

How to verify it

Uh oh!

openshift-merge-robot commented Sep 27, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

18 participants

tsorya commented Sep 23, 2025 •

edited

Loading