[WIP] CORENET-59657: allow default network -> localnet on the same node for any localnet subnet#2726
[WIP] CORENET-59657: allow default network -> localnet on the same node for any localnet subnet#2726ricky-rav wants to merge 3 commits intoopenshift:masterfrom
Conversation
|
@ricky-rav: No Jira issue with key CORENET-59657 exists in the tracker at https://issues.redhat.com/. DetailsIn response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci
bot
added
the
do-not-merge/work-in-progress
|
@ricky-rav: No Jira issue with key CORENET-59657 exists in the tracker at https://issues.redhat.com/. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: ricky-rav The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
ricky-rav
force-pushed
the
CORENET-59657_420
branch
from
8089ec9 to
6576ddb
Compare
openshift-merge-robot
added
the
needs-rebase
|
/test |
|
@tssurya: The The following commands are available to trigger optional jobs: Use DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/payload-job periodic-ci-openshift-ovn-kubernetes-release-4.20-periodics-downstream-merge |
|
@tssurya: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/1d1dfea0-7e6f-11f0-8461-dc5c126c2b8c-0 |
|
/payload-job periodic-ci-openshift-ovn-kubernetes-release-4.20-periodics-downstream-merge |
|
@tssurya: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/5e7ff7a0-81d4-11f0-8d78-147461d9bb45-0 |
ricky-rav
force-pushed
the
CORENET-59657_420
branch
from
6576ddb to
7792ffd
Compare
openshift-merge-robot
removed
the
needs-rebase
ricky-rav
force-pushed
the
CORENET-59657_420
branch
from
7792ffd to
866138f
Compare
|
@ricky-rav: No Jira issue with key CORENET-59657 exists in the tracker at https://issues.redhat.com/. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
Fixes regression from 1448d5a The previous commit dropped matching on in_port so that localnet ports would also use table 1. This allows reply packets from a localnet pod towards the shared OVN/LOCAL IP to be sent to the correct port. However, a regression was introduced where traffic coming from these localnet ports to any destination would be sent to table 1. Egress traffic from the localnet ports is not committed to conntrack, so by sending to table=1 via CT we were getting a miss. This is especially bad for hardware offload where a localnet port is being used as the Geneve encap port. In this case all geneve traffic misses in CT lookup and is not offloaded. Table 1 is intended to be for handling IP traffic destined to the shared Gateway IP/MAC that both the Host and OVN use. It is also used to handle reply traffic for Egress IP. To fix this problem, we can add dl_dst match criteria to this flow, ensuring that only traffic destined to the Host/OVN goes to table 1. Furthermore, after fixing this problem there still exists the issue that localnet -> host/OVN egress traffic will still enter table 1 and CT miss. Potentially this can be fixed with always committing egress traffic, but it might have performance penalty, so deferring that fix to a later date. Signed-off-by: Tim Rozet <trozet@nvidia.com>
We did this for IPv4 in 1448d5a, but forgot about IPv6. Signed-off-by: Riccardo Ravaioli <rravaiol@redhat.com>
Add dl_dst=$breth0 to table=0, prio=50 for IPv6 We want to match in table=1 only conntrack'ed reply traffic whose next hop is either OVN or the host. As a consequence, localnet traffic whose next hop is an external router (and that might or might not be destined to OVN/host) should bypass table=1 and just hit the NORMAL flow in table=0. Signed-off-by: Riccardo Ravaioli <rravaiol@redhat.com>
ricky-rav
force-pushed
the
CORENET-59657_420
branch
from
866138f to
493bd87
Compare
|
@ricky-rav: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/payload-aggregate help |
|
@ricky-rav: it appears that you have attempted to use some version of the payload command, but your comment was incorrectly formatted and cannot be acted upon. See the docs for usage info. |
|
/payload 4.20 ci blocking |
|
@ricky-rav: trigger 5 job(s) of type blocking for the ci release of OCP 4.20
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/e60a3480-874f-11f0-8d8c-7218c8341668-0 trigger 10 job(s) of type blocking for the nightly release of OCP 4.20
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/e60a3480-874f-11f0-8d8c-7218c8341668-1 |
|
/payload-aggregate periodic-ci-openshift-release-master-ci-4.20-e2e-gcp-ovn-upgrade |
|
@ricky-rav: it appears that you have attempted to use some version of the payload command, but your comment was incorrectly formatted and cannot be acted upon. See the docs for usage info. |
|
/payload-aggregate periodic-ci-openshift-release-master-ci-4.20-e2e-gcp-ovn-upgrade 5 |
|
@ricky-rav: trigger 3 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/54dca7e0-87db-11f0-8486-2525d5d4339c-0 |
|
/retest |
|
/retest-required |
|
The OVS CPU consumption looks in line with the values we saw in the past, with no increase with respect to our baseline. In a previous PR I observed that values were in the 650-750 range for Similarly, I took the first four jobs for |
Verifying the failures: Starting with gcp-ovn-upgrade2/5 passed, 3 failed: is known bug tracked here: https://issues.redhat.com/browse/OCPBUGS-59496 Pod in place resize issues is unrelated @ricky-rav I don't know what this is: is this actually happening in other lanes? gcp-ovn-upgrade-rt variantrt is also struggling on presubmits: https://prow.ci.openshift.org/view/gs/test-platform-results/pr-logs/pull/openshift_ovn-kubernetes/2726/pull-ci-openshift-ovn-kubernetes-master-4.20-upgrade-from-stable-4.19-e2e-gcp-ovn-rt-upgrade/1962411971949105152 and https://prow.ci.openshift.org/view/gs/test-platform-results/pr-logs/pull/openshift_ovn-kubernetes/2726/pull-ci-openshift-ovn-kubernetes-master-4.20-upgrade-from-stable-4.19-e2e-gcp-ovn-rt-upgrade/1962803114826272768 both unrelated for periodics 5/5 failed which is super bad
@ricky-rav please do the same for the 3rd periodics i.e AWS |
|
/payload-aggregate periodic-ci-openshift-release-master-ci-4.20-e2e-gcp-ovn-upgrade 5 |
|
@tssurya: trigger 3 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/075faf80-88a8-11f0-86d5-0a400830c660-0 |
5 participants
Testing upstream PR ovn-kubernetes/ovn-kubernetes#5480 on downstream CI