OCPBUGS-48678: Update OVN to FDP25.A.1 24.09.2-41 by dceara · Pull Request #2493 · openshift/ovn-kubernetes

dceara · 2025-03-19T08:57:20Z

📑 Description

This contains the following relevant changes:
- controller: Fix active mac-binding refresh for IPv6.
- controller: Send ARP/ND for stale mac_bindings entries. (#FDP-1135)
https://issues.redhat.com/browse/FDP-1135
- northd: Fix action parsing in build_lb_vip_actions(). (#FDP-1095)
https://issues.redhat.com/browse/FDP-1095
- northd: Fix missing tier related ACL flows. (#FDP-1154)
https://issues.redhat.com/browse/FDP-1154
- mac-cache: Fix expiration of active FDB entry due to skipped update. (#FDP-1132)
https://issues.redhat.com/browse/FDP-1132
- mac-cache: Fix expiration of active MAC binding due to skipped update. (#FDP-1130)
https://issues.redhat.com/browse/FDP-1130
- mac-cache: Fix MAC binding entry lookup for timestamp refresh. (#FDP-1131)
https://issues.redhat.com/browse/FDP-1131

Fixes #

Additional Information for reviewers

✅ Checks

My code requires changes to the documentation
if so, I have updated the documentation as required
My code requires tests
if so, I have added and/or updated the tests as required
All the tests have passed in the CI

How to verify it

openshift-ci · 2025-03-19T08:57:25Z

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

dceara · 2025-03-19T09:21:37Z

/test all

zshi-redhat · 2025-03-19T10:00:16Z

/test e2e-aws-ovn-fdp-qe

asood-rh · 2025-03-19T13:45:20Z

/label qe-approved

This contains the following relevant changes: - controller: Fix active mac-binding refresh for IPv6. - controller: Send ARP/ND for stale mac_bindings entries. (#FDP-1135) https://issues.redhat.com/browse/FDP-1135 - northd: Fix action parsing in build_lb_vip_actions(). (#FDP-1095) https://issues.redhat.com/browse/FDP-1095 - northd: Fix missing tier related ACL flows. (#FDP-1154) https://issues.redhat.com/browse/FDP-1154 - mac-cache: Fix expiration of active FDB entry due to skipped update. (#FDP-1132) https://issues.redhat.com/browse/FDP-1132 - mac-cache: Fix expiration of active MAC binding due to skipped update. (#FDP-1130) https://issues.redhat.com/browse/FDP-1130 - mac-cache: Fix MAC binding entry lookup for timestamp refresh. (#FDP-1131) https://issues.redhat.com/browse/FDP-1131 Signed-off-by: Dumitru Ceara <dceara@redhat.com>

dceara · 2025-03-20T14:15:32Z

/hold

Until FDP 25.A.1 is actually released.

dceara · 2025-03-20T14:34:42Z

/remove-label qe-approved

zshi-redhat · 2025-03-24T07:35:16Z

/test images

zshi-redhat · 2025-03-24T10:09:32Z

/test images

igsilya · 2025-03-24T10:52:40Z

/remove-hold
/retest

zshi-redhat · 2025-03-24T12:00:56Z

/test e2e-aws-ovn-fdp-qe

zshi-redhat · 2025-03-24T15:40:24Z

/retest-required

zshi-redhat · 2025-03-24T16:06:43Z

/test 4.19-upgrade-from-stable-4.18-e2e-gcp-ovn-rt-upgrade

asood-rh · 2025-03-24T18:13:20Z

/test e2e-aws-ovn-fdp-qe

asood-rh · 2025-03-24T18:14:01Z

/retest-required

asood-rh · 2025-03-24T20:16:55Z

/retest-required

asood-rh · 2025-03-24T20:21:36Z

/test e2e-aws-ovn-hypershift

asood-rh · 2025-03-25T00:20:24Z

/test e2e-aws-ovn-fdp-qe

zhaozhanqi · 2025-03-25T01:18:22Z

/test e2e-aws-ovn-fdp-qe

asood-rh · 2025-03-25T02:01:56Z

/test e2e-aws-ovn-fdp-qe

@zhaozhanqi There was a job underway - 1 hr ago that I triggered., this one was 42 mins ago.

zhaozhanqi · 2025-03-25T02:11:00Z

/test e2e-aws-ovn-fdp-qe

@zhaozhanqi There was a job underway - 1 hr ago that I triggered., this on was 42 mins ago.

Yes, I saw it, However the job is failed due to some reason ( not sure). so I triggered again to see if it's flake issue

zhaozhanqi · 2025-03-25T06:06:00Z

all tests pass in job https://prow.ci.openshift.org/view/gs/test-platform-results/pr-logs/pull/openshift_ovn-kubernetes/2493/pull-ci-openshift-ovn-kubernetes-master-e2e-aws-ovn-fdp-qe/1904342071607562240

/label qe-approved

openshift-ci · 2025-03-25T06:06:44Z

@dceara: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/security	`9c4499b`	link	false	`/test security`
ci/prow/e2e-metal-ipi-ovn-dualstack-bgp-techpreview	`9c4499b`	link	false	`/test e2e-metal-ipi-ovn-dualstack-bgp-techpreview`
ci/prow/e2e-aws-ovn-hypershift-conformance-techpreview	`9c4499b`	link	false	`/test e2e-aws-ovn-hypershift-conformance-techpreview`
ci/prow/e2e-aws-ovn-single-node-techpreview	`9c4499b`	link	false	`/test e2e-aws-ovn-single-node-techpreview`
ci/prow/e2e-vsphere-ovn-techpreview	`9c4499b`	link	false	`/test e2e-vsphere-ovn-techpreview`
ci/prow/e2e-azure-ovn	`9c4499b`	link	false	`/test e2e-azure-ovn`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

tssurya · 2025-03-25T06:29:37Z


 ARG ovsver=3.4.0-18.el9fdp
-ARG ovnver=24.09.2-14.el9fdp
+ARG ovnver=24.09.2-41.el9fdp


usually the master bump first has to happen upstream, relevant tests in e2e if any have to be added for the corresponding fixes that are being brought in on OCP side, example the ACL drop with allow-related not working as expected with some ANP tests and LB DROP with zero backends for services. I have not looked into the MAC Binding timing issues but I can tell that's hard to test on e2e level which seems to be fixes related to the customer case here ? @zshi-redhat where are the relevant bugs on OCP side for the fix you are targeting? What exactly is the user bug here? The bump shows the fixes being brought in but which one is relevant here? IMHO Correct way is:

OCPBUGS for this case should have the assignee who bumps it upstream first: https://github.com/ovn-kubernetes/ovn-kubernetes/blob/master/dist/images/Dockerfile.fedora#L78

evaluates if e2e tests are required for the new bug fixes and adds them and if not explain why not

Then do the same in OCP with QE's assignee's help

Given the urgency I can try to label this by by-passing the above three points (but I have no context), but only if I know what did OCP QE add as new tests to fix this bug? Is there a link to polarion with the relevant tests for this bug fix? Meaning how do I know this works in OCP's bug case?

I know Anusaxen added tests on https://issues.redhat.com/browse/OCPQE-28285

thank you @zhaozhanqi that's perfect, does that mean that test is already catching the bug and that has been run on this PR already ? @anuragthehatter ?
@arghosh93 : this fix is for this bug: https://issues.redhat.com/browse/OCPBUGS-48678 after shift week can you please take take of points 1 & 2 ? Bug shouldn't be closed without test coverage upstream. - that's the only way to catch regressions before they land downstream

Zhanqi Zhao
Yes,
@zshi
OCP-80439:anusaxen:SDN:[sig-networking] SDN misc [FdpOvnOvs] [NETWORKCUSIM] pod to external traffic doesnt require OVN to create mac-binding entry for Join subnet gateway IP [Disruptive] [Serial] passed on job

tssurya

/approve

tssurya · 2025-03-25T08:28:14Z

/retitle OCPBUGS-48678: Update OVN to FDP25.A.1 24.09.2-41

openshift-ci-robot · 2025-03-25T08:28:23Z

@dceara: This pull request references Jira Issue OCPBUGS-48678, which is invalid:

expected the bug to target the "4.19.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

📑 Description

This contains the following relevant changes:

controller: Fix active mac-binding refresh for IPv6.

controller: Send ARP/ND for stale mac_bindings entries. (#FDP-1135)
https://issues.redhat.com/browse/FDP-1135

northd: Fix action parsing in build_lb_vip_actions(). (#FDP-1095)
https://issues.redhat.com/browse/FDP-1095

northd: Fix missing tier related ACL flows. (#FDP-1154)
https://issues.redhat.com/browse/FDP-1154

mac-cache: Fix expiration of active FDB entry due to skipped update. (#FDP-1132)
https://issues.redhat.com/browse/FDP-1132

mac-cache: Fix expiration of active MAC binding due to skipped update. (#FDP-1130)
https://issues.redhat.com/browse/FDP-1130

mac-cache: Fix MAC binding entry lookup for timestamp refresh. (#FDP-1131)
https://issues.redhat.com/browse/FDP-1131

Fixes #

Additional Information for reviewers

✅ Checks

My code requires changes to the documentation

if so, I have updated the documentation as required

My code requires tests

if so, I have added and/or updated the tests as required

All the tests have passed in the CI

How to verify it

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

tssurya · 2025-03-25T08:31:27Z

/label acknowledge-critical-fixes-only

Fix going in for a PRIO Ticket: https://issues.redhat.com/browse/RHOCPPRIO-408
https://issues.redhat.com/browse/OCPBUGS-48678
seems like this is needed before the next 4.16.z dev cut-off date: https://redhat-internal.slack.com/archives/C01G7T6SYSD/p1742883046239849?thread_ts=1741840506.436859&cid=C01G7T6SYSD

zshi-redhat · 2025-03-25T08:38:56Z

/jira refresh

openshift-ci-robot · 2025-03-25T08:39:06Z

@zshi-redhat: This pull request references Jira Issue OCPBUGS-48678, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.19.0) matches configured target version for branch (4.19.0)
bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @zhaozhanqi

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

zshi-redhat · 2025-03-25T08:39:33Z

/lgtm

openshift-ci · 2025-03-25T08:39:55Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dceara, tssurya, zshi-redhat

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [tssurya]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci-robot · 2025-03-25T08:43:57Z

@dceara: Jira Issue OCPBUGS-48678: All pull requests linked via external trackers have merged:

openshift/ovn-kubernetes#2493

Jira Issue OCPBUGS-48678 has been moved to the MODIFIED state.

Details

In response to this:

📑 Description

This contains the following relevant changes:

controller: Fix active mac-binding refresh for IPv6.

controller: Send ARP/ND for stale mac_bindings entries. (#FDP-1135)
https://issues.redhat.com/browse/FDP-1135

northd: Fix action parsing in build_lb_vip_actions(). (#FDP-1095)
https://issues.redhat.com/browse/FDP-1095

northd: Fix missing tier related ACL flows. (#FDP-1154)
https://issues.redhat.com/browse/FDP-1154

mac-cache: Fix expiration of active FDB entry due to skipped update. (#FDP-1132)
https://issues.redhat.com/browse/FDP-1132

mac-cache: Fix expiration of active MAC binding due to skipped update. (#FDP-1130)
https://issues.redhat.com/browse/FDP-1130

mac-cache: Fix MAC binding entry lookup for timestamp refresh. (#FDP-1131)
https://issues.redhat.com/browse/FDP-1131

Fixes #

Additional Information for reviewers

✅ Checks

My code requires changes to the documentation

if so, I have updated the documentation as required

My code requires tests

if so, I have added and/or updated the tests as required

All the tests have passed in the CI

How to verify it

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-bot · 2025-03-25T13:06:10Z

[ART PR BUILD NOTIFIER]

Distgit: ovn-kubernetes-base
This PR has been included in build ose-ovn-kubernetes-base-container-v4.19.0-202503251208.p0.g12b33c1.assembly.stream.el9.
All builds following this will include this PR.

openshift-bot · 2025-03-25T13:21:18Z

[ART PR BUILD NOTIFIER]

Distgit: ovn-kubernetes-microshift
This PR has been included in build ovn-kubernetes-microshift-container-v4.19.0-202503251208.p0.g12b33c1.assembly.stream.el9.
All builds following this will include this PR.

openshift-bot · 2025-03-25T13:33:18Z

[ART PR BUILD NOTIFIER]

Distgit: ose-ovn-kubernetes
This PR has been included in build ose-ovn-kubernetes-container-v4.19.0-202503251208.p0.g12b33c1.assembly.stream.el9.
All builds following this will include this PR.

openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 19, 2025

openshift-ci Bot added the qe-approved Signifies that QE has signed off on this PR label Mar 19, 2025

dceara force-pushed the FDP25.A.1-master branch from b2b0538 to 9c4499b Compare March 20, 2025 13:56

openshift-ci Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 20, 2025

dceara marked this pull request as ready for review March 20, 2025 14:15

dceara changed the title ~~[WIP][DNM] Update OVN to FDP25.A.1 24.09.2-41 for testing.~~ Update OVN to FDP25.A.1 24.09.2-41. Mar 20, 2025

openshift-ci Bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 20, 2025

openshift-ci Bot requested review from jcaamano and tssurya March 20, 2025 14:18

openshift-ci Bot removed the qe-approved Signifies that QE has signed off on this PR label Mar 20, 2025

openshift-ci Bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 24, 2025

openshift-ci Bot added the qe-approved Signifies that QE has signed off on this PR label Mar 25, 2025

tssurya reviewed Mar 25, 2025

View reviewed changes

tssurya approved these changes Mar 25, 2025

View reviewed changes

openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 25, 2025

openshift-ci Bot changed the title ~~Update OVN to FDP25.A.1 24.09.2-41.~~ OCPBUGS-48678: Update OVN to FDP25.A.1 24.09.2-41 Mar 25, 2025

openshift-ci-robot added jira/severity-critical Referenced Jira bug's severity is critical for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. labels Mar 25, 2025

openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Mar 25, 2025

openshift-ci Bot added the acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. label Mar 25, 2025

openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Mar 25, 2025

openshift-ci Bot requested a review from zhaozhanqi March 25, 2025 08:39

openshift-ci Bot assigned zshi-redhat Mar 25, 2025

openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Mar 25, 2025

openshift-merge-bot Bot merged commit 12b33c1 into openshift:master Mar 25, 2025

Uh oh!

Conversation

dceara commented Mar 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📑 Description

Additional Information for reviewers

✅ Checks

How to verify it

Uh oh!

openshift-ci Bot commented Mar 19, 2025

Uh oh!

dceara commented Mar 19, 2025

Uh oh!

zshi-redhat commented Mar 19, 2025

Uh oh!

asood-rh commented Mar 19, 2025

Uh oh!

dceara commented Mar 20, 2025

Uh oh!

dceara commented Mar 20, 2025

Uh oh!

zshi-redhat commented Mar 24, 2025

Uh oh!

zshi-redhat commented Mar 24, 2025

Uh oh!

igsilya commented Mar 24, 2025

Uh oh!

zshi-redhat commented Mar 24, 2025

Uh oh!

zshi-redhat commented Mar 24, 2025

Uh oh!

zshi-redhat commented Mar 24, 2025

Uh oh!

asood-rh commented Mar 24, 2025

Uh oh!

asood-rh commented Mar 24, 2025

Uh oh!

asood-rh commented Mar 24, 2025

Uh oh!

asood-rh commented Mar 24, 2025

Uh oh!

asood-rh commented Mar 25, 2025

Uh oh!

zhaozhanqi commented Mar 25, 2025

Uh oh!

asood-rh commented Mar 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

zhaozhanqi commented Mar 25, 2025

Uh oh!

zhaozhanqi commented Mar 25, 2025

Uh oh!

openshift-ci Bot commented Mar 25, 2025

Uh oh!

tssurya Mar 25, 2025

Choose a reason for hiding this comment

Uh oh!

zhaozhanqi Mar 25, 2025

Choose a reason for hiding this comment

Uh oh!

tssurya Mar 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

tssurya Mar 25, 2025

Choose a reason for hiding this comment

Uh oh!

tssurya left a comment

Choose a reason for hiding this comment

Uh oh!

tssurya commented Mar 25, 2025

Uh oh!

openshift-ci-robot commented Mar 25, 2025 • edited by openshift-ci Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📑 Description

Additional Information for reviewers

✅ Checks

How to verify it

Uh oh!

tssurya commented Mar 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

dceara commented Mar 19, 2025 •

edited

Loading

asood-rh commented Mar 25, 2025 •

edited

Loading

tssurya Mar 25, 2025 •

edited

Loading

openshift-ci-robot commented Mar 25, 2025 •

edited by openshift-ci Bot

Loading

tssurya commented Mar 25, 2025 •

edited

Loading

openshift-ci-robot commented Mar 25, 2025 •

edited by openshift-ci Bot

Loading